ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
59 lines
1.8 KiB
C++
59 lines
1.8 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
||
// Use of this source code is governed by a BSD-style license that can be
|
||
// found in the LICENSE file.
|
||
|
||
#ifdef V8_INTL_SUPPORT
|
||
|
||
#include <stdlib.h>
|
||
|
||
#include "include/v8-isolate.h"
|
||
#include "include/v8-local-handle.h"
|
||
#include "src/objects/objects-inl.h"
|
||
#include "test/cctest/cctest.h"
|
||
#include "unicode/locid.h"
|
||
|
||
namespace {
|
||
void CheckLocaleSpecificValues(const char* locale, const char* date,
|
||
const char* number) {
|
||
CHECK(v8_str(locale)->StrictEquals(
|
||
CompileRun("Intl.NumberFormat().resolvedOptions().locale")));
|
||
CHECK(v8_str(date)->StrictEquals(
|
||
CompileRun("new Date('02/14/2020 13:45').toLocaleString()")));
|
||
CHECK(v8_str(number)->StrictEquals(
|
||
CompileRun("Number(10000.3).toLocaleString()")));
|
||
}
|
||
|
||
void SetIcuLocale(const char* locale_name) {
|
||
UErrorCode error_code = U_ZERO_ERROR;
|
||
icu::Locale locale(locale_name);
|
||
icu::Locale::setDefault(locale, error_code);
|
||
CHECK(U_SUCCESS(error_code));
|
||
}
|
||
} // namespace
|
||
|
||
TEST(LocaleConfigurationChangeNotification) {
|
||
icu::Locale default_locale = icu::Locale::getDefault();
|
||
|
||
LocalContext context;
|
||
v8::Isolate* isolate = context->GetIsolate();
|
||
v8::HandleScope scope(isolate);
|
||
|
||
SetIcuLocale("en_US");
|
||
isolate->LocaleConfigurationChangeNotification();
|
||
CheckLocaleSpecificValues("en-US", "2/14/2020, 1:45:00 PM", "10,000.3");
|
||
|
||
SetIcuLocale("ru_RU");
|
||
isolate->LocaleConfigurationChangeNotification();
|
||
CheckLocaleSpecificValues("ru-RU", "14.02.2020, 13:45:00", "10 000,3");
|
||
|
||
SetIcuLocale("zh_CN");
|
||
isolate->LocaleConfigurationChangeNotification();
|
||
CheckLocaleSpecificValues("zh-CN", "2020/2/14 下午1:45:00", "10,000.3");
|
||
|
||
UErrorCode error_code = U_ZERO_ERROR;
|
||
icu::Locale::setDefault(default_locale, error_code);
|
||
CHECK(U_SUCCESS(error_code));
|
||
}
|
||
|
||
#endif // V8_INTL_SUPPORT
|