59d838ad2a
This is a reland of commit ed8953b695
Changes since revert:
- Work around recorded slot bug for external strings.
Original change's description:
> [strings] Fix dictionary forwarded string hash lookup
>
> Strings forwarded to external resources have their real hashes stored in
> the forwarding table. Dictionary mode lookups currently do not correctly
> load the hash for these tables, causing misses for properties that are
> in fact in the object.
>
> Bug: v8:12007
> Change-Id: I60ca4c084db7ddf6d2b7f7be8f63519c9cf3bc73
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3935218
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Shu-yu Guo <syg@chromium.org>
> Reviewed-by: Patrick Thier <pthier@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#83577}
Bug: v8:12007
Change-Id: Ifef5f99a46c239b2113aefa4efcdda1df1b4b6a6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3940294
Reviewed-by: Patrick Thier <pthier@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83635}
39 lines
1.1 KiB
JavaScript
39 lines
1.1 KiB
JavaScript
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
//
|
|
// Flags: --expose-externalize-string --shared-string-table
|
|
|
|
const long_key = 'key1234567890abcdefg';
|
|
const substr_key = long_key.substring(3,17);
|
|
const consstr_key = 'key' + 1234567890 + 'abcdefg';
|
|
const integer_index = long_key.substring(3,8);
|
|
|
|
{
|
|
let obj = [];
|
|
for (let i = 0; i < 100; ++i) {
|
|
obj[i] = i;
|
|
obj['XXX' + i] = 'XXX' + i;
|
|
}
|
|
|
|
obj['key1234567890abcdefg'] = 'long_key_value';
|
|
obj['1234567890abcd'] = 'substr_value';
|
|
obj[12345] = 'integer_index';
|
|
|
|
try {
|
|
externalizeString(long_key);
|
|
externalizeString(substr_key);
|
|
externalizeString(consstr_key);
|
|
externalizeString(integer_index);
|
|
} catch {}
|
|
|
|
(function exerciseICs() {
|
|
for (let i = 0; i < 10; i++) {
|
|
assertEquals('long_key_value', obj[long_key]);
|
|
assertEquals('substr_value', obj[substr_key]);
|
|
assertEquals('long_key_value', obj[consstr_key]);
|
|
assertEquals('integer_index', obj[integer_index]);
|
|
}
|
|
})();
|
|
}
|