51e6ecb9df
This reverts commit 5b434929a3.
Changes after the original CL:
- Right-trimming registers the array as an object with invalidated
slots.
- Left-trimming moves the array start in the invalidated slots map.
Original change's description:
> Fix invalidation of old-to-old slots after object trimming.
>
> A recorded old-to-old slot may be overwritten with a pointer to a new
> space object. If the object containing the slot is trimmed later on,
> then the mark-compactor may crash on a stale pointer to new space.
>
> This patch ensures that:
> 1) On trimming of an object we add it to the invalidated_slots sets.
> 2) The InvalidatedSlotsFilter::IsValid returns false for slots outside
> the invalidated object unless the page was already swept.
>
> Array left-trimming is handled as a special case because object start
> moves and cannot be added to the invalidated set. Instead, we clear
> the freed memory so that the recorded slots contain Smi values.
>
> Bug: chromium:870226,chromium:816426
> Change-Id: Iffc05a58fcf52ece45fdb085b5d1fd4b3acb5d53
> Reviewed-on: https://chromium-review.googlesource.com/1163784
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54953}
Change-Id: I1f1080f680196c581f62aef8d3a00a595f9bb9b0
Reviewed-on: https://chromium-review.googlesource.com/1165555
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55066}
112 lines
4.7 KiB
C++
112 lines
4.7 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef HEAP_HEAP_TESTER_H_
|
|
#define HEAP_HEAP_TESTER_H_
|
|
|
|
#include "src/heap/spaces.h"
|
|
|
|
// Tests that should have access to private methods of {v8::internal::Heap}.
|
|
// Those tests need to be defined using HEAP_TEST(Name) { ... }.
|
|
#define HEAP_TEST_METHODS(V) \
|
|
V(CompactionFullAbortedPage) \
|
|
V(CompactionPartiallyAbortedPage) \
|
|
V(CompactionPartiallyAbortedPageIntraAbortedPointers) \
|
|
V(CompactionPartiallyAbortedPageWithStoreBufferEntries) \
|
|
V(CompactionSpaceDivideMultiplePages) \
|
|
V(CompactionSpaceDivideSinglePage) \
|
|
V(InvalidatedSlotsAfterTrimming) \
|
|
V(InvalidatedSlotsAllInvalidatedRanges) \
|
|
V(InvalidatedSlotsEvacuationCandidate) \
|
|
V(InvalidatedSlotsNoInvalidatedRanges) \
|
|
V(InvalidatedSlotsResetObjectRegression) \
|
|
V(InvalidatedSlotsRightTrimFixedArray) \
|
|
V(InvalidatedSlotsRightTrimLargeFixedArray) \
|
|
V(InvalidatedSlotsLeftTrimFixedArray) \
|
|
V(InvalidatedSlotsFastToSlow) \
|
|
V(InvalidatedSlotsSomeInvalidatedRanges) \
|
|
V(TestNewSpaceRefsInCopiedCode) \
|
|
V(GCFlags) \
|
|
V(MarkCompactCollector) \
|
|
V(NoPromotion) \
|
|
V(NumberStringCacheSize) \
|
|
V(ObjectGroups) \
|
|
V(Promotion) \
|
|
V(Regression39128) \
|
|
V(ResetWeakHandle) \
|
|
V(StressHandles) \
|
|
V(TestMemoryReducerSampleJsCalls) \
|
|
V(TestSizeOfObjects) \
|
|
V(Regress5831) \
|
|
V(Regress538257) \
|
|
V(Regress587004) \
|
|
V(Regress589413) \
|
|
V(Regress658718) \
|
|
V(Regress670675) \
|
|
V(Regress777177) \
|
|
V(Regress779503) \
|
|
V(Regress791582) \
|
|
V(Regress845060) \
|
|
V(RegressMissingWriteBarrierInAllocate) \
|
|
V(WriteBarriersInCopyJSObject)
|
|
|
|
#define HEAP_TEST(Name) \
|
|
CcTest register_test_##Name(v8::internal::heap::HeapTester::Test##Name, \
|
|
__FILE__, #Name, true, true); \
|
|
void v8::internal::heap::HeapTester::Test##Name()
|
|
|
|
#define UNINITIALIZED_HEAP_TEST(Name) \
|
|
CcTest register_test_##Name(v8::internal::heap::HeapTester::Test##Name, \
|
|
__FILE__, #Name, true, false); \
|
|
void v8::internal::heap::HeapTester::Test##Name()
|
|
|
|
#define THREADED_HEAP_TEST(Name) \
|
|
RegisterThreadedTest register_##Name( \
|
|
v8::internal::heap::HeapTester::Test##Name, #Name); \
|
|
/* */ HEAP_TEST(Name)
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
template <typename T>
|
|
class Handle;
|
|
|
|
namespace heap {
|
|
|
|
class HeapTester {
|
|
public:
|
|
#define DECLARE_STATIC(Name) static void Test##Name();
|
|
|
|
HEAP_TEST_METHODS(DECLARE_STATIC)
|
|
#undef HEAP_TEST_METHODS
|
|
|
|
// test-alloc.cc
|
|
static AllocationResult AllocateAfterFailures();
|
|
static Handle<Object> TestAllocateAfterFailures();
|
|
|
|
// test-invalidated-slots.cc
|
|
static Page* AllocateByteArraysOnPage(Heap* heap,
|
|
std::vector<ByteArray*>* byte_arrays);
|
|
|
|
// test-api.cc
|
|
static void ResetWeakHandle(bool global_gc);
|
|
|
|
// test-heap.cc
|
|
static AllocationResult AllocateByteArrayForTest(Heap* heap, int length,
|
|
PretenureFlag pretenure);
|
|
|
|
// test-mark-compact.cc
|
|
static AllocationResult AllocateMapForTest(v8::internal::Isolate* isolate);
|
|
static AllocationResult AllocateFixedArrayForTest(Heap* heap, int length,
|
|
PretenureFlag pretenure);
|
|
|
|
static void UncommitFromSpace(Heap* heap);
|
|
};
|
|
|
|
} // namespace heap
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // HEAP_HEAP_TESTER_H_
|