ed2be747ad
When accessor getter callback is called the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according to ES6 there's no difference between strict and non-strict property loads. For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true if the property is set in strict context. Interceptors follow same idea: for getter, enumerator and query callbacks the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true in strict context. This CL also cleans up the CallApiGetterStub and removes bogus asserts from [arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers containing duplicates. BUG=v8:4267 LOG=Y Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f Cr-Commit-Position: refs/heads/master@{#33438} Review URL: https://codereview.chromium.org/1587073003 Cr-Commit-Position: refs/heads/master@{#33461}
104 lines
4.1 KiB
C++
104 lines
4.1 KiB
C++
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/arguments.h"
|
|
|
|
#include "src/api.h"
|
|
#include "src/vm-state-inl.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
|
|
template <typename T>
|
|
template <typename V>
|
|
v8::Local<V> CustomArguments<T>::GetReturnValue(Isolate* isolate) {
|
|
// Check the ReturnValue.
|
|
Object** handle = &this->begin()[kReturnValueOffset];
|
|
// Nothing was set, return empty handle as per previous behaviour.
|
|
if ((*handle)->IsTheHole()) return v8::Local<V>();
|
|
return Utils::Convert<Object, V>(Handle<Object>(handle));
|
|
}
|
|
|
|
|
|
v8::Local<v8::Value> FunctionCallbackArguments::Call(FunctionCallback f) {
|
|
Isolate* isolate = this->isolate();
|
|
VMState<EXTERNAL> state(isolate);
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
|
|
FunctionCallbackInfo<v8::Value> info(begin(),
|
|
argv_,
|
|
argc_,
|
|
is_construct_call_);
|
|
f(info);
|
|
return GetReturnValue<v8::Value>(isolate);
|
|
}
|
|
|
|
|
|
#define WRITE_CALL_0(Function, ReturnValue) \
|
|
v8::Local<ReturnValue> PropertyCallbackArguments::Call(Function f) { \
|
|
Isolate* isolate = this->isolate(); \
|
|
VMState<EXTERNAL> state(isolate); \
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
|
|
PropertyCallbackInfo<ReturnValue> info(begin()); \
|
|
f(info); \
|
|
return GetReturnValue<ReturnValue>(isolate); \
|
|
}
|
|
|
|
|
|
#define WRITE_CALL_1(Function, ReturnValue, Arg1) \
|
|
v8::Local<ReturnValue> PropertyCallbackArguments::Call(Function f, \
|
|
Arg1 arg1) { \
|
|
Isolate* isolate = this->isolate(); \
|
|
VMState<EXTERNAL> state(isolate); \
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
|
|
PropertyCallbackInfo<ReturnValue> info(begin()); \
|
|
f(arg1, info); \
|
|
return GetReturnValue<ReturnValue>(isolate); \
|
|
}
|
|
|
|
|
|
#define WRITE_CALL_2(Function, ReturnValue, Arg1, Arg2) \
|
|
v8::Local<ReturnValue> PropertyCallbackArguments::Call( \
|
|
Function f, Arg1 arg1, Arg2 arg2) { \
|
|
Isolate* isolate = this->isolate(); \
|
|
VMState<EXTERNAL> state(isolate); \
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
|
|
PropertyCallbackInfo<ReturnValue> info(begin()); \
|
|
f(arg1, arg2, info); \
|
|
return GetReturnValue<ReturnValue>(isolate); \
|
|
}
|
|
|
|
|
|
#define WRITE_CALL_2_VOID(Function, ReturnValue, Arg1, Arg2) \
|
|
void PropertyCallbackArguments::Call(Function f, Arg1 arg1, Arg2 arg2) { \
|
|
Isolate* isolate = this->isolate(); \
|
|
VMState<EXTERNAL> state(isolate); \
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
|
|
PropertyCallbackInfo<ReturnValue> info(begin()); \
|
|
f(arg1, arg2, info); \
|
|
}
|
|
|
|
|
|
FOR_EACH_CALLBACK_TABLE_MAPPING_0(WRITE_CALL_0)
|
|
FOR_EACH_CALLBACK_TABLE_MAPPING_1(WRITE_CALL_1)
|
|
FOR_EACH_CALLBACK_TABLE_MAPPING_2(WRITE_CALL_2)
|
|
FOR_EACH_CALLBACK_TABLE_MAPPING_2_VOID_RETURN(WRITE_CALL_2_VOID)
|
|
|
|
#undef WRITE_CALL_0
|
|
#undef WRITE_CALL_1
|
|
#undef WRITE_CALL_2
|
|
#undef WRITE_CALL_2_VOID
|
|
|
|
|
|
double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) {
|
|
// TODO(ulan): This clobbers only subset of registers depending on compiler,
|
|
// Rewrite this in assembly to really clobber all registers.
|
|
// GCC for ia32 uses the FPU and does not touch XMM registers.
|
|
return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04;
|
|
}
|
|
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|