b086cb7b9a
With lazy feedback allocation and bytecode flushing we need to call %PrepareFunctionForOptimize before we call %OptimizeFunctionOnNextCall/ %OptimizeOsr. This cl: 1. Adds an additional state in pending optimized table to check if the optimization was triggered manually. 2. Changes the compilation pipeline to delete the entry from pending optimized table only if the optimization was triggered through %OptimizeFunctionOnNextCall / %OptimizeOsr. 3. Adds a check to enforce %PrepareFunctionForOptimize was called. 4. Adds a new run-time flag to only check in the d8 test runner. We don't want this check enabled in other cases like clusterfuzz that doesn't ensure %PrepareFunctionForOptimize is called. Bug: v8:8394, v8:8801, v8:9183 Change-Id: I9ae2b2da812e313c746b6df0b2da864c2ed5de51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664810 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62653}
35 lines
833 B
JavaScript
35 lines
833 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
(function TestNonLoopyLoop() {
|
|
function f() {
|
|
do {
|
|
%OptimizeOsr();
|
|
return 23;
|
|
} while(false)
|
|
}
|
|
%PrepareFunctionForOptimization(f);
|
|
assertEquals(23, f());
|
|
%PrepareFunctionForOptimization(f);
|
|
assertEquals(23, f());
|
|
})();
|
|
|
|
(function TestNonLoopyGenerator() {
|
|
function* g() {
|
|
do {
|
|
%OptimizeOsr();
|
|
yield 23;
|
|
yield 42;
|
|
} while(false)
|
|
return 999;
|
|
}
|
|
%PrepareFunctionForOptimization(g);
|
|
var gen = g();
|
|
assertEquals({ value:23, done:false }, gen.next());
|
|
assertEquals({ value:42, done:false }, gen.next());
|
|
assertEquals({ value:999, done:true }, gen.next());
|
|
})();
|