4ca9d843f8
Previously, the class fields initializer function was stored on a
synthetic context allocated variable. This approach had sevaral
problems:
- We didn't know that class literal had fields until after we had
completely parsed the class literal. This meant that we had to go back
and fix up the scope of the constructor to have this synthetic
variable. This resulted in mismatch between parser and preparsed scope
data.
- This synthetic variable could potentially resolve to an initializer
of an outer class.
For ex:
class X extends Object {
c = 1;
constructor() {
var t = () => {
class P extends Object {
constructor() {
var t = () => { super(); };
t();
}
}
super();
}
t();
}
}
In this the inner class P could access the outer class X's initiliazer
function. We would have to maintain extra metadata to make sure this
doesn't happen.
Instead this new approach uses a private symbol to store the
initializer function on the class constructor itself.
For the base constructor case, we can simply check for a bit on the
constructor function literal to see if we need to emit code that loads
and calls this initializer function. Therefore, we don't pay the cost
of loading this function in case there are no class fields.
For the derived constructor case, there are two possiblities:
(a) We are in a super() call directly in the derived constructor:
In this case we can do a check similar to the base constructor check,
we can check for a bit on the derived constructor and emit code for
loading and calling the initializer function.
This is usually the common case and we don't pay any cost for not using
class fields.
(b) We are in a super() call inside an arrow function in the derived
constructor:
In this case, we /always/ emit code to load and call the initializer
function. If the function doesn't exist then we have undefined and we
don't call anything. Otherwise we call the function.
super() can't be called twice so even if we emit code to load and call
the initializer function multiple times, it doesn't matter because it
would have already been an error.
Bug: v8:5367
Change-Id: I7f77cd6493ff84cf0e430a8c1039bc9ac6941a88
Reviewed-on: https://chromium-review.googlesource.com/781660
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49628}
130 lines
3.2 KiB
Plaintext
130 lines
3.2 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 19
|
|
bytecodes: [
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
/* 93 E> */ B(StackCheck),
|
|
/* 93 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(4),
|
|
B(Ldar), R(0),
|
|
/* 93 E> */ B(ConstructWithSpread), R(4), R(2), U8(1), U8(0),
|
|
/* 93 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 8
|
|
parameter count: 1
|
|
bytecode array length: 40
|
|
bytecodes: [
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
/* 128 E> */ B(StackCheck),
|
|
B(Mov), R(2), R(3),
|
|
/* 140 S> */ B(Ldar), R(closure),
|
|
B(GetSuperConstructor), R(5),
|
|
B(LdaSmi), I8(1),
|
|
B(Star), R(6),
|
|
B(Ldar), R(0),
|
|
B(Mov), R(2), R(7),
|
|
/* 140 E> */ B(ConstructWithSpread), R(5), R(6), U8(2), U8(0),
|
|
B(Star), R(4),
|
|
B(Ldar), R(this),
|
|
/* 140 E> */ B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(4), R(this),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 159 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args, 1); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 8
|
|
parameter count: 1
|
|
bytecode array length: 60
|
|
bytecodes: [
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
/* 128 E> */ B(StackCheck),
|
|
B(Mov), R(2), R(3),
|
|
/* 140 S> */ B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(closure), U8(1),
|
|
B(Star), R(4),
|
|
B(CreateArrayLiteral), U8(0), U8(0), U8(37),
|
|
B(Star), R(5),
|
|
/* 152 E> */ B(CallJSRuntime), U8(%spread_iterable), R(2), U8(1),
|
|
B(Star), R(6),
|
|
B(CreateArrayLiteral), U8(1), U8(1), U8(37),
|
|
B(Star), R(7),
|
|
B(CallJSRuntime), U8(%spread_arguments), R(5), U8(3),
|
|
B(Star), R(5),
|
|
B(Mov), R(0), R(6),
|
|
/* 140 E> */ B(CallJSRuntime), U8(%reflect_construct), R(4), U8(3),
|
|
B(Star), R(4),
|
|
B(Ldar), R(this),
|
|
/* 140 E> */ B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(4), R(this),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 162 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
TUPLE2_TYPE,
|
|
TUPLE2_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|