6d96d19f1f
Reason for revert: [Sheriff] Speculative revert for http://crbug.com/620279 Original issue's description: > Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) > > The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. > > As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. > > The original CL was failing the TSAN builder, the variable in question was intended to be accessed quickly with no guarantee. > Switched to using an Atomic variable with no barrier read/write. > > BUG=v8:5089 > > patch from issue 2052523002 at patchset 100001 (http://crrev.com/2052523002#ps100001) > > Committed: https://crrev.com/fd7080cbefc21f2f890b5db00d4eadf163e2cbbf > Cr-Commit-Position: refs/heads/master@{#36973} TBR=cbruni@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2068143002 Cr-Commit-Position: refs/heads/master@{#36997}
106 lines
4.9 KiB
C++
106 lines
4.9 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/api-arguments.h"
|
|
|
|
#include "src/tracing/trace-event.h"
|
|
#include "src/vm-state-inl.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
#define FOR_EACH_CALLBACK_TABLE_MAPPING_1_NAME(F) \
|
|
F(AccessorNameGetterCallback, "get", v8::Value, Object) \
|
|
F(GenericNamedPropertyQueryCallback, "has", v8::Integer, Object) \
|
|
F(GenericNamedPropertyDeleterCallback, "delete", v8::Boolean, Object)
|
|
|
|
#define WRITE_CALL_1_NAME(Function, type, ApiReturn, InternalReturn) \
|
|
Handle<InternalReturn> PropertyCallbackArguments::Call(Function f, \
|
|
Handle<Name> name) { \
|
|
Isolate* isolate = this->isolate(); \
|
|
RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Function); \
|
|
VMState<EXTERNAL> state(isolate); \
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
|
|
PropertyCallbackInfo<ApiReturn> info(begin()); \
|
|
LOG(isolate, \
|
|
ApiNamedPropertyAccess("interceptor-named-" type, holder(), *name)); \
|
|
f(v8::Utils::ToLocal(name), info); \
|
|
return GetReturnValue<InternalReturn>(isolate); \
|
|
}
|
|
|
|
FOR_EACH_CALLBACK_TABLE_MAPPING_1_NAME(WRITE_CALL_1_NAME)
|
|
|
|
#undef FOR_EACH_CALLBACK_TABLE_MAPPING_1_NAME
|
|
#undef WRITE_CALL_1_NAME
|
|
|
|
#define FOR_EACH_CALLBACK_TABLE_MAPPING_1_INDEX(F) \
|
|
F(IndexedPropertyGetterCallback, "get", v8::Value, Object) \
|
|
F(IndexedPropertyQueryCallback, "has", v8::Integer, Object) \
|
|
F(IndexedPropertyDeleterCallback, "delete", v8::Boolean, Object)
|
|
|
|
#define WRITE_CALL_1_INDEX(Function, type, ApiReturn, InternalReturn) \
|
|
Handle<InternalReturn> PropertyCallbackArguments::Call(Function f, \
|
|
uint32_t index) { \
|
|
Isolate* isolate = this->isolate(); \
|
|
RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Function); \
|
|
VMState<EXTERNAL> state(isolate); \
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
|
|
PropertyCallbackInfo<ApiReturn> info(begin()); \
|
|
LOG(isolate, ApiIndexedPropertyAccess("interceptor-indexed-" type, \
|
|
holder(), index)); \
|
|
f(index, info); \
|
|
return GetReturnValue<InternalReturn>(isolate); \
|
|
}
|
|
|
|
FOR_EACH_CALLBACK_TABLE_MAPPING_1_INDEX(WRITE_CALL_1_INDEX)
|
|
|
|
#undef FOR_EACH_CALLBACK_TABLE_MAPPING_1_INDEX
|
|
#undef WRITE_CALL_1_INDEX
|
|
|
|
Handle<Object> PropertyCallbackArguments::Call(
|
|
GenericNamedPropertySetterCallback f, Handle<Name> name,
|
|
Handle<Object> value) {
|
|
Isolate* isolate = this->isolate();
|
|
RuntimeCallTimerScope timer(
|
|
isolate, &RuntimeCallStats::GenericNamedPropertySetterCallback);
|
|
VMState<EXTERNAL> state(isolate);
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
|
|
PropertyCallbackInfo<v8::Value> info(begin());
|
|
LOG(isolate,
|
|
ApiNamedPropertyAccess("interceptor-named-set", holder(), *name));
|
|
f(v8::Utils::ToLocal(name), v8::Utils::ToLocal(value), info);
|
|
return GetReturnValue<Object>(isolate);
|
|
}
|
|
|
|
Handle<Object> PropertyCallbackArguments::Call(IndexedPropertySetterCallback f,
|
|
uint32_t index,
|
|
Handle<Object> value) {
|
|
Isolate* isolate = this->isolate();
|
|
RuntimeCallTimerScope timer(isolate,
|
|
&RuntimeCallStats::IndexedPropertySetterCallback);
|
|
VMState<EXTERNAL> state(isolate);
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
|
|
PropertyCallbackInfo<v8::Value> info(begin());
|
|
LOG(isolate,
|
|
ApiIndexedPropertyAccess("interceptor-indexed-set", holder(), index));
|
|
f(index, v8::Utils::ToLocal(value), info);
|
|
return GetReturnValue<Object>(isolate);
|
|
}
|
|
|
|
void PropertyCallbackArguments::Call(AccessorNameSetterCallback f,
|
|
Handle<Name> name, Handle<Object> value) {
|
|
Isolate* isolate = this->isolate();
|
|
RuntimeCallTimerScope timer(isolate,
|
|
&RuntimeCallStats::AccessorNameSetterCallback);
|
|
VMState<EXTERNAL> state(isolate);
|
|
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
|
|
PropertyCallbackInfo<void> info(begin());
|
|
LOG(isolate,
|
|
ApiNamedPropertyAccess("interceptor-named-set", holder(), *name));
|
|
f(v8::Utils::ToLocal(name), v8::Utils::ToLocal(value), info);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|