5505c66446
This is a reland of 3dfaf8264f
Original change's description:
> [debug] liveedit in native
>
> Liveedit step-by-step:
> 1. calculate diff between old source and new source,
> 2. map function literals from old source to new source,
> 3. create new script for new_source,
> 4. mark literals with changed code as changed, all others as unchanged,
> 5. check that for changed literals there are no:
> - running generators in the heap,
> - non droppable frames (e.g. running generator) above them on stack.
> 6. mark the bottom most frame with changed function as scheduled for
> restart if any.
> 7. for unchanged functions:
> - deoptimize,
> - remove from cache,
> - update source positions,
> - move to new script,
> - reset feedback information and preparsed scope information if any,
> - replace any sfi in constant pool with changed one if any.
> 8. for changed functions:
> - deoptimize
> - remove from cache,
> - reset feedback information,
> - update all links from js functions to old shared with new one.
> 9. swap scripts.
>
> TBR=ulan@chromium.org
>
> Bug: v8:7862,v8:5713
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I8f6f6156318cc82d6f36d7ebc1c9f7d5f3aa1461
> Reviewed-on: https://chromium-review.googlesource.com/1105493
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54146}
TBR=dgozman@chromium.org
Bug: v8:7862, v8:5713
Change-Id: I163ed2fd2ca3115ba0de74cb35a6fac9e40fdd94
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1124879
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54187}
133 lines
4.0 KiB
JavaScript
133 lines
4.0 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
var Debug = debug.Debug;
|
|
|
|
unique_id = 0;
|
|
|
|
var Generator = (function*(){}).constructor;
|
|
|
|
function assertIteratorResult(value, done, result) {
|
|
assertEquals({value: value, done: done}, result);
|
|
}
|
|
|
|
function MakeGenerator() {
|
|
// Prevents eval script caching.
|
|
unique_id++;
|
|
return Generator('callback',
|
|
"/* " + unique_id + "*/\n" +
|
|
"yield callback();\n" +
|
|
"return 'Cat';\n");
|
|
}
|
|
|
|
function MakeFunction() {
|
|
// Prevents eval script caching.
|
|
unique_id++;
|
|
return Function('callback',
|
|
"/* " + unique_id + "*/\n" +
|
|
"callback();\n" +
|
|
"return 'Cat';\n");
|
|
}
|
|
|
|
// First, try MakeGenerator with no perturbations.
|
|
(function(){
|
|
var generator = MakeGenerator();
|
|
function callback() {};
|
|
var iter = generator(callback);
|
|
assertIteratorResult(undefined, false, iter.next());
|
|
assertIteratorResult("Cat", true, iter.next());
|
|
})();
|
|
|
|
function ExecuteInDebugContext(f) {
|
|
var result;
|
|
var exception = null;
|
|
Debug.setListener(function(event) {
|
|
if (event == Debug.DebugEvent.Break) {
|
|
try {
|
|
result = f();
|
|
} catch (e) {
|
|
// Rethrow this exception later.
|
|
exception = e;
|
|
}
|
|
}
|
|
});
|
|
debugger;
|
|
Debug.setListener(null);
|
|
if (exception !== null) throw exception;
|
|
return result;
|
|
}
|
|
|
|
function patch(fun, from, to) {
|
|
function debug() {
|
|
var script = Debug.findScript(fun);
|
|
%LiveEditPatchScript(fun, script.source.replace(from, to));
|
|
}
|
|
ExecuteInDebugContext(debug);
|
|
}
|
|
|
|
// Try to edit a MakeGenerator while it's running, then again while it's
|
|
// stopped.
|
|
(function(){
|
|
var generator = MakeGenerator();
|
|
|
|
var gen_patch_attempted = false;
|
|
function attempt_gen_patch() {
|
|
assertFalse(gen_patch_attempted);
|
|
gen_patch_attempted = true;
|
|
assertThrowsEquals(function() {
|
|
patch(generator, '\'Cat\'', '\'Capybara\'')
|
|
}, 'LiveEdit failed: BLOCKED_BY_FUNCTION_BELOW_NON_DROPPABLE_FRAME');
|
|
};
|
|
var iter = generator(attempt_gen_patch);
|
|
assertIteratorResult(undefined, false, iter.next());
|
|
// Patch should not succeed because there is a live generator activation on
|
|
// the stack.
|
|
assertIteratorResult("Cat", true, iter.next());
|
|
assertTrue(gen_patch_attempted);
|
|
|
|
// At this point one iterator is live, but closed, so the patch will succeed.
|
|
patch(generator, "'Cat'", "'Capybara'");
|
|
iter = generator(function(){});
|
|
assertIteratorResult(undefined, false, iter.next());
|
|
// Patch successful.
|
|
assertIteratorResult("Capybara", true, iter.next());
|
|
|
|
// Patching will fail however when a live iterator is suspended.
|
|
iter = generator(function(){});
|
|
assertIteratorResult(undefined, false, iter.next());
|
|
assertThrowsEquals(function() {
|
|
patch(generator, '\'Capybara\'', '\'Tapir\'')
|
|
}, 'LiveEdit failed: BLOCKED_BY_RUNNING_GENERATOR');
|
|
assertIteratorResult("Capybara", true, iter.next());
|
|
|
|
// Try to patch functions with activations inside and outside generator
|
|
// function activations. We should succeed in the former case, but not in the
|
|
// latter.
|
|
var fun_outside = MakeFunction();
|
|
var fun_inside = MakeFunction();
|
|
var fun_patch_attempted = false;
|
|
var fun_patch_restarted = false;
|
|
function attempt_fun_patches() {
|
|
if (fun_patch_attempted) {
|
|
assertFalse(fun_patch_restarted);
|
|
fun_patch_restarted = true;
|
|
return;
|
|
}
|
|
fun_patch_attempted = true;
|
|
// Patching outside a generator activation must fail.
|
|
assertThrowsEquals(function() {
|
|
patch(fun_outside, '\'Cat\'', '\'Cobra\'')
|
|
}, 'LiveEdit failed: BLOCKED_BY_FUNCTION_BELOW_NON_DROPPABLE_FRAME');
|
|
// Patching inside a generator activation may succeed.
|
|
patch(fun_inside, "'Cat'", "'Koala'");
|
|
}
|
|
iter = generator(function() { return fun_inside(attempt_fun_patches) });
|
|
assertEquals('Cat',
|
|
fun_outside(function () {
|
|
assertIteratorResult('Koala', false, iter.next());
|
|
assertTrue(fun_patch_restarted);
|
|
}));
|
|
})();
|