Go to file
Samuel Groß 5571f9973c Fix incorrect DCHECK in ExternalPointerTable::Mark
The DCHECK is not correct: if we're marking a not-fully-initialized
object, then the handle can change from its uninitialized value (zero)
to a valid handle prior to this DCHECK, therefore causing it to fail.
This scenario is fine though, since the new entry will already be marked
as alive as it has just been allocated.
To fix that, the DCHECK now allows the two values to mismatch iff the
handle is zero.

Bug: v8:13297
Change-Id: If640d457da1d78a3d1666ffa930c27116a6080c5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3981553
Commit-Queue: Samuel Groß <saelo@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83931}
2022-10-26 12:43:09 +00:00
.github [github] Close PRs created on the V8 GitHub mirror automatically 2021-01-12 08:39:59 +00:00
bazel Revert "[bazel] Add hide symbols from release / fast builds" 2022-10-21 13:08:38 +00:00
build_overrides [build] Remove obsolete gn flag 2021-01-11 15:50:59 +00:00
custom_deps
docs
gni [mips32] Delete mips32 from v8 2022-09-13 07:54:54 +00:00
include Mark Data constructor deleted. 2022-10-25 23:02:10 +00:00
infra [infra] Improve shards on slow bots 2022-10-25 14:05:05 +00:00
samples [sandbox] Initialize sandbox during V8::Initialize 2022-07-15 09:29:32 +00:00
src Fix incorrect DCHECK in ExternalPointerTable::Mark 2022-10-26 12:43:09 +00:00
test [maglev] Stable maps can become stale after a side effect 2022-10-26 09:39:59 +00:00
testing [test] Migrate cctest/test-api-accessors.cc to unittests/ 2022-05-17 08:27:55 +00:00
third_party Roll inspector_protocol to update copyright headers 2022-10-09 17:40:23 +00:00
tools [wasm] Detemplatize immediates 2022-10-24 17:27:49 +00:00
.bazelrc [bazel] Use v8_enable_handle_zapping only in debug builds. 2022-01-11 11:32:39 +00:00
.clang-format
.clang-tidy
.editorconfig
.flake8 remove swarming_client 2021-08-24 10:39:33 +00:00
.git-blame-ignore-revs
.gitattributes
.gitignore [cleanup] Add .idea to .gitignore 2022-08-22 19:54:38 +00:00
.gn [fuchsia] Add API target level default value 2022-08-29 14:46:45 +00:00
.mailmap Add .mailmap entries for jgruber 2022-08-04 08:53:02 +00:00
.style.yapf [tools] Add basic pointer compression to grokdump 2022-02-04 14:35:26 +00:00
.vpython3 Reland "[resultdb] Add ResultDB indicator" 2022-10-14 11:05:59 +00:00
.ycm_extra_conf.py [ycm] Fix python script 2021-07-29 09:48:32 +00:00
AUTHORS [profiler] add Serialize to v8::CpuProfile 2022-10-25 10:49:04 +00:00
BUILD.bazel [profiler] add Serialize to v8::CpuProfile 2022-10-25 10:49:04 +00:00
BUILD.gn [profiler] add Serialize to v8::CpuProfile 2022-10-25 10:49:04 +00:00
CODE_OF_CONDUCT.md
codereview.settings
COMMON_OWNERS [owners] Add mliedtke to COMMON_OWNERS 2022-09-16 14:12:27 +00:00
DEPS Update V8 DEPS (trusted) 2022-10-26 04:02:42 +00:00
DIR_METADATA
ENG_REVIEW_OWNERS Add mlippautz@ to ENG_REVIEW_OWNERS. 2022-10-06 18:48:33 +00:00
INFRA_OWNERS [infra] Add alexschulze@ as infra owner 2022-07-18 09:08:54 +00:00
INTL_OWNERS
LICENSE [mips32] Delete mips32 from v8 2022-09-13 07:54:54 +00:00
LICENSE.fdlibm
LICENSE.strongtalk
LICENSE.v8
LOONG_OWNERS [LOONG64] Add LoongArch64 backend 2021-08-16 13:05:19 +00:00
MIPS_OWNERS [mips] Add LiuYu to MIPS_OWNERS 2021-09-08 01:38:52 +00:00
OWNERS Reland "[riscv32] Add RISCV32 backend" 2022-08-04 12:47:44 +00:00
PPC_OWNERS
PRESUBMIT.py [wasm] Limit module size in streaming decoder 2022-07-08 09:43:41 +00:00
README.md
RISCV_OWNERS Add Lu Yahan to RISC-V owners list 2021-09-13 16:35:00 +00:00
S390_OWNERS
WATCHLISTS Reland "[WATCHLISTS] Add riscv watch" 2022-08-19 07:33:57 +00:00
WORKSPACE [bazel] Remove zlib dependency 2022-08-17 15:30:25 +00:00

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://v8.dev/docs

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned at v8.dev/docs/contribute.