07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
65 lines
1.1 KiB
JavaScript
65 lines
1.1 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
Debug = debug.Debug
|
|
|
|
var exception = null;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Exception) return;
|
|
try {
|
|
var line = exec_state.frame(0).sourceLineText();
|
|
var match = /Exception/.exec(line);
|
|
assertNotNull(match);
|
|
} catch (e) {
|
|
exception = e;
|
|
}
|
|
}
|
|
|
|
// Caught throw, events on any exception.
|
|
Debug.setListener(listener);
|
|
Debug.setBreakOnException();
|
|
|
|
var thenable = {
|
|
get then() {
|
|
throw new Error(); // Exception
|
|
}
|
|
};
|
|
|
|
class MyPromise extends Promise {
|
|
get then() {
|
|
throw new Error();
|
|
}
|
|
}
|
|
|
|
MyPromise.resolve(thenable);
|
|
|
|
var p = Promise.resolve(thenable);
|
|
|
|
async function foo() {
|
|
return thenable;
|
|
}
|
|
|
|
foo();
|
|
|
|
async function foo() {
|
|
await thenable;
|
|
}
|
|
|
|
foo();
|
|
|
|
async function foo() {
|
|
try {
|
|
await thenable;
|
|
} catch (e) {}
|
|
}
|
|
|
|
foo();
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
|
|
Debug.setListener(null);
|
|
Debug.clearBreakOnException();
|
|
assertNull(exception);
|