v8/test
Leszek Swirski df6f5f6b69 [parser] Check assignment LHS for paren errors
It is not legal for destructuring patterns and identifiers in declarations
to be in parentheses. This includes nested patterns/identifiers inside
another pattern.

We were checking sub-patterns for parentheses when parsing possible
sub-patterns, but this check missed sub-patterns with a default
initialiser (e.g. [({x:y})=1] = {}), as the AssignmentExpression hid
the pattern.

So, we now additionally record declaration/pattern errors of an assignment
LHS when parsing the assignment cover grammar.

Bug: v8:8630
Change-Id: Ia5a97003671fc1da7f68d7fb15943928ce9496e3
Reviewed-on: https://chromium-review.googlesource.com/c/1404452
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58743}
2019-01-11 12:56:38 +00:00
..
benchmarks [Test] CSuite benchmark runner 2018-12-21 13:15:57 +00:00
cctest [regexp] Fix oob read in JSRegExp::HasCompiledCode 2019-01-11 12:46:45 +00:00
common [objects.h splitting] Move HeapNumber to heap-number.h 2018-12-17 17:58:09 +00:00
debugger [nojit] Don't allocate executable memory in jitless mode 2019-01-10 10:55:48 +00:00
fuzzer [wasm][fuzzer] Automatically compute year for test generation 2019-01-11 09:55:25 +00:00
inspector [wasm] Fix maximum value length in scope info 2019-01-11 09:37:59 +00:00
intl [Intl] Fix getting undefined property crash 2019-01-10 00:59:53 +00:00
js-perf-test Revert "[test] add perf tests for String.p.startsWith" 2019-01-10 12:34:51 +00:00
memory [snapshot] Remove the builtins snapshot 2018-10-31 10:18:28 +00:00
message [destructuring] Get non-coercible message contents in runtime 2019-01-10 15:23:05 +00:00
mjsunit [parser] Check assignment LHS for paren errors 2019-01-11 12:56:38 +00:00
mkgrokdump [nojit] Don't allocate executable memory in jitless mode 2019-01-10 10:55:48 +00:00
mozilla Revert "[runtime] Reduce spread/apply call max arguments" 2018-11-30 09:54:47 +00:00
preparser [test] Share resource-fetching logic with all d8 test cases 2018-08-29 17:51:43 +00:00
test262 [Intl] Not harden the array return by supportedLocalesOf 2019-01-10 21:39:47 +00:00
torque [nojit] Change builtin pointers to use Smis underneath 2018-12-17 15:35:59 +00:00
unittests Remove fast_sqrt generated code 2019-01-11 12:45:38 +00:00
wasm-js [nojit] Don't allocate executable memory in jitless mode 2019-01-10 10:55:48 +00:00
wasm-spec-tests [nojit] Don't allocate executable memory in jitless mode 2019-01-10 10:55:48 +00:00
webkit Fixed typos 2019-01-08 07:31:02 +00:00
BUILD.gn Reland "[wasm] Add a new wasm-js testsuite to run js-api tests" 2018-10-18 20:18:55 +00:00