dc49fe0647
Previously we do not tier down from baseline to interpreter, which breaks per-bytecode side effect checks (to check whether e.g. we are mutating a temporary object, which is not considered a side effect). R=leszeks@chromium.org Bug: chromium:1233401 Change-Id: Ie08b5352aa4c124421b4c9abce18326938bbc822 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056981 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75963}
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --sparkplug
|
|
// Flags: --no-baseline-batch-compilation
|
|
|
|
const baseScript = `
|
|
var paths = [
|
|
[ 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 1],
|
|
[ 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 1],
|
|
[ 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 0]
|
|
];
|
|
|
|
function sink(arr) {
|
|
let i = arr.length - 2;
|
|
for (let j = 0; j < arr[i].length; j++) {
|
|
const node = arr[i][j];
|
|
const right = arr[i + 1][j + 1];
|
|
arr[i][j] = Math.max(node + right);
|
|
}
|
|
arr.pop();
|
|
return arr[i][arr[i].length-1];
|
|
}
|
|
`;
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start(
|
|
'Evaluate with and without side effect checks');
|
|
|
|
(async function test() {
|
|
await Protocol.Runtime.evaluate({
|
|
expression: baseScript,
|
|
replMode: true,
|
|
});
|
|
InspectorTest.logMessage(await Protocol.Runtime.evaluate({
|
|
expression: 'sink(paths);',
|
|
replMode: true,
|
|
throwOnSideEffect: true,
|
|
}));
|
|
InspectorTest.logMessage(await Protocol.Runtime.evaluate({
|
|
expression: 'sink(paths)',
|
|
replMode: true,
|
|
}));
|
|
InspectorTest.logMessage(await Protocol.Runtime.evaluate({
|
|
expression: 'sink(paths);',
|
|
replMode: true,
|
|
throwOnSideEffect: true,
|
|
}));
|
|
InspectorTest.logMessage(await Protocol.Runtime.evaluate({
|
|
expression: 'sink(paths);',
|
|
replMode: true,
|
|
}));
|
|
InspectorTest.completeTest();
|
|
})();
|