251feceb65
The icache and jump-table-assembler tests need memory that is both writable and executable. On Mac, to do this we need to pass MAP_JIT to mmap which is wired with the VirtualMemory::JitPermission flag. Change-Id: If8236fa8983a4a59ef39fe777f26a02103dc6f75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2637227 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#72217}
88 lines
3.0 KiB
C++
88 lines
3.0 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TEST_COMMON_ASSEMBLER_TESTER_H_
|
|
#define V8_TEST_COMMON_ASSEMBLER_TESTER_H_
|
|
|
|
#include <memory>
|
|
|
|
#include "src/codegen/assembler.h"
|
|
#include "src/codegen/code-desc.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
class TestingAssemblerBuffer : public AssemblerBuffer {
|
|
public:
|
|
TestingAssemblerBuffer(
|
|
size_t requested, void* address,
|
|
VirtualMemory::JitPermission jit_permission = VirtualMemory::kNoJit) {
|
|
size_t page_size = v8::internal::AllocatePageSize();
|
|
size_t alloc_size = RoundUp(requested, page_size);
|
|
CHECK_GE(kMaxInt, alloc_size);
|
|
reservation_ = VirtualMemory(GetPlatformPageAllocator(), alloc_size,
|
|
address, page_size, jit_permission);
|
|
CHECK(reservation_.IsReserved());
|
|
MakeWritable();
|
|
}
|
|
|
|
~TestingAssemblerBuffer() { reservation_.Free(); }
|
|
|
|
byte* start() const override {
|
|
return reinterpret_cast<byte*>(reservation_.address());
|
|
}
|
|
|
|
int size() const override { return static_cast<int>(reservation_.size()); }
|
|
|
|
std::unique_ptr<AssemblerBuffer> Grow(int new_size) override {
|
|
FATAL("Cannot grow TestingAssemblerBuffer");
|
|
}
|
|
|
|
std::unique_ptr<AssemblerBuffer> CreateView() const {
|
|
return ExternalAssemblerBuffer(start(), size());
|
|
}
|
|
|
|
void MakeExecutable() {
|
|
// Flush the instruction cache as part of making the buffer executable.
|
|
// Note: we do this before setting permissions to ReadExecute because on
|
|
// some older ARM kernels there is a bug which causes an access error on
|
|
// cache flush instructions to trigger access error on non-writable memory.
|
|
// See https://bugs.chromium.org/p/v8/issues/detail?id=8157
|
|
FlushInstructionCache(start(), size());
|
|
|
|
bool result = SetPermissions(GetPlatformPageAllocator(), start(), size(),
|
|
v8::PageAllocator::kReadExecute);
|
|
CHECK(result);
|
|
}
|
|
|
|
void MakeWritable() {
|
|
bool result = SetPermissions(GetPlatformPageAllocator(), start(), size(),
|
|
v8::PageAllocator::kReadWrite);
|
|
CHECK(result);
|
|
}
|
|
|
|
// TODO(wasm): Only needed for the "test-jump-table-assembler.cc" tests.
|
|
void MakeWritableAndExecutable() {
|
|
bool result = SetPermissions(GetPlatformPageAllocator(), start(), size(),
|
|
v8::PageAllocator::kReadWriteExecute);
|
|
CHECK(result);
|
|
}
|
|
|
|
private:
|
|
VirtualMemory reservation_;
|
|
};
|
|
|
|
static inline std::unique_ptr<TestingAssemblerBuffer> AllocateAssemblerBuffer(
|
|
size_t requested = v8::internal::AssemblerBase::kDefaultBufferSize,
|
|
void* address = nullptr,
|
|
VirtualMemory::JitPermission jit_permission = VirtualMemory::kNoJit) {
|
|
return std::make_unique<TestingAssemblerBuffer>(requested, address,
|
|
jit_permission);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TEST_COMMON_ASSEMBLER_TESTER_H_
|