fb6a094db5
This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position. Benefits (see test for details): - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2), - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}. TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:5909 Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294 Reviewed-on: https://chromium-review.googlesource.com/518116 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45598}
396 lines
9.1 KiB
Plaintext
396 lines
9.1 KiB
Plaintext
Tests breakable locations in for-of loops.
|
|
|
|
Running test: testBreakLocations
|
|
|
|
Running test: testStepInto
|
|
|
|
function testFunction() {
|
|
var obj = |_|{a : 1};
|
|
var arr = |_|[1];
|
|
var all = |_|[];
|
|
for (var |_|k in |_|arr) { |_|all.|C|push(k); }
|
|
for (var |_|k of |_|arr) { |_|all.|C|push(k); }
|
|
for (var |_|k in |_|obj) { |_|all.|C|push(k); }
|
|
for (let |_|k in |_|arr) { |_|all.|C|push(k); }
|
|
for (let |_|k of |_|arr) { |_|all.|C|push(k); }
|
|
for (let |_|k in |_|obj) { |_|all.|C|push(k); }
|
|
|
|
var iterable = |_|{
|
|
[Symbol.iterator]() {
|
|
|_|return {
|
|
i: 0,
|
|
next() {
|
|
|_|if (this.i < 1) {
|
|
|_|return { value: this.i++, done: false };
|
|
}
|
|
|_|return { value: undefined, done: true };
|
|
|R|}
|
|
};
|
|
|R|}
|
|
};
|
|
for (var |_|k of |_|iterable) { |_|all.|C|push(k); }
|
|
|_|iterable.i = 0;
|
|
for (let |_|k of |_|iterable) { |_|all.|C|push(k); }
|
|
|R|}
|
|
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
|
|
testFunction (test.js:2:12)
|
|
(anonymous) (expr.js:0:0)
|
|
function testFunction() {
|
|
var obj = #{a : 1};
|
|
var arr = [1];
|
|
|
|
testFunction (test.js:3:12)
|
|
(anonymous) (expr.js:0:0)
|
|
var obj = {a : 1};
|
|
var arr = #[1];
|
|
var all = [];
|
|
|
|
testFunction (test.js:4:12)
|
|
(anonymous) (expr.js:0:0)
|
|
var arr = [1];
|
|
var all = #[];
|
|
for (var k in arr) { all.push(k); }
|
|
|
|
testFunction (test.js:5:16)
|
|
(anonymous) (expr.js:0:0)
|
|
var all = [];
|
|
for (var k in #arr) { all.push(k); }
|
|
for (var k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:5:11)
|
|
(anonymous) (expr.js:0:0)
|
|
var all = [];
|
|
for (var #k in arr) { all.push(k); }
|
|
for (var k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:5:23)
|
|
(anonymous) (expr.js:0:0)
|
|
var all = [];
|
|
for (var k in arr) { #all.push(k); }
|
|
for (var k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:5:11)
|
|
(anonymous) (expr.js:0:0)
|
|
var all = [];
|
|
for (var #k in arr) { all.push(k); }
|
|
for (var k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:6:16)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in arr) { all.push(k); }
|
|
for (var k of #arr) { all.push(k); }
|
|
for (var k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:6:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in arr) { all.push(k); }
|
|
for (var #k of arr) { all.push(k); }
|
|
for (var k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:6:23)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in arr) { all.push(k); }
|
|
for (var k of arr) { #all.push(k); }
|
|
for (var k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:6:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in arr) { all.push(k); }
|
|
for (var #k of arr) { all.push(k); }
|
|
for (var k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:7:16)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k of arr) { all.push(k); }
|
|
for (var k in #obj) { all.push(k); }
|
|
for (let k in arr) { all.push(k); }
|
|
|
|
testFunction (test.js:7:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k of arr) { all.push(k); }
|
|
for (var #k in obj) { all.push(k); }
|
|
for (let k in arr) { all.push(k); }
|
|
|
|
testFunction (test.js:7:23)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k of arr) { all.push(k); }
|
|
for (var k in obj) { #all.push(k); }
|
|
for (let k in arr) { all.push(k); }
|
|
|
|
testFunction (test.js:7:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k of arr) { all.push(k); }
|
|
for (var #k in obj) { all.push(k); }
|
|
for (let k in arr) { all.push(k); }
|
|
|
|
testFunction (test.js:8:16)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in obj) { all.push(k); }
|
|
for (let k in #arr) { all.push(k); }
|
|
for (let k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:8:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in obj) { all.push(k); }
|
|
for (let #k in arr) { all.push(k); }
|
|
for (let k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:8:23)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in obj) { all.push(k); }
|
|
for (let k in arr) { #all.push(k); }
|
|
for (let k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:8:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k in obj) { all.push(k); }
|
|
for (let #k in arr) { all.push(k); }
|
|
for (let k of arr) { all.push(k); }
|
|
|
|
testFunction (test.js:9:16)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k in arr) { all.push(k); }
|
|
for (let k of #arr) { all.push(k); }
|
|
for (let k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:9:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k in arr) { all.push(k); }
|
|
for (let #k of arr) { all.push(k); }
|
|
for (let k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:9:23)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k in arr) { all.push(k); }
|
|
for (let k of arr) { #all.push(k); }
|
|
for (let k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:9:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k in arr) { all.push(k); }
|
|
for (let #k of arr) { all.push(k); }
|
|
for (let k in obj) { all.push(k); }
|
|
|
|
testFunction (test.js:10:16)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k of arr) { all.push(k); }
|
|
for (let k in #obj) { all.push(k); }
|
|
|
|
|
|
testFunction (test.js:10:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k of arr) { all.push(k); }
|
|
for (let #k in obj) { all.push(k); }
|
|
|
|
|
|
testFunction (test.js:10:23)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k of arr) { all.push(k); }
|
|
for (let k in obj) { #all.push(k); }
|
|
|
|
|
|
testFunction (test.js:10:11)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k of arr) { all.push(k); }
|
|
for (let #k in obj) { all.push(k); }
|
|
|
|
|
|
testFunction (test.js:12:17)
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
var iterable = #{
|
|
[Symbol.iterator]() {
|
|
|
|
testFunction (test.js:25:16)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
for (var k of #iterable) { all.push(k); }
|
|
iterable.i = 0;
|
|
|
|
[Symbol.iterator] (test.js:14:6)
|
|
testFunction (test.js:25:16)
|
|
(anonymous) (expr.js:0:0)
|
|
[Symbol.iterator]() {
|
|
#return {
|
|
i: 0,
|
|
|
|
[Symbol.iterator] (test.js:23:4)
|
|
testFunction (test.js:25:16)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
#}
|
|
};
|
|
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
for (var #k of iterable) { all.push(k); }
|
|
iterable.i = 0;
|
|
|
|
next (test.js:17:10)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
next() {
|
|
#if (this.i < 1) {
|
|
return { value: this.i++, done: false };
|
|
|
|
next (test.js:18:12)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
if (this.i < 1) {
|
|
#return { value: this.i++, done: false };
|
|
}
|
|
|
|
next (test.js:21:8)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
return { value: undefined, done: true };
|
|
#}
|
|
};
|
|
|
|
testFunction (test.js:25:28)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
for (var k of iterable) { #all.push(k); }
|
|
iterable.i = 0;
|
|
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
for (var #k of iterable) { all.push(k); }
|
|
iterable.i = 0;
|
|
|
|
next (test.js:17:10)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
next() {
|
|
#if (this.i < 1) {
|
|
return { value: this.i++, done: false };
|
|
|
|
next (test.js:20:10)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
}
|
|
#return { value: undefined, done: true };
|
|
}
|
|
|
|
next (test.js:21:8)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
return { value: undefined, done: true };
|
|
#}
|
|
};
|
|
|
|
testFunction (test.js:26:2)
|
|
(anonymous) (expr.js:0:0)
|
|
for (var k of iterable) { all.push(k); }
|
|
#iterable.i = 0;
|
|
for (let k of iterable) { all.push(k); }
|
|
|
|
testFunction (test.js:27:16)
|
|
(anonymous) (expr.js:0:0)
|
|
iterable.i = 0;
|
|
for (let k of #iterable) { all.push(k); }
|
|
}
|
|
|
|
[Symbol.iterator] (test.js:14:6)
|
|
testFunction (test.js:27:16)
|
|
(anonymous) (expr.js:0:0)
|
|
[Symbol.iterator]() {
|
|
#return {
|
|
i: 0,
|
|
|
|
[Symbol.iterator] (test.js:23:4)
|
|
testFunction (test.js:27:16)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
#}
|
|
};
|
|
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
iterable.i = 0;
|
|
for (let #k of iterable) { all.push(k); }
|
|
}
|
|
|
|
next (test.js:17:10)
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
next() {
|
|
#if (this.i < 1) {
|
|
return { value: this.i++, done: false };
|
|
|
|
next (test.js:18:12)
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
if (this.i < 1) {
|
|
#return { value: this.i++, done: false };
|
|
}
|
|
|
|
next (test.js:21:8)
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
return { value: undefined, done: true };
|
|
#}
|
|
};
|
|
|
|
testFunction (test.js:27:28)
|
|
(anonymous) (expr.js:0:0)
|
|
iterable.i = 0;
|
|
for (let k of iterable) { #all.push(k); }
|
|
}
|
|
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
iterable.i = 0;
|
|
for (let #k of iterable) { all.push(k); }
|
|
}
|
|
|
|
next (test.js:17:10)
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
next() {
|
|
#if (this.i < 1) {
|
|
return { value: this.i++, done: false };
|
|
|
|
next (test.js:20:10)
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
}
|
|
#return { value: undefined, done: true };
|
|
}
|
|
|
|
next (test.js:21:8)
|
|
testFunction (test.js:27:11)
|
|
(anonymous) (expr.js:0:0)
|
|
return { value: undefined, done: true };
|
|
#}
|
|
};
|
|
|
|
testFunction (test.js:28:0)
|
|
(anonymous) (expr.js:0:0)
|
|
for (let k of iterable) { all.push(k); }
|
|
#}
|
|
|
|
(anonymous) (expr.js:0:34)
|
|
|
|
|
|
|
|
Running test: testStepIntoAfterBreakpoint
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
};
|
|
for (var #k of iterable) { all.push(k); }
|
|
iterable.i = 0;
|
|
|
|
next (test.js:17:10)
|
|
testFunction (test.js:25:11)
|
|
(anonymous) (expr.js:0:0)
|
|
next() {
|
|
#if (this.i < 1) {
|
|
return { value: this.i++, done: false };
|
|
|