a702785156
Reason for revert: Bug: failing to use write barrier when writing code entry into closure. Original issue's description: > Reland of Type Feedback Vector lives in the closure > > (Fixed a bug found by nosnap builds.) > > We get less "pollution" of type feedback if we have one vector per native > context, rather than one for the whole system. This CL moves the vector > appropriately. > > We rely more heavily on the Optimized Code Map in the SharedFunctionInfo. The > vector actually lives in the first slot of the literals array (indeed there is > great commonality between those arrays, they can be thought of as the same > thing). So we make greater effort to ensure there is a valid literals array > after compilation. > > This meant, for performance reasons, that we needed to extend > FastNewClosureStub to support creating closures with literals. And ultimately, > it drove us to move the optimized code map lookup out of FastNewClosureStub > and into the compile lazy builtin. > > The heap change is trivial so I TBR Hannes for it... > > TBR=hpayer@chromium.org > BUG= > > Committed: https://crrev.com/d984b3b0ce91e55800f5323b4bb32a06f8a5aab1 > Cr-Commit-Position: refs/heads/master@{#33548} TBR=bmeurer@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1643533003 Cr-Commit-Position: refs/heads/master@{#33556}
250 lines
7.8 KiB
C++
250 lines
7.8 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_CCTEST_COMPILER_FUNCTION_TESTER_H_
|
|
#define V8_CCTEST_COMPILER_FUNCTION_TESTER_H_
|
|
|
|
#include "src/ast/ast-numbering.h"
|
|
#include "src/ast/scopes.h"
|
|
#include "src/compiler.h"
|
|
#include "src/compiler/linkage.h"
|
|
#include "src/compiler/pipeline.h"
|
|
#include "src/execution.h"
|
|
#include "src/full-codegen/full-codegen.h"
|
|
#include "src/handles.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/parsing/parser.h"
|
|
#include "src/parsing/rewriter.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
class FunctionTester : public InitializedHandleScope {
|
|
public:
|
|
explicit FunctionTester(const char* source, uint32_t flags = 0)
|
|
: isolate(main_isolate()),
|
|
function((FLAG_allow_natives_syntax = true, NewFunction(source))),
|
|
flags_(flags) {
|
|
Compile(function);
|
|
const uint32_t supported_flags =
|
|
CompilationInfo::kFunctionContextSpecializing |
|
|
CompilationInfo::kInliningEnabled | CompilationInfo::kTypingEnabled;
|
|
CHECK_EQ(0u, flags_ & ~supported_flags);
|
|
}
|
|
|
|
FunctionTester(Graph* graph, int param_count)
|
|
: isolate(main_isolate()),
|
|
function(NewFunction(BuildFunction(param_count).c_str())),
|
|
flags_(0) {
|
|
CompileGraph(graph);
|
|
}
|
|
|
|
FunctionTester(const CallInterfaceDescriptor& descriptor, Handle<Code> code)
|
|
: isolate(main_isolate()),
|
|
function(
|
|
(FLAG_allow_natives_syntax = true,
|
|
NewFunction(BuildFunctionFromDescriptor(descriptor).c_str()))),
|
|
flags_(0) {
|
|
Compile(function);
|
|
function->ReplaceCode(*code);
|
|
}
|
|
|
|
Isolate* isolate;
|
|
Handle<JSFunction> function;
|
|
|
|
MaybeHandle<Object> Call() {
|
|
return Execution::Call(isolate, function, undefined(), 0, nullptr);
|
|
}
|
|
|
|
MaybeHandle<Object> Call(Handle<Object> a, Handle<Object> b) {
|
|
Handle<Object> args[] = {a, b};
|
|
return Execution::Call(isolate, function, undefined(), 2, args);
|
|
}
|
|
|
|
MaybeHandle<Object> Call(Handle<Object> a, Handle<Object> b, Handle<Object> c,
|
|
Handle<Object> d) {
|
|
Handle<Object> args[] = {a, b, c, d};
|
|
return Execution::Call(isolate, function, undefined(), 4, args);
|
|
}
|
|
|
|
void CheckThrows(Handle<Object> a, Handle<Object> b) {
|
|
TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));
|
|
MaybeHandle<Object> no_result = Call(a, b);
|
|
CHECK(isolate->has_pending_exception());
|
|
CHECK(try_catch.HasCaught());
|
|
CHECK(no_result.is_null());
|
|
isolate->OptionalRescheduleException(true);
|
|
}
|
|
|
|
v8::Local<v8::Message> CheckThrowsReturnMessage(Handle<Object> a,
|
|
Handle<Object> b) {
|
|
TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));
|
|
MaybeHandle<Object> no_result = Call(a, b);
|
|
CHECK(isolate->has_pending_exception());
|
|
CHECK(try_catch.HasCaught());
|
|
CHECK(no_result.is_null());
|
|
isolate->OptionalRescheduleException(true);
|
|
CHECK(!try_catch.Message().IsEmpty());
|
|
return try_catch.Message();
|
|
}
|
|
|
|
void CheckCall(Handle<Object> expected, Handle<Object> a, Handle<Object> b) {
|
|
Handle<Object> result = Call(a, b).ToHandleChecked();
|
|
CHECK(expected->SameValue(*result));
|
|
}
|
|
|
|
void CheckCall(Handle<Object> expected, Handle<Object> a) {
|
|
CheckCall(expected, a, undefined());
|
|
}
|
|
|
|
void CheckCall(Handle<Object> expected) {
|
|
CheckCall(expected, undefined(), undefined());
|
|
}
|
|
|
|
void CheckCall(double expected, double a, double b) {
|
|
CheckCall(Val(expected), Val(a), Val(b));
|
|
}
|
|
|
|
void CheckTrue(Handle<Object> a, Handle<Object> b) {
|
|
CheckCall(true_value(), a, b);
|
|
}
|
|
|
|
void CheckTrue(Handle<Object> a) { CheckCall(true_value(), a, undefined()); }
|
|
|
|
void CheckTrue(double a, double b) {
|
|
CheckCall(true_value(), Val(a), Val(b));
|
|
}
|
|
|
|
void CheckFalse(Handle<Object> a, Handle<Object> b) {
|
|
CheckCall(false_value(), a, b);
|
|
}
|
|
|
|
void CheckFalse(Handle<Object> a) {
|
|
CheckCall(false_value(), a, undefined());
|
|
}
|
|
|
|
void CheckFalse(double a, double b) {
|
|
CheckCall(false_value(), Val(a), Val(b));
|
|
}
|
|
|
|
Handle<JSFunction> NewFunction(const char* source) {
|
|
return Handle<JSFunction>::cast(v8::Utils::OpenHandle(
|
|
*v8::Local<v8::Function>::Cast(CompileRun(source))));
|
|
}
|
|
|
|
Handle<JSObject> NewObject(const char* source) {
|
|
return Handle<JSObject>::cast(v8::Utils::OpenHandle(
|
|
*v8::Local<v8::Object>::Cast(CompileRun(source))));
|
|
}
|
|
|
|
Handle<String> Val(const char* string) {
|
|
return isolate->factory()->InternalizeUtf8String(string);
|
|
}
|
|
|
|
Handle<Object> Val(double value) {
|
|
return isolate->factory()->NewNumber(value);
|
|
}
|
|
|
|
Handle<Object> infinity() { return isolate->factory()->infinity_value(); }
|
|
|
|
Handle<Object> minus_infinity() { return Val(-V8_INFINITY); }
|
|
|
|
Handle<Object> nan() { return isolate->factory()->nan_value(); }
|
|
|
|
Handle<Object> undefined() { return isolate->factory()->undefined_value(); }
|
|
|
|
Handle<Object> null() { return isolate->factory()->null_value(); }
|
|
|
|
Handle<Object> true_value() { return isolate->factory()->true_value(); }
|
|
|
|
Handle<Object> false_value() { return isolate->factory()->false_value(); }
|
|
|
|
Handle<JSFunction> Compile(Handle<JSFunction> function) {
|
|
// TODO(titzer): make this method private.
|
|
Zone zone;
|
|
ParseInfo parse_info(&zone, function);
|
|
CompilationInfo info(&parse_info);
|
|
info.MarkAsDeoptimizationEnabled();
|
|
|
|
CHECK(Parser::ParseStatic(info.parse_info()));
|
|
info.SetOptimizing(BailoutId::None(), Handle<Code>(function->code()));
|
|
if (flags_ & CompilationInfo::kFunctionContextSpecializing) {
|
|
info.MarkAsFunctionContextSpecializing();
|
|
}
|
|
if (flags_ & CompilationInfo::kInliningEnabled) {
|
|
info.MarkAsInliningEnabled();
|
|
}
|
|
if (flags_ & CompilationInfo::kTypingEnabled) {
|
|
info.MarkAsTypingEnabled();
|
|
}
|
|
CHECK(Compiler::Analyze(info.parse_info()));
|
|
CHECK(Compiler::EnsureDeoptimizationSupport(&info));
|
|
|
|
Pipeline pipeline(&info);
|
|
Handle<Code> code = pipeline.GenerateCode();
|
|
CHECK(!code.is_null());
|
|
info.dependencies()->Commit(code);
|
|
info.context()->native_context()->AddOptimizedCode(*code);
|
|
function->ReplaceCode(*code);
|
|
return function;
|
|
}
|
|
|
|
static Handle<JSFunction> ForMachineGraph(Graph* graph, int param_count) {
|
|
JSFunction* p = NULL;
|
|
{ // because of the implicit handle scope of FunctionTester.
|
|
FunctionTester f(graph, param_count);
|
|
p = *f.function;
|
|
}
|
|
return Handle<JSFunction>(p); // allocated in outer handle scope.
|
|
}
|
|
|
|
private:
|
|
uint32_t flags_;
|
|
|
|
std::string BuildFunction(int param_count) {
|
|
std::string function_string = "(function(";
|
|
if (param_count > 0) {
|
|
char next = 'a';
|
|
function_string += next;
|
|
while (param_count-- > 0) {
|
|
function_string += ',';
|
|
function_string += ++next;
|
|
}
|
|
}
|
|
function_string += "){})";
|
|
return function_string;
|
|
}
|
|
|
|
std::string BuildFunctionFromDescriptor(
|
|
const CallInterfaceDescriptor& descriptor) {
|
|
return BuildFunction(descriptor.GetParameterCount());
|
|
}
|
|
|
|
// Compile the given machine graph instead of the source of the function
|
|
// and replace the JSFunction's code with the result.
|
|
Handle<JSFunction> CompileGraph(Graph* graph) {
|
|
Zone zone;
|
|
ParseInfo parse_info(&zone, function);
|
|
CompilationInfo info(&parse_info);
|
|
|
|
CHECK(Parser::ParseStatic(info.parse_info()));
|
|
info.SetOptimizing(BailoutId::None(),
|
|
Handle<Code>(function->shared()->code()));
|
|
CHECK(Compiler::Analyze(info.parse_info()));
|
|
CHECK(Compiler::EnsureDeoptimizationSupport(&info));
|
|
|
|
Handle<Code> code = Pipeline::GenerateCodeForTesting(&info, graph);
|
|
CHECK(!code.is_null());
|
|
function->ReplaceCode(*code);
|
|
return function;
|
|
}
|
|
};
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_CCTEST_COMPILER_FUNCTION_TESTER_H_
|