822be9b238
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
91 lines
3.1 KiB
C++
91 lines
3.1 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/factory.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
TEST(CodeLayoutWithoutUnwindingInfo) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
|
|
// "Hello, World!" in ASCII.
|
|
byte buffer_array[13] = {0x48, 0x65, 0x6C, 0x6C, 0x6F, 0x2C, 0x20,
|
|
0x57, 0x6F, 0x72, 0x6C, 0x64, 0x21};
|
|
|
|
byte* buffer = &buffer_array[0];
|
|
int buffer_size = sizeof(buffer_array);
|
|
|
|
CodeDesc code_desc;
|
|
code_desc.buffer = buffer;
|
|
code_desc.buffer_size = buffer_size;
|
|
code_desc.constant_pool_size = 0;
|
|
code_desc.instr_size = buffer_size;
|
|
code_desc.reloc_size = 0;
|
|
code_desc.origin = nullptr;
|
|
code_desc.unwinding_info = nullptr;
|
|
code_desc.unwinding_info_size = 0;
|
|
|
|
Handle<Code> code = CcTest::i_isolate()->factory()->NewCode(
|
|
code_desc, Code::STUB, Handle<Object>::null());
|
|
|
|
CHECK(!code->has_unwinding_info());
|
|
CHECK_EQ(code->instruction_size(), buffer_size);
|
|
CHECK_EQ(0, memcmp(code->instruction_start(), buffer, buffer_size));
|
|
CHECK_EQ(code->instruction_end() - reinterpret_cast<byte*>(*code),
|
|
Code::kHeaderSize + buffer_size - kHeapObjectTag);
|
|
}
|
|
|
|
TEST(CodeLayoutWithUnwindingInfo) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
|
|
// "Hello, World!" in ASCII.
|
|
byte buffer_array[13] = {0x48, 0x65, 0x6C, 0x6C, 0x6F, 0x2C, 0x20,
|
|
0x57, 0x6F, 0x72, 0x6C, 0x64, 0x21};
|
|
|
|
// "JavaScript" in ASCII.
|
|
byte unwinding_info_array[10] = {0x4A, 0x61, 0x76, 0x61, 0x53,
|
|
0x63, 0x72, 0x69, 0x70, 0x74};
|
|
|
|
byte* buffer = &buffer_array[0];
|
|
int buffer_size = sizeof(buffer_array);
|
|
byte* unwinding_info = &unwinding_info_array[0];
|
|
int unwinding_info_size = sizeof(unwinding_info_array);
|
|
|
|
CodeDesc code_desc;
|
|
code_desc.buffer = buffer;
|
|
code_desc.buffer_size = buffer_size;
|
|
code_desc.constant_pool_size = 0;
|
|
code_desc.instr_size = buffer_size;
|
|
code_desc.reloc_size = 0;
|
|
code_desc.origin = nullptr;
|
|
code_desc.unwinding_info = unwinding_info;
|
|
code_desc.unwinding_info_size = unwinding_info_size;
|
|
|
|
Handle<Code> code = CcTest::i_isolate()->factory()->NewCode(
|
|
code_desc, Code::STUB, Handle<Object>::null());
|
|
|
|
CHECK(code->has_unwinding_info());
|
|
CHECK_EQ(code->instruction_size(), buffer_size);
|
|
CHECK_EQ(0, memcmp(code->instruction_start(), buffer, buffer_size));
|
|
CHECK(IsAligned(code->GetUnwindingInfoSizeOffset(), 8));
|
|
CHECK_EQ(code->unwinding_info_size(), unwinding_info_size);
|
|
CHECK(
|
|
IsAligned(reinterpret_cast<uintptr_t>(code->unwinding_info_start()), 8));
|
|
CHECK_EQ(
|
|
memcmp(code->unwinding_info_start(), unwinding_info, unwinding_info_size),
|
|
0);
|
|
CHECK_EQ(code->unwinding_info_end() - reinterpret_cast<byte*>(*code),
|
|
Code::kHeaderSize + RoundUp(buffer_size, kInt64Size) + kInt64Size +
|
|
unwinding_info_size - kHeapObjectTag);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|