v8/test/unittests/heap/cppgc/prefinalizer-unittest.cc
Omer Katz ab2b18e1be cppgc: Use object start bitmap to trace mixins
This CL removes the GetTraceDescriptor virtual call from garbage
collected mixins and replaces it with querying the object start
bitmap.

The CL also removes the mixin macros which are now no longer needed.

Bug: chromium:1056170
Change-Id: I27ed299f93025d09a3bb3f0d17b14bed3c200565
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287508
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68787}
2020-07-10 12:00:45 +00:00

203 lines
5.7 KiB
C++

// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "include/cppgc/prefinalizer.h"
#include "include/cppgc/allocation.h"
#include "include/cppgc/garbage-collected.h"
#include "include/cppgc/persistent.h"
#include "src/heap/cppgc/heap-object-header.h"
#include "src/heap/cppgc/heap.h"
#include "test/unittests/heap/cppgc/tests.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cppgc {
namespace internal {
namespace {
class PrefinalizerTest : public testing::TestWithHeap {};
class GCed : public GarbageCollected<GCed> {
CPPGC_USING_PRE_FINALIZER(GCed, PreFinalizer);
public:
void Trace(Visitor*) const {}
void PreFinalizer() { ++prefinalizer_callcount; }
static size_t prefinalizer_callcount;
};
size_t GCed::prefinalizer_callcount = 0;
} // namespace
TEST_F(PrefinalizerTest, PrefinalizerCalledOnDeadObject) {
GCed::prefinalizer_callcount = 0;
auto* object = MakeGarbageCollected<GCed>(GetAllocationHandle());
USE(object);
EXPECT_EQ(0u, GCed::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(1u, GCed::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(1u, GCed::prefinalizer_callcount);
}
TEST_F(PrefinalizerTest, PrefinalizerNotCalledOnLiveObject) {
GCed::prefinalizer_callcount = 0;
{
Persistent<GCed> object = MakeGarbageCollected<GCed>(GetAllocationHandle());
EXPECT_EQ(0u, GCed::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(0u, GCed::prefinalizer_callcount);
}
PreciseGC();
EXPECT_EQ(1u, GCed::prefinalizer_callcount);
}
namespace {
class Mixin : public GarbageCollectedMixin {
CPPGC_USING_PRE_FINALIZER(Mixin, PreFinalizer);
public:
void PreFinalizer() { ++prefinalizer_callcount; }
static size_t prefinalizer_callcount;
};
size_t Mixin::prefinalizer_callcount = 0;
class GCedWithMixin : public GarbageCollected<GCedWithMixin>, public Mixin {};
} // namespace
TEST_F(PrefinalizerTest, PrefinalizerCalledOnDeadMixinObject) {
Mixin::prefinalizer_callcount = 0;
auto* object = MakeGarbageCollected<GCedWithMixin>(GetAllocationHandle());
USE(object);
EXPECT_EQ(0u, Mixin::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(1u, Mixin::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(1u, Mixin::prefinalizer_callcount);
}
TEST_F(PrefinalizerTest, PrefinalizerNotCalledOnLiveMixinObject) {
Mixin::prefinalizer_callcount = 0;
{
Persistent<GCedWithMixin> object =
MakeGarbageCollected<GCedWithMixin>(GetAllocationHandle());
EXPECT_EQ(0u, Mixin::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(0u, Mixin::prefinalizer_callcount);
}
PreciseGC();
EXPECT_EQ(1u, Mixin::prefinalizer_callcount);
}
namespace {
class BaseMixin : public GarbageCollectedMixin {
CPPGC_USING_PRE_FINALIZER(BaseMixin, PreFinalizer);
public:
void PreFinalizer();
static size_t prefinalizer_callcount;
};
size_t BaseMixin::prefinalizer_callcount = 0;
class InheritingMixin : public BaseMixin {
CPPGC_USING_PRE_FINALIZER(InheritingMixin, PreFinalizer);
public:
void PreFinalizer();
static size_t prefinalizer_callcount;
};
size_t InheritingMixin::prefinalizer_callcount = 0;
class GCedWithMixins : public GarbageCollected<GCedWithMixins>,
public InheritingMixin {
CPPGC_USING_PRE_FINALIZER(GCedWithMixins, PreFinalizer);
public:
void PreFinalizer();
static size_t prefinalizer_callcount;
};
size_t GCedWithMixins::prefinalizer_callcount = 0;
void BaseMixin::PreFinalizer() {
EXPECT_EQ(1u, GCedWithMixins::prefinalizer_callcount);
EXPECT_EQ(1u, InheritingMixin::prefinalizer_callcount);
EXPECT_EQ(0u, BaseMixin::prefinalizer_callcount);
++BaseMixin::prefinalizer_callcount;
}
void InheritingMixin::PreFinalizer() {
EXPECT_EQ(1u, GCedWithMixins::prefinalizer_callcount);
EXPECT_EQ(0u, InheritingMixin::prefinalizer_callcount);
EXPECT_EQ(0u, BaseMixin::prefinalizer_callcount);
InheritingMixin::prefinalizer_callcount = true;
}
void GCedWithMixins::PreFinalizer() {
EXPECT_EQ(0u, GCedWithMixins::prefinalizer_callcount);
EXPECT_EQ(0u, InheritingMixin::prefinalizer_callcount);
EXPECT_EQ(0u, BaseMixin::prefinalizer_callcount);
GCedWithMixins::prefinalizer_callcount = true;
}
} // namespace
TEST_F(PrefinalizerTest, PrefinalizerInvocationPreservesOrder) {
BaseMixin::prefinalizer_callcount = 0;
InheritingMixin::prefinalizer_callcount = 0;
GCedWithMixins::prefinalizer_callcount = 0;
auto* object = MakeGarbageCollected<GCedWithMixins>(GetAllocationHandle());
USE(object);
EXPECT_EQ(0u, GCedWithMixins::prefinalizer_callcount);
EXPECT_EQ(0u, InheritingMixin::prefinalizer_callcount);
EXPECT_EQ(0u, BaseMixin::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(1u, GCedWithMixins::prefinalizer_callcount);
EXPECT_EQ(1u, InheritingMixin::prefinalizer_callcount);
EXPECT_EQ(1u, BaseMixin::prefinalizer_callcount);
PreciseGC();
EXPECT_EQ(1u, GCedWithMixins::prefinalizer_callcount);
EXPECT_EQ(1u, InheritingMixin::prefinalizer_callcount);
EXPECT_EQ(1u, BaseMixin::prefinalizer_callcount);
}
namespace {
class AllocatingPrefinalizer : public GarbageCollected<AllocatingPrefinalizer> {
CPPGC_USING_PRE_FINALIZER(AllocatingPrefinalizer, PreFinalizer);
public:
explicit AllocatingPrefinalizer(cppgc::Heap* heap) : heap_(heap) {}
void Trace(Visitor*) const {}
void PreFinalizer() {
MakeGarbageCollected<GCed>(heap_->GetAllocationHandle());
}
private:
cppgc::Heap* heap_;
};
} // namespace
#ifdef DEBUG
TEST_F(PrefinalizerTest, PrefinalizerFailsOnAllcoation) {
auto* object = MakeGarbageCollected<AllocatingPrefinalizer>(
GetAllocationHandle(), GetHeap());
USE(object);
EXPECT_DEATH_IF_SUPPORTED(PreciseGC(), "");
}
#endif // DEBUG
} // namespace internal
} // namespace cppgc