v8/test/mjsunit/harmony/symbols.js
rossberg@chromium.org 5c93b18eb2 ES6 symbols: Allow symbols as property names
Since symbols and strings share a common representation, most of this change is about consistently replacing 'String' with 'Name' in all places where property names are expected. In particular, no new logic at all is necessary for maps, property dictionaries, or transitions. :) The only places where an actual case distinction is needed have to do with generated type checks, and with conversions of names to strings (especially in logger and profiler).

Left in some TODOs wrt to the API: interceptors and native getters don't accept symbols as property names yet, because that would require extending the external v8.h.

(Baseline CL: https://codereview.chromium.org/12296026/)

R=verwaest@chromium.org,mstarzinger@chromium.org
BUG=v8:2158

Review URL: https://codereview.chromium.org/12330012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13811 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-03-04 15:00:57 +00:00

225 lines
6.3 KiB
JavaScript

// Copyright 2013 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --harmony-symbols --harmony-collections
// Flags: --expose-gc --allow-natives-syntax
var symbols = []
// Test different forms of constructor calls, all equivalent.
function TestNew() {
function IndirectSymbol() { return new Symbol }
function indirect() { return new IndirectSymbol() }
for (var i = 0; i < 10; ++i) {
symbols.push(new Symbol)
symbols.push(new Symbol())
symbols.push(Symbol())
symbols.push(indirect())
}
%OptimizeFunctionOnNextCall(indirect)
indirect() // Call once before GC throws away type feedback.
gc() // Promote existing symbols and then allocate some more.
for (var i = 0; i < 10; ++i) {
symbols.push(new Symbol)
symbols.push(new Symbol())
symbols.push(Symbol())
symbols.push(indirect())
}
}
TestNew()
function TestType() {
for (var i in symbols) {
assertTrue(%_IsSymbol(symbols[i]))
assertEquals("object", typeof symbols[i])
assertTrue(typeof symbols[i] === "object")
assertEquals("[object Symbol]", Object.prototype.toString.call(symbols[i]))
}
}
TestType()
function TestEquality() {
// Every symbol should equal itself.
for (var i in symbols) {
assertSame(symbols[i], symbols[i])
assertEquals(symbols[i], symbols[i])
assertTrue(Object.is(symbols[i], symbols[i]))
assertTrue(symbols[i] === symbols[i])
assertTrue(symbols[i] == symbols[i])
}
// All symbols should be distinct.
for (var i = 0; i < symbols.length; ++i) {
for (var j = i + 1; j < symbols.length; ++j) {
assertFalse(Object.is(symbols[i], symbols[j]))
assertFalse(symbols[i] === symbols[j])
assertFalse(symbols[i] == symbols[j])
}
}
}
TestEquality()
function TestGet() {
for (var i in symbols) {
assertEquals("[object Symbol]", symbols[i].toString())
assertEquals(undefined, symbols[i].valueOf)
assertEquals(undefined, symbols[i].a)
assertEquals(undefined, symbols[i]["a" + "b"])
assertEquals(undefined, symbols[i]["" + "1"])
assertEquals(undefined, symbols[i][62])
}
}
TestGet()
function TestSet() {
for (var i in symbols) {
symbols[i].toString = 0
assertEquals("[object Symbol]", symbols[i].toString())
symbols[i].a = 0
assertEquals(undefined, symbols[i].a)
symbols[i]["a" + "b"] = 0
assertEquals(undefined, symbols[i]["a" + "b"])
symbols[i][62] = 0
assertEquals(undefined, symbols[i][62])
}
}
TestSet()
function TestMap() {
var map = new Map
for (var i in symbols) {
map.set(symbols[i], i)
}
for (var i in symbols) {
assertTrue(map.has(symbols[i]))
assertEquals(i, map.get(symbols[i]))
}
}
TestMap()
function TestKeySet(obj) {
// Set the even symbols via assignment.
for (var i = 0; i < symbols.length; i += 2) {
obj[symbols[i]] = i
}
}
function TestKeyDefine(obj) {
// Set the odd symbols via defineProperty (as non-enumerable).
for (var i = 1; i < symbols.length; i += 2) {
Object.defineProperty(obj, symbols[i], {value: i, configurable: true})
}
}
function TestKeyGet(obj) {
var obj2 = Object.create(obj)
for (var i in symbols) {
assertEquals(i|0, obj[symbols[i]])
assertEquals(i|0, obj2[symbols[i]])
}
}
function TestKeyHas() {
for (var i in symbols) {
assertTrue(symbols[i] in obj)
assertTrue(Object.hasOwnProperty.call(obj, symbols[i]))
}
}
function TestKeyEnum(obj) {
// TODO(rossberg): symbols should not show up at all in for-in.
var found = [];
names: for (var name in obj) {
for (var i in symbols) {
if (name === symbols[i]) {
found[i] = true;
continue names;
}
}
}
// All even symbols should have been enumerated.
for (var i = 0; i < symbols.length; i += 2) {
assertTrue(i in found)
}
}
function TestKeyKeys(obj) {
// TODO(rossberg): symbols should not be returned by Object.keys.
assertEquals(symbols.length / 2, Object.keys(obj).length)
assertTrue(symbols.length <= Object.getOwnPropertyNames(obj).length)
}
function TestKeyDescriptor(obj) {
for (var i in symbols) {
var desc = Object.getOwnPropertyDescriptor(obj, symbols[i]);
assertEquals(i|0, desc.value)
assertTrue(desc.configurable)
assertEquals(i % 2 == 0, desc.writable)
assertEquals(i % 2 == 0, desc.enumerable)
assertEquals(i % 2 == 0,
Object.prototype.propertyIsEnumerable.call(obj, symbols[i]))
}
}
function TestKeyDelete(obj) {
for (var i in symbols) {
delete obj[symbols[i]]
}
for (var i in symbols) {
assertEquals(undefined, Object.getOwnPropertyDescriptor(obj, symbols[i]))
}
}
var objs = [{}, [], Object.create(null), Object(1), new Map, function(){}]
for (var i in objs) {
var obj = objs[i]
TestKeySet(obj)
TestKeyDefine(obj)
TestKeyGet(obj)
TestKeyHas(obj)
TestKeyEnum(obj)
TestKeyKeys(obj)
TestKeyDescriptor(obj)
TestKeyDelete(obj)
}