v8/include
Mateusz Czeladka fe598532ec Pass Isolate pointer to String::Utf8Value/Value constructors
As part of J2V8 development (https://github.com/eclipsesource/J2V8),
we realized that we had a subtle bug in how Isolate scope was created
and it's lifetime managed, see:
https://github.com/eclipsesource/J2V8/issues/313.

Mentioned above bug was fixed, however, what we also noticed is that
V8 API has been constantly and slowly moving to such an API, in which
one has to pass Isolate explicitly to methods and/or constructors. We
found two more places that might have been overlooked. This contribution
adds passing of Isolate pointer explicitly to constructors of
String::Utf8Value and String::Value classes.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: I61984285f152aba5ca922100cf3df913a9cb2cea
Reviewed-on: https://chromium-review.googlesource.com/593309
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47656}
2017-08-28 18:17:08 +00:00
..
libplatform Reland "Switch tracing to use v8::TracingController" 2017-07-03 11:49:23 +00:00
APIDesign.md Replace <> with &lt;&gt; in md docs 2017-06-12 10:09:12 +00:00
DEPS [inspector] Build inspector under v8_enable_inspector build flag. 2016-09-06 23:26:35 +00:00
OWNERS Add myself to include/OWNERS 2017-07-07 15:32:00 +00:00
PRESUBMIT.py Add layout test bots to changes to api.cc 2017-05-31 14:15:18 +00:00
v8-debug.h [debugger,api] deprecate everything in v8-debug.h 2017-03-10 07:06:25 +00:00
v8-inspector-protocol.h [inspector] Build inspector under v8_enable_inspector build flag. 2016-09-06 23:26:35 +00:00
v8-inspector.h [inspector] finally removed *ExecuteScript from inspector 2017-03-27 19:26:18 +00:00
v8-platform.h Export default implementation of getting wall-clock time. 2017-08-28 09:28:23 +00:00
v8-profiler.h Fix common misspellings 2017-08-02 09:35:28 +00:00
v8-testing.h Remove easy to remove calls to Isolate::Current() from api.cc 2015-11-30 08:16:59 +00:00
v8-util.h Don't use DCHECK in v8-util.h. 2017-02-27 16:05:46 +00:00
v8-value-serializer-version.h Expose the ValueSerializer data format version as a compile-time constant. 2017-04-27 15:14:41 +00:00
v8-version-string.h Revert of [build] Introduce an embedder version string (patchset #3 id:40001 of https://codereview.chromium.org/2619213002/ ) 2017-01-21 22:36:54 +00:00
v8-version.h Update version to 6.2 2017-07-20 12:21:52 +00:00
v8.h Pass Isolate pointer to String::Utf8Value/Value constructors 2017-08-28 18:17:08 +00:00
v8config.h [cleanup] Remove the V8_NORETURN macro 2017-06-26 09:53:07 +00:00