52ef2a1c27
Expressions of the form
a_0 + a_1 + a_2 + a_3 + ... + a_n
seem to be reasonably common for cases such as building templates.
However, parsing these expressions results in a n-deep expression tree:
...
/
+
/ \
+ a_2
/ \
a_0 a_1
Traversing this tree during compilation can cause a stack overflow when n is
large.
Instead, for left-associate operations such as add, we now build up an
n-ary node in the parse tree, of the form
n-ary +
/ | \
/ | ... \
a_0 a_1 a_n
The bytecode compiler can now iterate through the child expressions
rather than recursing.
This patch only supports arithmetic operations -- subsequent patches
will enable the same optimization for logical tests and comma
expressions.
Bug: v8:6964
Bug: chromium:724961
Bug: chromium:731861
Bug: chromium:752081
Bug: chromium:771653
Bug: chromium:777302
Change-Id: Ie97e4ce42506fe62a7bc4ffbdaa90a9f698352cb
Reviewed-on: https://chromium-review.googlesource.com/733120
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48920}
201 lines
4.5 KiB
Plaintext
201 lines
4.5 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1;
|
|
var b = 2;
|
|
return a + b + 'string';
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 22
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(2),
|
|
B(Star), R(1),
|
|
/* 56 S> */ B(Ldar), R(1),
|
|
/* 65 E> */ B(Add), R(0), U8(0),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(0),
|
|
/* 69 E> */ B(Add), R(2), U8(1),
|
|
/* 80 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["string"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1;
|
|
var b = 2;
|
|
return 'string' + a + b;
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 26
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(2),
|
|
B(Star), R(1),
|
|
/* 56 S> */ B(LdaConstant), U8(0),
|
|
B(Star), R(2),
|
|
B(Ldar), R(0),
|
|
/* 72 E> */ B(Add), R(2), U8(0),
|
|
B(Star), R(2),
|
|
B(Ldar), R(1),
|
|
/* 76 E> */ B(Add), R(2), U8(1),
|
|
/* 80 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["string"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1;
|
|
var b = 2;
|
|
return a + 'string' + b;
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 22
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(2),
|
|
B(Star), R(1),
|
|
/* 56 S> */ B(LdaConstant), U8(0),
|
|
/* 65 E> */ B(Add), R(0), U8(0),
|
|
B(Star), R(2),
|
|
B(Ldar), R(1),
|
|
/* 76 E> */ B(Add), R(2), U8(1),
|
|
/* 80 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["string"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1;
|
|
var b = 2;
|
|
return 'foo' + a + 'bar' + b + 'baz' + 1;
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 43
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(2),
|
|
B(Star), R(1),
|
|
/* 56 S> */ B(LdaConstant), U8(0),
|
|
B(Star), R(2),
|
|
B(Ldar), R(0),
|
|
/* 69 E> */ B(Add), R(2), U8(0),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
/* 73 E> */ B(Add), R(2), U8(1),
|
|
B(Star), R(2),
|
|
B(Ldar), R(1),
|
|
/* 81 E> */ B(Add), R(2), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(2),
|
|
/* 85 E> */ B(Add), R(2), U8(3),
|
|
/* 93 E> */ B(AddSmi), I8(1), U8(4),
|
|
/* 97 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["foo"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["bar"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["baz"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1;
|
|
var b = 2;
|
|
return (a + 'string') + ('string' + b);
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 29
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(2),
|
|
B(Star), R(1),
|
|
/* 56 S> */ B(LdaConstant), U8(0),
|
|
/* 66 E> */ B(Add), R(0), U8(0),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(3),
|
|
B(Ldar), R(1),
|
|
/* 90 E> */ B(Add), R(3), U8(1),
|
|
/* 78 E> */ B(Add), R(2), U8(2),
|
|
/* 95 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["string"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1;
|
|
var b = 2;
|
|
function foo(a, b) { };
|
|
return 'string' + foo(a, b) + a + b;
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 42
|
|
bytecodes: [
|
|
B(CreateClosure), U8(0), U8(0), U8(2),
|
|
B(Star), R(2),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(2),
|
|
B(Star), R(1),
|
|
/* 80 S> */ B(LdaConstant), U8(1),
|
|
B(Star), R(3),
|
|
/* 98 E> */ B(CallUndefinedReceiver2), R(2), R(0), R(1), U8(1),
|
|
/* 96 E> */ B(Add), R(3), U8(3),
|
|
B(Star), R(3),
|
|
B(Ldar), R(0),
|
|
/* 108 E> */ B(Add), R(3), U8(4),
|
|
B(Star), R(3),
|
|
B(Ldar), R(1),
|
|
/* 112 E> */ B(Add), R(3), U8(5),
|
|
/* 116 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["string"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|