f3cfe09549
Private fields should not return undefined on access miss, but instead should throw a TypeError. This patch uses a bit on v8::Symbol to mark if this symbol is a private field or not. This patch also changes the LookupIterator code path that deals with LookupIterator::State::DATA to deal with JSReceiver instead of JSObject. Note: the error message doesn't output the field name, but that's a WIP. Bug: v8:5368 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8ae960b478eb6ae1ebf9bc90658ce3654d687977 Reviewed-on: https://chromium-review.googlesource.com/905627 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#51452}
50 lines
1.0 KiB
JavaScript
50 lines
1.0 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --harmony-private-fields --allow-natives-syntax
|
|
|
|
async function f(assert) {
|
|
try {
|
|
module_namespace_obj = await import('modules-skip-1.js');
|
|
} catch(e) {
|
|
%AbortJS(e);
|
|
}
|
|
|
|
class A {
|
|
constructor(arg) {
|
|
return arg;
|
|
}
|
|
}
|
|
|
|
class X extends A {
|
|
#x = 1;
|
|
|
|
constructor(arg) {
|
|
super(arg);
|
|
}
|
|
|
|
getX(arg) {
|
|
return arg.#x;
|
|
}
|
|
|
|
setX(arg, val) { arg.#x = val; }
|
|
}
|
|
|
|
let x = new X(module_namespace_obj);
|
|
|
|
assert.equals(1, X.prototype.getX(module_namespace_obj));
|
|
assert.equals(1, X.prototype.getX(module_namespace_obj));
|
|
assert.equals(1, X.prototype.getX(module_namespace_obj));
|
|
|
|
X.prototype.setX(module_namespace_obj, 2);
|
|
X.prototype.setX(module_namespace_obj, 3);
|
|
X.prototype.setX(module_namespace_obj, 4);
|
|
}
|
|
|
|
testAsync(assert => {
|
|
assert.plan(3);
|
|
|
|
f(assert).catch(assert.unreachable);
|
|
}, "private-fields-special-object");
|