AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
602e566e4c
v8/test/unittests/deoptimizer/deoptimization-unittest.cc
jameslahm dc5972784b [test] Move cctest/test-deoptimization to unittests/ 
... deoptimizer/deoptimization-unittest.

Bug: v8:12781
Change-Id: I453d02f6ead59ee274af600197dedc01cb144a4e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705237
Commit-Queue: 王澳 <wangao.james@bytedance.com>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81181}
2022-06-15 12:37:25 +00:00

863 lines
29 KiB
C++
Raw Blame History

// Copyright 2012 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <stdlib.h>
#include "include/v8-function.h"
#include "src/api/api-inl.h"
#include "src/base/platform/platform.h"
#include "src/base/strings.h"
#include "src/codegen/compilation-cache.h"
#include "src/debug/debug.h"
#include "src/deoptimizer/deoptimizer.h"
#include "src/execution/isolate.h"
#include "src/init/v8.h"
#include "src/objects/objects-inl.h"
#include "test/unittests/test-utils.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace v8 {
namespace internal {
using ::v8::base::EmbeddedVector;
using ::v8::base::OS;
class DeoptimizationTest : public TestWithContext {
public:
Handle<JSFunction> GetJSFunction(const char* property_name) {
v8::Local<v8::Function> fun = v8::Local<v8::Function>::Cast(
context()
->Global()
->Get(context(), NewString(property_name))
.ToLocalChecked());
return i::Handle<i::JSFunction>::cast(v8::Utils::OpenHandle(*fun));
}
};
// Size of temp buffer for formatting small strings.
#define SMALL_STRING_BUFFER_SIZE 80
// Utility class to set the following runtime flags when constructed and return
// to their default state when destroyed:
// --allow-natives-syntax --always-turbofan --noturbo-inlining
class AlwaysOptimizeAllowNativesSyntaxNoInlining {
public:
AlwaysOptimizeAllowNativesSyntaxNoInlining()
: always_turbofan_(i::FLAG_always_turbofan),
allow_natives_syntax_(i::FLAG_allow_natives_syntax),
turbo_inlining_(i::FLAG_turbo_inlining) {
i::FLAG_always_turbofan = true;
i::FLAG_allow_natives_syntax = true;
i::FLAG_turbo_inlining = false;
}
~AlwaysOptimizeAllowNativesSyntaxNoInlining() {
i::FLAG_always_turbofan = always_turbofan_;
i::FLAG_allow_natives_syntax = allow_natives_syntax_;
i::FLAG_turbo_inlining = turbo_inlining_;
}
private:
bool always_turbofan_;
bool allow_natives_syntax_;
bool turbo_inlining_;
};
// Utility class to set the following runtime flags when constructed and return
// to their default state when destroyed:
// --allow-natives-syntax --noturbo-inlining
class AllowNativesSyntaxNoInlining {
public:
AllowNativesSyntaxNoInlining()
: allow_natives_syntax_(i::FLAG_allow_natives_syntax),
turbo_inlining_(i::FLAG_turbo_inlining) {
i::FLAG_allow_natives_syntax = true;
i::FLAG_turbo_inlining = false;
}
~AllowNativesSyntaxNoInlining() {
i::FLAG_allow_natives_syntax = allow_natives_syntax_;
i::FLAG_turbo_inlining = turbo_inlining_;
}
private:
bool allow_natives_syntax_;
bool turbo_inlining_;
};
TEST_F(DeoptimizationTest, DeoptimizeSimple) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
// Test lazy deoptimization of a simple function.
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"function h() { %DeoptimizeFunction(f); }"
"function g() { count++; h(); }"
"function f() { g(); };"
"f();");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
// Test lazy deoptimization of a simple function. Call the function after the
// deoptimization while it is still activated further down the stack.
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"function g() { count++; %DeoptimizeFunction(f); f(false); }"
"function f(x) { if (x) { g(); } else { return } };"
"f(true);");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationTest, DeoptimizeSimpleWithArguments) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
// Test lazy deoptimization of a simple function with some arguments.
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"function h(x) { %DeoptimizeFunction(f); }"
"function g(x, y) { count++; h(x); }"
"function f(x, y, z) { g(1,x); y+z; };"
"f(1, \"2\", false);");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
// Test lazy deoptimization of a simple function with some arguments. Call the
// function after the deoptimization while it is still activated further down
// the stack.
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"function g(x, y) { count++; %DeoptimizeFunction(f); f(false, 1, y); }"
"function f(x, y, z) { if (x) { g(x, y); } else { return y + z; } };"
"f(true, 1, \"2\");");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationTest, DeoptimizeSimpleNested) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
// Test lazy deoptimization of a simple function. Have a nested function call
// do the deoptimization.
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"var result = 0;"
"function h(x, y, z) { return x + y + z; }"
"function g(z) { count++; %DeoptimizeFunction(f); return z;}"
"function f(x,y,z) { return h(x, y, g(z)); };"
"result = f(1, 2, 3);");
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(6, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
}
TEST_F(DeoptimizationTest, DeoptimizeRecursive) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
{
// Test lazy deoptimization of a simple function called recursively. Call
// the function recursively a number of times before deoptimizing it.
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"var calls = 0;"
"function g() { count++; %DeoptimizeFunction(f); }"
"function f(x) { calls++; if (x > 0) { f(x - 1); } else { g(); } };"
"f(10);");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(11, context()
->Global()
->Get(context(), NewString("calls"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
v8::Local<v8::Function> fun = v8::Local<v8::Function>::Cast(
context()->Global()->Get(context(), NewString("f")).ToLocalChecked());
CHECK(!fun.IsEmpty());
}
TEST_F(DeoptimizationTest, DeoptimizeMultiple) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"var result = 0;"
"function g() { count++;"
" %DeoptimizeFunction(f1);"
" %DeoptimizeFunction(f2);"
" %DeoptimizeFunction(f3);"
" %DeoptimizeFunction(f4);}"
"function f4(x) { g(); };"
"function f3(x, y, z) { f4(); return x + y + z; };"
"function f2(x, y) { return x + f3(y + 1, y + 1, y + 1) + y; };"
"function f1(x) { return f2(x + 1, x + 1) + x; };"
"result = f1(1);");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(14, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationTest, DeoptimizeConstructor) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"function g() { count++;"
" %DeoptimizeFunction(f); }"
"function f() { g(); };"
"result = new f() instanceof f;");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK(context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->IsTrue());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"var result = 0;"
"function g() { count++;"
" %DeoptimizeFunction(f); }"
"function f(x, y) { this.x = x; g(); this.y = y; };"
"result = new f(1, 2);"
"result = result.x + result.y;");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(3, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationTest, DeoptimizeConstructorMultiple) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
{
AlwaysOptimizeAllowNativesSyntaxNoInlining options;
RunJS(
"var count = 0;"
"var result = 0;"
"function g() { count++;"
" %DeoptimizeFunction(f1);"
" %DeoptimizeFunction(f2);"
" %DeoptimizeFunction(f3);"
" %DeoptimizeFunction(f4);}"
"function f4(x) { this.result = x; g(); };"
"function f3(x, y, z) { this.result = new f4(x + y + z).result; };"
"function f2(x, y) {"
" this.result = x + new f3(y + 1, y + 1, y + 1).result + y; };"
"function f1(x) { this.result = new f2(x + 1, x + 1).result + x; };"
"result = new f1(1).result;");
}
CollectAllGarbage();
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(14, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
class DeoptimizationDisableConcurrentRecompilationTest
: public DeoptimizationTest {
public:
void CompileConstructorWithDeoptimizingValueOf() {
RunJS(
"var count = 0;"
"var result = 0;"
"var deopt = false;"
"function X() { };"
"X.prototype.valueOf = function () {"
" if (deopt) { count++; %DeoptimizeFunction(f); } return 8"
"};");
}
static void SetUpTestSuite() { i::FLAG_concurrent_recompilation = false; }
void TestDeoptimizeBinaryOp(const char* binary_op) {
v8::base::EmbeddedVector<char, SMALL_STRING_BUFFER_SIZE> f_source_buffer;
v8::base::SNPrintF(f_source_buffer, "function f(x, y) { return x %s y; };",
binary_op);
char* f_source = f_source_buffer.begin();
AllowNativesSyntaxNoInlining options;
// Compile function f and collect to type feedback to insert binary op stub
// call in the optimized code.
i::FLAG_prepare_always_turbofan = true;
CompileConstructorWithDeoptimizingValueOf();
RunJS(f_source);
RunJS(
"for (var i = 0; i < 5; i++) {"
" f(8, new X());"
"};");
// Compile an optimized version of f.
i::FLAG_always_turbofan = true;
RunJS(f_source);
RunJS("f(7, new X());");
CHECK(!i_isolate()->use_optimizer() ||
GetJSFunction("f")->HasAttachedOptimizedCode());
// Call f and force deoptimization while processing the binary operation.
RunJS(
"deopt = true;"
"var result = f(7, new X());");
CollectAllGarbage();
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
}
};
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeBinaryOperationADDString) {
ManualGCScope manual_gc_scope(i_isolate());
AllowNativesSyntaxNoInlining options;
v8::HandleScope scope(isolate());
const char* f_source = "function f(x, y) { return x + y; };";
{
// Compile function f and collect to type feedback to insert binary op
// stub call in the optimized code.
i::FLAG_prepare_always_turbofan = true;
RunJS(
"var count = 0;"
"var result = 0;"
"var deopt = false;"
"function X() { };"
"X.prototype.toString = function () {"
" if (deopt) { count++; %DeoptimizeFunction(f); } return 'an X'"
"};");
RunJS(f_source);
RunJS(
"for (var i = 0; i < 5; i++) {"
" f('a+', new X());"
"};");
// Compile an optimized version of f.
i::FLAG_always_turbofan = true;
RunJS(f_source);
RunJS("f('a+', new X());");
CHECK(!i_isolate()->use_optimizer() ||
GetJSFunction("f")->HasAttachedOptimizedCode());
// Call f and force deoptimization while processing the binary operation.
RunJS(
"deopt = true;"
"var result = f('a+', new X());");
}
CollectAllGarbage();
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
v8::Local<v8::Value> result =
context()->Global()->Get(context(), NewString("result")).ToLocalChecked();
CHECK(result->IsString());
v8::String::Utf8Value utf8(isolate(), result);
CHECK_EQ(0, strcmp("a+an X", *utf8));
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeBinaryOperationADD) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
TestDeoptimizeBinaryOp("+");
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(15, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeBinaryOperationSUB) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
TestDeoptimizeBinaryOp("-");
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(-1, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeBinaryOperationMUL) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
TestDeoptimizeBinaryOp("*");
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(56, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeBinaryOperationDIV) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
TestDeoptimizeBinaryOp("/");
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeBinaryOperationMOD) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
TestDeoptimizeBinaryOp("%");
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(7, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest, DeoptimizeCompare) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
const char* f_source = "function f(x, y) { return x < y; };";
{
AllowNativesSyntaxNoInlining options;
// Compile function f and collect to type feedback to insert compare ic
// call in the optimized code.
i::FLAG_prepare_always_turbofan = true;
RunJS(
"var count = 0;"
"var result = 0;"
"var deopt = false;"
"function X() { };"
"X.prototype.toString = function () {"
" if (deopt) { count++; %DeoptimizeFunction(f); } return 'b'"
"};");
RunJS(f_source);
RunJS(
"for (var i = 0; i < 5; i++) {"
" f('a', new X());"
"};");
// Compile an optimized version of f.
i::FLAG_always_turbofan = true;
RunJS(f_source);
RunJS("f('a', new X());");
CHECK(!i_isolate()->use_optimizer() ||
GetJSFunction("f")->HasAttachedOptimizedCode());
// Call f and force deoptimization while processing the comparison.
RunJS(
"deopt = true;"
"var result = f('a', new X());");
}
CollectAllGarbage();
CHECK(!GetJSFunction("f")->HasAttachedOptimizedCode());
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(true, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->BooleanValue(isolate()));
CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate()));
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeLoadICStoreIC) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
// Functions to generate load/store/keyed load/keyed store IC calls.
const char* f1_source = "function f1(x) { return x.y; };";
const char* g1_source = "function g1(x) { x.y = 1; };";
const char* f2_source = "function f2(x, y) { return x[y]; };";
const char* g2_source = "function g2(x, y) { x[y] = 1; };";
{
AllowNativesSyntaxNoInlining options;
// Compile functions and collect to type feedback to insert ic
// calls in the optimized code.
i::FLAG_prepare_always_turbofan = true;
RunJS(
"var count = 0;"
"var result = 0;"
"var deopt = false;"
"function X() { };"
"X.prototype.__defineGetter__('y', function () {"
" if (deopt) { count++; %DeoptimizeFunction(f1); };"
" return 13;"
"});"
"X.prototype.__defineSetter__('y', function () {"
" if (deopt) { count++; %DeoptimizeFunction(g1); };"
"});"
"X.prototype.__defineGetter__('z', function () {"
" if (deopt) { count++; %DeoptimizeFunction(f2); };"
" return 13;"
"});"
"X.prototype.__defineSetter__('z', function () {"
" if (deopt) { count++; %DeoptimizeFunction(g2); };"
"});");
RunJS(f1_source);
RunJS(g1_source);
RunJS(f2_source);
RunJS(g2_source);
RunJS(
"for (var i = 0; i < 5; i++) {"
" f1(new X());"
" g1(new X());"
" f2(new X(), 'z');"
" g2(new X(), 'z');"
"};");
// Compile an optimized version of the functions.
i::FLAG_always_turbofan = true;
RunJS(f1_source);
RunJS(g1_source);
RunJS(f2_source);
RunJS(g2_source);
RunJS("f1(new X());");
RunJS("g1(new X());");
RunJS("f2(new X(), 'z');");
RunJS("g2(new X(), 'z');");
if (i_isolate()->use_optimizer()) {
CHECK(GetJSFunction("f1")->HasAttachedOptimizedCode());
CHECK(GetJSFunction("g1")->HasAttachedOptimizedCode());
CHECK(GetJSFunction("f2")->HasAttachedOptimizedCode());
CHECK(GetJSFunction("g2")->HasAttachedOptimizedCode());
}
// Call functions and force deoptimization while processing the ics.
RunJS(
"deopt = true;"
"var result = f1(new X());"
"g1(new X());"
"f2(new X(), 'z');"
"g2(new X(), 'z');");
}
CollectAllGarbage();
CHECK(!GetJSFunction("f1")->HasAttachedOptimizedCode());
CHECK(!GetJSFunction("g1")->HasAttachedOptimizedCode());
CHECK(!GetJSFunction("f2")->HasAttachedOptimizedCode());
CHECK(!GetJSFunction("g2")->HasAttachedOptimizedCode());
CHECK_EQ(4, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(13, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
}
TEST_F(DeoptimizationDisableConcurrentRecompilationTest,
DeoptimizeLoadICStoreICNested) {
ManualGCScope manual_gc_scope(i_isolate());
v8::HandleScope scope(isolate());
// Functions to generate load/store/keyed load/keyed store IC calls.
const char* f1_source = "function f1(x) { return x.y; };";
const char* g1_source = "function g1(x) { x.y = 1; };";
const char* f2_source = "function f2(x, y) { return x[y]; };";
const char* g2_source = "function g2(x, y) { x[y] = 1; };";
{
AllowNativesSyntaxNoInlining options;
// Compile functions and collect to type feedback to insert ic
// calls in the optimized code.
i::FLAG_prepare_always_turbofan = true;
RunJS(
"var count = 0;"
"var result = 0;"
"var deopt = false;"
"function X() { };"
"X.prototype.__defineGetter__('y', function () {"
" g1(this);"
" return 13;"
"});"
"X.prototype.__defineSetter__('y', function () {"
" f2(this, 'z');"
"});"
"X.prototype.__defineGetter__('z', function () {"
" g2(this, 'z');"
"});"
"X.prototype.__defineSetter__('z', function () {"
" if (deopt) {"
" count++;"
" %DeoptimizeFunction(f1);"
" %DeoptimizeFunction(g1);"
" %DeoptimizeFunction(f2);"
" %DeoptimizeFunction(g2); };"
"});");
RunJS(f1_source);
RunJS(g1_source);
RunJS(f2_source);
RunJS(g2_source);
RunJS(
"for (var i = 0; i < 5; i++) {"
" f1(new X());"
" g1(new X());"
" f2(new X(), 'z');"
" g2(new X(), 'z');"
"};");
// Compile an optimized version of the functions.
i::FLAG_always_turbofan = true;
RunJS(f1_source);
RunJS(g1_source);
RunJS(f2_source);
RunJS(g2_source);
RunJS("f1(new X());");
RunJS("g1(new X());");
RunJS("f2(new X(), 'z');");
RunJS("g2(new X(), 'z');");
if (i_isolate()->use_optimizer()) {
CHECK(GetJSFunction("f1")->HasAttachedOptimizedCode());
CHECK(GetJSFunction("g1")->HasAttachedOptimizedCode());
CHECK(GetJSFunction("f2")->HasAttachedOptimizedCode());
CHECK(GetJSFunction("g2")->HasAttachedOptimizedCode());
}
// Call functions and force deoptimization while processing the ics.
RunJS(
"deopt = true;"
"var result = f1(new X());");
}
CollectAllGarbage();
CHECK(!GetJSFunction("f1")->HasAttachedOptimizedCode());
CHECK(!GetJSFunction("g1")->HasAttachedOptimizedCode());
CHECK(!GetJSFunction("f2")->HasAttachedOptimizedCode());
CHECK(!GetJSFunction("g2")->HasAttachedOptimizedCode());
CHECK_EQ(1, context()
->Global()
->Get(context(), NewString("count"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
CHECK_EQ(13, context()
->Global()
->Get(context(), NewString("result"))
.ToLocalChecked()
->Int32Value(context())
.FromJust());
}
} // namespace internal
} // namespace v8
Reference in New Issue View Git Blame Copy Permalink