60d9dd3563
The OnProfileEndListener callback has to be reset before the isolate dies to avoid a use-after-free when the Global which holds the callback gets released. Drive-by change: make the OnProfileEndListener callback isolate-specific. At the moment a `profileEnd` call in IsolateA could trigger the OnProfileEndListener callback of IsolateB, which could cause all kinds of data races (the callback would access the isolate, but the isolate is not supposed to get accessed by multiple threads concurrently. With this CL there is one callback per isolate. R=clemensb@chromium.org Bug: chromium:1395237 Change-Id: Ifaa5b883a231f5519a3bfeb6187fb7d8faa02b02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4076465 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#84646} |
||
---|---|---|
.. | ||
benchmarks | ||
bigint | ||
cctest | ||
common | ||
debugger | ||
debugging | ||
fuzzer | ||
fuzzilli | ||
inspector | ||
intl | ||
js-perf-test | ||
memory | ||
message | ||
mjsunit | ||
mkgrokdump | ||
mozilla | ||
test262 | ||
torque | ||
unittests | ||
wasm-api-tests | ||
wasm-js | ||
wasm-spec-tests | ||
webkit | ||
BUILD.gn | ||
OWNERS |