c9b4f3c4a7
This CL is part of a series that implements Turbofan support for property accesses satisfying the following conditions: 1. The holder is a dictionary mode object. 2. The holder is a prototype. 3. The access is a load. This feature will only be enabled if the build flag v8_dict_property_const_tracking is set. This particular CL modifies existing mjsunit tests whose assumptions don't hold if v8_dict_property_const_tracking is enabled. This is done by adding special handling for the case that %IsDictPropertyConstTrackingEnabled() holds. Bug: v8:11248 Change-Id: Ia36be73e4659a988b2471f0c8151b0442f3a98f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2780292 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73745}
43 lines
1.1 KiB
JavaScript
43 lines
1.1 KiB
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-always-opt
|
|
|
|
var expect_interpreted = true;
|
|
|
|
class C {
|
|
get prop() {
|
|
return 42;
|
|
}
|
|
set prop(v) {
|
|
if (!%IsDictPropertyConstTrackingEnabled()) {
|
|
// TODO(v8:11457) If v8_dict_property_const_tracking is enabled, then
|
|
// C.prototype is a dictionary mode object and we cannot inline the call
|
|
// to this setter, yet.
|
|
assertEquals(expect_interpreted, %IsBeingInterpreted());
|
|
}
|
|
%TurbofanStaticAssert(v === 43);
|
|
}
|
|
}
|
|
|
|
const c = new C();
|
|
|
|
function foo() {
|
|
assertEquals(expect_interpreted, %IsBeingInterpreted());
|
|
%TurbofanStaticAssert(c.prop === 42);
|
|
c.prop = 43;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(
|
|
Object.getOwnPropertyDescriptor(C.prototype, 'prop').get);
|
|
%PrepareFunctionForOptimization(
|
|
Object.getOwnPropertyDescriptor(C.prototype, 'prop').set);
|
|
%PrepareFunctionForOptimization(foo);
|
|
|
|
foo();
|
|
foo();
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
expect_interpreted = false;
|
|
foo();
|