AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
6207d75e91
v8/test/cctest/compiler
History
Clemens Hammacher daa2667990 Remove FixedArray::GetValueChecked 
This method is rarely used, and has several problems:
1) It CHECKs that the value is not undefined, then creates a
   {Handle<T>} which again DCHECKs that the value is of type {T}.
2) It is called on a raw {FixedArray} but returns a handle.
3) It is often used when no handle is actually needed, adding
   unnecessary overhead.
4) It adds complexity and hides actual checks and handlification.

This CL removes that method, replacing some uses by explicit CHECKs (in
tests) and relying on the DCHECKs in the casts otherwise.

R=mstarzinger@chromium.org

Bug: v8:9183
Change-Id: I90ff59e8b78c909a9a207029d8cc9ab16c0c7b56
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621939
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61710}
2019-05-21 17:50:21 +00:00
..
c-signature.h Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
call-tester.h [ubsan] Port Object to the new design 2018-12-26 20:54:07 +00:00
code-assembler-tester.h Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
codegen-tester.cc [test] Remove redundant variables in value helpers 2019-02-01 15:00:21 +00:00
codegen-tester.h Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
function-tester.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
function-tester.h [turbofan] Put some tests under a canonical handle scope. 2018-07-31 18:20:53 +00:00
graph-and-builders.h [cleanup] Removing GraphBuilderTester class 2019-05-07 09:54:51 +00:00
serializer-tester.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
serializer-tester.h [turbofan] Don't allocate JSHeapBroker in the zone 2019-05-02 13:02:19 +00:00
test-basic-block-profiler.cc Reland "Move logging and diagnostics related source files" 2019-05-20 09:54:57 +00:00
test-branch-combine.cc [test] Remove redundant variables in value helpers 2019-02-01 15:00:21 +00:00
test-code-assembler.cc Add StaticAssert in Torque 2019-05-21 15:39:57 +00:00
test-code-generator.cc Remove FixedArray::GetValueChecked 2019-05-21 17:50:21 +00:00
test-gap-resolver.cc [cleanup] Remove unneeded Printable wrappers 2018-11-22 10:01:56 +00:00
test-graph-visualizer.cc Reland "Introduce StdoutStream which prints to Android log or stdout" 2018-06-14 13:29:01 +00:00
test-instruction-scheduler.cc [turbofan] Implement loop rotation 2018-11-16 13:52:12 +00:00
test-instruction.cc [compiler] Move some files to backend/ directory 2018-11-12 15:06:56 +00:00
test-js-constant-cache.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-js-context-specialization.cc Move relevant files to src/objects 2019-05-20 08:57:47 +00:00
test-js-typed-lowering.cc [turbofan] Remove redundant isolate argument from typers. 2018-09-25 13:00:05 +00:00
test-jump-threading.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-linkage.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-loop-analysis.cc Reland "Introduce StdoutStream which prints to Android log or stdout" 2018-06-14 13:29:01 +00:00
test-machine-operator-reducer.cc [test] Remove redundant variables in value helpers 2019-02-01 15:00:21 +00:00
test-multiple-return.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-node.cc Use nullptr instead of NULL where possible 2017-10-13 17:21:49 +00:00
test-operator.cc Normalize casing of hexadecimal digits 2017-12-02 01:24:40 +00:00
test-representation-change.cc [turbofan] Fix handling of null in -0 == null comparison 2019-05-13 13:35:03 +00:00
test-run-bytecode-graph-builder.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-run-calls-to-external-references.cc [turbofan] Refactor interface of calling C functions 2019-04-09 13:16:24 +00:00
test-run-deopt.cc [fullcodegen] Remove --stress-fullcodegen flag. 2017-08-10 09:52:49 +00:00
test-run-intrinsics.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-run-jsbranches.cc [turbofan] Remove for-in support from the AstGraphBuilder. 2017-02-08 06:41:42 +00:00
test-run-jscalls.cc [iwyu] api.h iwyu 2018-07-20 11:49:02 +00:00
test-run-jsexceptions.cc [fullcodegen] Remove --stress-fullcodegen flag. 2017-08-10 09:52:49 +00:00
test-run-jsobjects.cc [explicit isolates] Remove various GetIsolates 2018-07-17 11:56:37 +00:00
test-run-jsops.cc Normalize casing of hexadecimal digits 2017-12-02 01:24:40 +00:00
test-run-load-store.cc [cleanup] MachineType 'rep' variables renamed to 'type' 2019-05-15 11:21:53 +00:00
test-run-machops.cc [cleanup] Removing GraphBuilderTester class 2019-05-07 09:54:51 +00:00
test-run-native-calls.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-run-retpoline.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-run-stackcheck.cc [fullcodegen] Remove --stress-fullcodegen flag. 2017-08-10 09:52:49 +00:00
test-run-tail-calls.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-run-unwinding-info.cc [cleanup] Make unicode predicate cache tables static 2018-11-14 15:33:45 +00:00
test-run-variables.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
value-helper.cc Reland "[test] Avoid unnecessary std::vector allocations" 2017-10-19 08:47:31 +00:00
value-helper.h [test] Modernize value helpers 2019-02-01 12:56:59 +00:00