eb1d2d7098
Compilation only stores whether an error has been found, but not the exact error or it's location. This is generated by running a validation pass once all wire bytes have been received. This unifies error messages by removing one more location where we generate compilation error messages, and makes it deterministic because a) we always report the error in the first failing function, and b) if names are present, the error message will always contain the function name. R=titzer@chromium.org Bug: chromium:926311, v8:8814 Change-Id: I79551b8bb73dcee503484de343a3ada60a6add4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521112 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60242}
79 lines
2.7 KiB
JavaScript
79 lines
2.7 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
load("test/mjsunit/wasm/wasm-module-builder.js");
|
|
|
|
async function assertCompiles(buffer) {
|
|
var module = await WebAssembly.compile(buffer);
|
|
assertInstanceof(module, WebAssembly.Module);
|
|
}
|
|
|
|
function assertCompileError(buffer, msg) {
|
|
assertEquals('string', typeof msg);
|
|
return assertThrowsAsync(
|
|
WebAssembly.compile(buffer), WebAssembly.CompileError,
|
|
'WebAssembly.compile(): ' + msg);
|
|
}
|
|
|
|
assertPromiseResult(async function basicCompile() {
|
|
let ok_buffer = (() => {
|
|
var builder = new WasmModuleBuilder();
|
|
builder.addFunction('f', kSig_i_v)
|
|
.addBody([kExprI32Const, 42])
|
|
.exportAs('f');
|
|
return builder.toBuffer();
|
|
})();
|
|
|
|
// The OK buffer validates and can be made into a module.
|
|
assertTrue(WebAssembly.validate(ok_buffer));
|
|
let ok_module = new WebAssembly.Module(ok_buffer);
|
|
assertTrue(ok_module instanceof WebAssembly.Module);
|
|
|
|
// The bad buffer does not validate and cannot be made into a module.
|
|
let bad_buffer = new ArrayBuffer(0);
|
|
assertFalse(WebAssembly.validate(bad_buffer));
|
|
assertThrows(
|
|
() => new WebAssembly.Module(bad_buffer), WebAssembly.CompileError);
|
|
|
|
let kNumCompiles = 3;
|
|
|
|
// Three compilations of the OK module should succeed.
|
|
for (var i = 0; i < kNumCompiles; i++) {
|
|
await assertCompiles(ok_buffer);
|
|
}
|
|
|
|
// Three compilations of the bad module should fail.
|
|
for (var i = 0; i < kNumCompiles; i++) {
|
|
await assertCompileError(bad_buffer, 'BufferSource argument is empty');
|
|
}
|
|
}());
|
|
|
|
assertPromiseResult(async function badFunctionInTheMiddle() {
|
|
// We had an error where an exception was generated by a background task and
|
|
// later thrown in a foreground task. The handle to the exception died
|
|
// between, since the HandleScope was left.
|
|
// This test reproduced that error.
|
|
let builder = new WasmModuleBuilder();
|
|
let sig = builder.addType(kSig_i_v);
|
|
for (var i = 0; i < 10; ++i) {
|
|
builder.addFunction('a' + i, sig).addBody([kExprI32Const, 42]);
|
|
}
|
|
builder.addFunction('bad', sig).addBody([]);
|
|
for (var i = 0; i < 10; ++i) {
|
|
builder.addFunction('b' + i, sig).addBody([kExprI32Const, 42]);
|
|
}
|
|
let buffer = builder.toBuffer();
|
|
await assertCompileError(
|
|
buffer,
|
|
'Compiling function #10:\"bad\" failed: ' +
|
|
'expected 1 elements on the stack for fallthru to @1, found 0 @+94');
|
|
}());
|
|
|
|
assertPromiseResult(async function importWithoutCode() {
|
|
// Regression test for https://crbug.com/898310.
|
|
let builder = new WasmModuleBuilder();
|
|
builder.addImport('m', 'q', kSig_i_i);
|
|
await builder.asyncInstantiate({'m': {'q': i => i}});
|
|
}());
|