22594d1092
This reverts commit 3dfaf8264f.
Reason for revert: Failures - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20gcc%204.8/20394
Original change's description:
> [debug] liveedit in native
>
> Liveedit step-by-step:
> 1. calculate diff between old source and new source,
> 2. map function literals from old source to new source,
> 3. create new script for new_source,
> 4. mark literals with changed code as changed, all others as unchanged,
> 5. check that for changed literals there are no:
> - running generators in the heap,
> - non droppable frames (e.g. running generator) above them on stack.
> 6. mark the bottom most frame with changed function as scheduled for
> restart if any.
> 7. for unchanged functions:
> - deoptimize,
> - remove from cache,
> - update source positions,
> - move to new script,
> - reset feedback information and preparsed scope information if any,
> - replace any sfi in constant pool with changed one if any.
> 8. for changed functions:
> - deoptimize
> - remove from cache,
> - reset feedback information,
> - update all links from js functions to old shared with new one.
> 9. swap scripts.
>
> TBR=ulan@chromium.org
>
> Bug: v8:7862,v8:5713
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I8f6f6156318cc82d6f36d7ebc1c9f7d5f3aa1461
> Reviewed-on: https://chromium-review.googlesource.com/1105493
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54146}
TBR=dgozman@chromium.org,ulan@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org
Change-Id: I45df5b6f3abaf29e593c6ac11edefbd0177d0109
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7862, v8:5713
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1124159
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54151}
77 lines
1.8 KiB
JavaScript
77 lines
1.8 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
// Test that live-editing a frame to introduce new.target fails.
|
|
|
|
Debug = debug.Debug
|
|
var calls = 0;
|
|
var exceptions = 0;
|
|
var results = [];
|
|
var replace_again;
|
|
|
|
eval(`
|
|
function LogNewTarget() {
|
|
calls++;
|
|
ReplaceOnce();
|
|
results.push(true);
|
|
}
|
|
`);
|
|
|
|
function ExecuteInDebugContext(f) {
|
|
var result;
|
|
var exception = null;
|
|
Debug.setListener(function(event) {
|
|
if (event == Debug.DebugEvent.Break) {
|
|
try {
|
|
result = f();
|
|
} catch (e) {
|
|
// Rethrow this exception later.
|
|
exception = e;
|
|
}
|
|
}
|
|
});
|
|
debugger;
|
|
Debug.setListener(null);
|
|
if (exception !== null) throw exception;
|
|
return result;
|
|
}
|
|
|
|
function Replace(fun, original, patch) {
|
|
ExecuteInDebugContext(function() {
|
|
try {
|
|
%LiveEditPatchScript(fun, Debug.scriptSource(fun).replace(original, patch));
|
|
} catch (e) {
|
|
// TODO(kozyatinskiy): message should be BLOCKED_BY_NEW_TARGET_IN_RESTART_FRAME.
|
|
assertEquals(e, 'LiveEdit failed: BLOCKED_BY_FUNCTION_BELOW_NON_DROPPABLE_FRAME');
|
|
exceptions++;
|
|
}
|
|
});
|
|
}
|
|
|
|
function ReplaceOnce(x) {
|
|
if (replace_again) {
|
|
replace_again = false;
|
|
Replace(LogNewTarget, "true", "new.target");
|
|
}
|
|
}
|
|
|
|
function Revert() {
|
|
Replace(LogNewTarget, "new.target", "true");
|
|
}
|
|
|
|
replace_again = true;
|
|
ReplaceOnce();
|
|
new LogNewTarget();
|
|
Revert();
|
|
assertEquals(1, calls);
|
|
assertEquals(0, exceptions);
|
|
assertEquals([LogNewTarget], results);
|
|
|
|
replace_again = true;
|
|
new LogNewTarget();
|
|
assertEquals(2, calls); // No restarts
|
|
assertEquals(1, exceptions); // Replace failed.
|
|
assertEquals([LogNewTarget, true], results);
|