cebfde6769
The function-entry stack check should dominate all other
instructions in a function. Prior to this CL it was possible to create
paths not including a stack check due to SwitchOnGeneratorState: the
generator-creation branch had a stack check, while generator-resume
branches did not.
0 : af fb 00 01 SwitchOnGeneratorState r0, [0], [1] { 0: @22 }
4 : 27 fe fa Mov <closure>, r1
7 : 27 02 f9 Mov <this>, r2
10 : 64 0a fa 02 InvokeIntrinsic [_CreateJSGeneratorObject], r1-r2
14 : 26 fb Star r0
16 : a7 StackCheck
17 : b0 fb fb 01 00 SuspendGenerator r0, r0-r0, [0]
22 : b1 fb fb 01 ResumeGenerator r0, r0-r0
[... no stack check here ...]
This CL moves the stack check to the beginning of the bytecode array,
i.e. before SwitchOnGeneratorState.
Bug: chromium:1020031
Change-Id: I8ba8cba99611ddbe50c76023129d926cc84b1d5e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903440
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64888}
152 lines
4.1 KiB
Plaintext
152 lines
4.1 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 19
|
|
bytecodes: [
|
|
/* 93 E> */ B(StackCheck),
|
|
B(CreateRestParameter),
|
|
B(Star), R(2),
|
|
B(Mov), R(closure), R(1),
|
|
/* 93 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(4),
|
|
B(Ldar), R(0),
|
|
/* 93 E> */ B(ConstructWithSpread), R(4), R(2), U8(1), U8(0),
|
|
/* 93 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 9
|
|
parameter count: 1
|
|
bytecode array length: 40
|
|
bytecodes: [
|
|
/* 128 E> */ B(StackCheck),
|
|
B(CreateRestParameter),
|
|
B(Star), R(3),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(3), R(2),
|
|
/* 140 S> */ B(Ldar), R(closure),
|
|
B(GetSuperConstructor), R(5),
|
|
B(LdaSmi), I8(1),
|
|
B(Star), R(6),
|
|
B(Ldar), R(0),
|
|
B(Mov), R(3), R(7),
|
|
/* 140 E> */ B(ConstructWithSpread), R(5), R(6), U8(2), U8(0),
|
|
B(Star), R(8),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(8), R(this),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 159 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args, 1); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 11
|
|
parameter count: 1
|
|
bytecode array length: 112
|
|
bytecodes: [
|
|
/* 128 E> */ B(StackCheck),
|
|
B(CreateRestParameter),
|
|
B(Star), R(3),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(3), R(2),
|
|
/* 140 S> */ B(Ldar), R(closure),
|
|
B(GetSuperConstructor), R(5),
|
|
B(CreateEmptyArrayLiteral), U8(0),
|
|
B(Star), R(7),
|
|
B(LdaZero),
|
|
B(Star), R(6),
|
|
B(LdaSmi), I8(1),
|
|
B(StaInArrayLiteral), R(7), R(6), U8(1),
|
|
B(Ldar), R(6),
|
|
B(Inc), U8(3),
|
|
/* 152 S> */ B(Star), R(6),
|
|
B(GetIterator), R(3), U8(4), U8(6),
|
|
B(Star), R(9),
|
|
B(LdaNamedProperty), R(9), U8(0), U8(8),
|
|
B(Star), R(8),
|
|
B(Mov), R(1), R(4),
|
|
B(CallProperty0), R(8), R(9), U8(14),
|
|
B(Star), R(10),
|
|
B(JumpIfJSReceiver), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(10), U8(1),
|
|
B(LdaNamedProperty), R(10), U8(1), U8(16),
|
|
B(JumpIfToBooleanTrue), U8(19),
|
|
B(LdaNamedProperty), R(10), U8(2), U8(10),
|
|
B(StaInArrayLiteral), R(7), R(6), U8(1),
|
|
B(Ldar), R(6),
|
|
B(Inc), U8(3),
|
|
B(Star), R(6),
|
|
B(JumpLoop), U8(33), I8(0),
|
|
B(LdaSmi), I8(1),
|
|
B(StaInArrayLiteral), R(7), R(6), U8(1),
|
|
B(Mov), R(5), R(6),
|
|
B(Mov), R(0), R(8),
|
|
/* 140 E> */ B(CallJSRuntime), U8(%reflect_construct), R(6), U8(3),
|
|
B(Star), R(9),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(9), R(this),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 162 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|