v8/test/mjsunit/es6/reflect-construct.js
vabr b478e9c11c Fix TypeError message for Reflect.construct
If the Reflect.construct receives an argument expected to be a constructor,
and the argument is not a constructor, V8 currently declares that
Reflect.construct is not a function. It should instead say that the offending
argument is not a constructor.

This is the case for all ports of builtins
(Builtins::Generate_ReflectConstruct). All of them make an
attempt to at least pass the right argument to the TypeError parametrised
message, calling out the offending Reflect.construct argument. However,
Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
discarding the precise information.

This CL adds Runtime::kNotConstructor, which reports the arguments passed
to it, and the CL also modifies the ports of builtins to make use of
Runtime::kNotConstructor

BUG=v8:5671

Review-Url: https://codereview.chromium.org/2688393003
Cr-Commit-Position: refs/heads/master@{#43182}
2017-02-14 11:21:34 +00:00

403 lines
13 KiB
JavaScript

// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Flags: --allow-unsafe-function-constructor
(function testReflectConstructArity() {
assertEquals(2, Reflect.construct.length);
})();
(function testReflectConstructNonConstructor() {
assertThrows(function() {
new Reflect.construct(function(){}, []);
}, TypeError);
})();
(function testReflectConstructArg1NonConstructor() {
try {
Reflect.construct(() => {}, []);
} catch (e) {
assertInstanceof(e, TypeError);
assertEquals("() => {} is not a constructor", e.message);
return;
}
assertUnreachable("Exception expected");
})();
(function testReflectConstructArg3NonConstructor() {
try {
Reflect.construct(function() {}, [], () => {});
} catch (e) {
assertInstanceof(e, TypeError);
assertEquals("() => {} is not a constructor", e.message);
return;
}
assertUnreachable("Exception expected");
})();
(function testReflectConstructBasic() {
function Constructor() { "use strict"; }
assertInstanceof(Reflect.construct(Constructor, []), Constructor);
})();
(function testReflectConstructBasicSloppy() {
function Constructor() {}
assertInstanceof(Reflect.construct(Constructor, []), Constructor);
})();
(function testReflectConstructReturnSomethingElseStrict() {
var R = {};
function Constructor() { "use strict"; return R; }
assertSame(R, Reflect.construct(Constructor, []));
})();
(function testReflectConstructReturnSomethingElseSloppy() {
var R = {};
function Constructor() { return R; }
assertSame(R, Reflect.construct(Constructor, []));
})();
(function testReflectConstructNewTargetStrict() {
"use strict";
function Constructor() { this[9] = 1; }
var O = Reflect.construct(Constructor, [], Array);
assertEquals(1, O[9]);
// Ordinary object with Array.prototype --- no exotic Array magic
assertFalse(Array.isArray(O));
assertEquals(0, O.length);
assertSame(Array.prototype, Object.getPrototypeOf(O));
})();
(function testReflectConstructNewTargetSloppy() {
function Constructor() { this[9] = 1; }
var O = Reflect.construct(Constructor, [], Array);
assertEquals(1, O[9]);
// Ordinary object with Array.prototype --- no exotic Array magic
assertFalse(Array.isArray(O));
assertEquals(0, O.length);
assertSame(Array.prototype, Object.getPrototypeOf(O));
})();
(function testReflectConstructNewTargetStrict2() {
"use strict";
function Constructor() { this[9] = 1; }
Constructor.prototype.add = function(x) {
this[this.length] = x; return this;
}
var O = Reflect.construct(Array, [1, 2, 3], Constructor);
// Exotic Array object with Constructor.prototype
assertTrue(Array.isArray(O));
assertSame(Constructor.prototype, Object.getPrototypeOf(O));
assertFalse(O instanceof Array);
assertEquals(3, O.length);
assertEquals(undefined, O[9]);
assertSame(O, O.add(4));
assertEquals(4, O.length);
assertEquals(4, O[3]);
})();
(function testReflectConstructNewTargetSloppy2() {
function Constructor() { this[9] = 1; }
Constructor.prototype.add = function(x) {
this[this.length] = x; return this;
}
var O = Reflect.construct(Array, [1, 2, 3], Constructor);
// Exotic Array object with Constructor.prototype
assertTrue(Array.isArray(O));
assertSame(Constructor.prototype, Object.getPrototypeOf(O));
assertFalse(O instanceof Array);
assertEquals(3, O.length);
assertEquals(undefined, O[9]);
assertSame(O, O.add(4));
assertEquals(4, O.length);
assertEquals(4, O[3]);
})();
(function testReflectConstructNewTargetStrict3() {
"use strict";
function A() {}
function B() {}
var O = Reflect.construct(A, [], B);
// TODO(caitp): bug: newTarget prototype is not used if it is not
// explicitly set.
//assertSame(B.prototype, Object.getPrototypeOf(O));
})();
(function testReflectConstructNewTargetSloppy3() {
function A() {}
function B() {}
var O = Reflect.construct(A, [], B);
// TODO(caitp): bug: newTarget prototype is not used if it is not
// explicitly set.
//assertSame(B.prototype, Object.getPrototypeOf(O));
})();
(function testAppliedArgumentsLength() {
function lengthStrict() { 'use strict'; this.a = arguments.length; }
function lengthSloppy() { this.a = arguments.length; }
assertEquals(0, Reflect.construct(lengthStrict, []).a);
assertEquals(0, Reflect.construct(lengthSloppy, []).a);
assertEquals(0, Reflect.construct(lengthStrict, {}).a);
assertEquals(0, Reflect.construct(lengthSloppy, {}).a);
for (var i = 0; i < 256; ++i) {
assertEquals(i, Reflect.construct(lengthStrict, new Array(i)).a);
assertEquals(i, Reflect.construct(lengthSloppy, new Array(i)).a);
assertEquals(i, Reflect.construct(lengthStrict, { length: i }).a);
assertEquals(i, Reflect.construct(lengthSloppy, { length: i }).a);
}
})();
(function testAppliedArgumentsLengthThrows() {
function noopStrict() { 'use strict'; }
function noopSloppy() { }
function MyError() {}
var argsList = {};
Object.defineProperty(argsList, "length", {
get: function() { throw new MyError(); }
});
assertThrows(function() {
Reflect.construct(noopStrict, argsList);
}, MyError);
assertThrows(function() {
Reflect.construct(noopSloppy, argsList);
}, MyError);
})();
(function testAppliedArgumentsElementThrows() {
function noopStrict() { 'use strict'; }
function noopSloppy() { }
function MyError() {}
var argsList = { length: 1 };
Object.defineProperty(argsList, "0", {
get: function() { throw new MyError(); }
});
assertThrows(function() {
Reflect.construct(noopStrict, argsList);
}, MyError);
assertThrows(function() {
Reflect.construct(noopSloppy, argsList);
}, MyError);
})();
(function testAppliedNonFunctionStrict() {
'use strict';
assertThrows(function() { Reflect.construct(void 0, []); }, TypeError);
assertThrows(function() { Reflect.construct(null, []); }, TypeError);
assertThrows(function() { Reflect.construct(123, []); }, TypeError);
assertThrows(function() { Reflect.construct("str", []); }, TypeError);
assertThrows(function() { Reflect.construct(Symbol("x"), []); }, TypeError);
assertThrows(function() { Reflect.construct(/123/, []); }, TypeError);
assertThrows(function() { Reflect.construct(NaN, []); }, TypeError);
assertThrows(function() { Reflect.construct({}, []); }, TypeError);
assertThrows(function() { Reflect.construct([], []); }, TypeError);
})();
(function testAppliedNonFunctionSloppy() {
assertThrows(function() { Reflect.construct(void 0, []); }, TypeError);
assertThrows(function() { Reflect.construct(null, []); }, TypeError);
assertThrows(function() { Reflect.construct(123, []); }, TypeError);
assertThrows(function() { Reflect.construct("str", []); }, TypeError);
assertThrows(function() { Reflect.construct(Symbol("x"), []); }, TypeError);
assertThrows(function() { Reflect.construct(/123/, []); }, TypeError);
assertThrows(function() { Reflect.construct(NaN, []); }, TypeError);
assertThrows(function() { Reflect.construct({}, []); }, TypeError);
assertThrows(function() { Reflect.construct([], []); }, TypeError);
})();
(function testAppliedArgumentsNonList() {
function noopStrict() { 'use strict'; }
function noopSloppy() {}
assertThrows(function() { Reflect.construct(noopStrict, null); }, TypeError);
assertThrows(function() { Reflect.construct(noopSloppy, null); }, TypeError);
assertThrows(function() { Reflect.construct(noopStrict, 1); }, TypeError);
assertThrows(function() { Reflect.construct(noopSloppy, 1); }, TypeError);
assertThrows(function() { Reflect.construct(noopStrict, "BAD"); }, TypeError);
assertThrows(function() { Reflect.construct(noopSloppy, "BAD"); }, TypeError);
assertThrows(function() { Reflect.construct(noopStrict, true); }, TypeError);
assertThrows(function() { Reflect.construct(noopSloppy, true); }, TypeError);
var sym = Symbol("x");
assertThrows(function() { Reflect.construct(noopStrict, sym); }, TypeError);
assertThrows(function() { Reflect.construct(noopSloppy, sym); }, TypeError);
})();
(function testAppliedArgumentValue() {
function firstStrict(a) { 'use strict'; this.a = a; }
function firstSloppy(a) { this.a = a; }
function lastStrict(a) {
'use strict'; this.a = arguments[arguments.length - 1]; }
function lastSloppy(a) { this.a = arguments[arguments.length - 1]; }
function sumStrict() {
'use strict';
var sum = arguments[0];
for (var i = 1; i < arguments.length; ++i) {
sum += arguments[i];
}
this.a = sum;
}
function sumSloppy() {
var sum = arguments[0];
for (var i = 1; i < arguments.length; ++i) {
sum += arguments[i];
}
this.a = sum;
}
assertEquals("OK!", Reflect.construct(firstStrict, ["OK!"]).a);
assertEquals("OK!", Reflect.construct(firstSloppy, ["OK!"]).a);
assertEquals("OK!", Reflect.construct(firstStrict,
{ 0: "OK!", length: 1 }).a);
assertEquals("OK!", Reflect.construct(firstSloppy,
{ 0: "OK!", length: 1 }).a);
assertEquals("OK!", Reflect.construct(lastStrict,
[0, 1, 2, 3, 4, 5, 6, 7, 8, "OK!"]).a);
assertEquals("OK!", Reflect.construct(lastSloppy,
[0, 1, 2, 3, 4, 5, 6, 7, 8, "OK!"]).a);
assertEquals("OK!", Reflect.construct(lastStrict,
{ 9: "OK!", length: 10 }).a);
assertEquals("OK!", Reflect.construct(lastSloppy,
{ 9: "OK!", length: 10 }).a);
assertEquals("TEST", Reflect.construct(sumStrict,
["T", "E", "S", "T"]).a);
assertEquals("TEST!!", Reflect.construct(sumStrict,
["T", "E", "S", "T", "!", "!"]).a);
assertEquals(10, Reflect.construct(sumStrict,
{ 0: 1, 1: 2, 2: 3, 3: 4, length: 4 }).a);
assertEquals("TEST", Reflect.construct(sumSloppy,
["T", "E", "S", "T"]).a);
assertEquals("TEST!!", Reflect.construct(sumSloppy,
["T", "E", "S", "T", "!", "!"]).a);
assertEquals(10, Reflect.construct(sumSloppy,
{ 0: 1, 1: 2, 2: 3, 3: 4, length: 4 }).a);
})();
(function() {
function* f() { yield 1; yield 2; }
function* g() { yield 3; yield 4; }
assertThrows(()=>Reflect.construct(f, [], g));
})();
(function () {
var realm1 = Realm.create();
var realm2 = Realm.create();
var well_known_intrinsic_constructors = [
"Array",
"ArrayBuffer",
"Boolean",
["DataView", [new ArrayBuffer()]],
"Date",
"Error",
"EvalError",
"Float32Array",
"Float64Array",
["Function", ["return 153;"]],
["Function", ["'use strict'; return 153;"]],
["Function", ["'use strong'; return 153;"]],
["((function*(){}).constructor)", ["yield 153;"]], // GeneratorFunction
["((function*(){}).constructor)", ["'use strict'; yield 153;"]],
["((function*(){}).constructor)", ["'use strong'; yield 153;"]],
"Int8Array",
"Int16Array",
"Int32Array",
"Map",
"Number",
"Object",
["Promise", [(resolve, reject)=>{}]],
"RangeError",
"ReferenceError",
"RegExp",
"Set",
"String",
"SyntaxError",
// %TypedArray%?
"TypeError",
"Uint8Array",
"Uint8ClampedArray",
"Uint16Array",
"Uint32Array",
"URIError",
"WeakMap",
"WeakSet"
];
function getname(v) {
return typeof v === "string" ? v : v[0];
}
function getargs(v) {
return typeof v === "string" ? [] : v[1];
}
function test_intrinsic_prototype(name) {
var own = Realm.eval(realm1, name);
// Ensure that constructor.prototype is non-writable, non-configurable.
var desc = Object.getOwnPropertyDescriptor(own, "prototype");
assertFalse(desc.configurable, name);
assertFalse(desc.writable, name);
}
for (var intrinsic of well_known_intrinsic_constructors) {
test_intrinsic_prototype(getname(intrinsic));
}
function function_with_non_instance_prototype(realm) {
var f = Realm.eval(realm, "(function(){})");
f.prototype = 1;
return f;
}
function test_intrinsic_default(realm, name, args, convert) {
var own = Realm.eval(realm1, name);
var other = Realm.eval(realm, name);
var o = Reflect.construct(
convert(own), args, function_with_non_instance_prototype(realm));
// Ensure the intrisicDefaultProto is fetched from the correct realm.
assertTrue(realm == realm1 || o.__proto__ !== own.prototype, [...arguments]);
assertTrue(o.__proto__ === other.prototype, [...arguments]);
}
function test_all(test, convert) {
for (var intrinsic of well_known_intrinsic_constructors) {
for (var realm of [realm1, realm2]) {
test(realm, getname(intrinsic), getargs(intrinsic), convert);
}
}
}
test_all(test_intrinsic_default, (v)=>v);
test_all(test_intrinsic_default,
(v)=>{ "use strict"; return class extends v {}});
})();