f668e9f7ae
This reverts commit 91f08378bc.
Reason for revert: It's a fairly big change, and the clusterfuzz
found some bugs. Will reland with the fix after M98 branch point.
Original change's description:
> [class] implement reparsing of class instance member initializers
>
> Previously, since the source code for the synthetic class instance
> member initializer function was recorded as the span from the first
> initializer to the last initializer, there was no way to reparse the
> class and recompile the initializer function. It was working for
> most use cases because the code for the initializer function was
> generated eagarly and it was usually alive as long as the class was
> alive, so the initializer wouldn't normally be lazily parsed. This
> didn't work, however, when the class was snapshotted with
> v8::SnapshotCreator::FunctionCodeHandling::kClear,
> becuase then we needed to recompile the initializer when the class
> was instantiated. This patch implements the reparsing so that
> these classes can work with FunctionCodeHandling::kClear.
>
> This patch refactors ParserBase::ParseClassLiteral() so that we can
> reuse it for both parsing the class body normally and reparsing it
> to collect initializers. When reparsing the synthetic initializer
> function, we rewind the scanner to the beginning of the class, and
> parse the class body to collect the initializers. During the
> reparsing, field initializers are parsed with the full parser while
> methods of the class are pre-parsed.
>
> A few notable changes:
>
> - Extended the source range of the initializer function to cover the
> entire class so that we can rewind the scanner to parse the class
> body to collect initializers (previously, it starts from the first
> field initializer and ends at the last initializer). This resulted
> some expectation changes in the debugger tests, though the
> initializers remain debuggable.
> - A temporary ClassScope is created during reparsing. After the class
> is reparsed, we use the information from the ScopeInfo to update
> the allocated indices of the variables in the ClassScope.
>
> Bug: v8:10704
> Change-Id: Ifb6431a1447d8844f2a548283d59158742fe9027
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988830
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Commit-Queue: Joyee Cheung <joyee@igalia.com>
> Cr-Commit-Position: refs/heads/main@{#78299}
Bug: v8:10704
Change-Id: I039cb728ebf0ada438a8f26c7d2c2547dbe3bf2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3325328
Auto-Submit: Joyee Cheung <joyee@igalia.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78315}
175 lines
4.9 KiB
JavaScript
175 lines
4.9 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --no-always-opt --harmony-public-fields
|
|
// Flags: --harmony-static-fields --no-stress-flush-code
|
|
// Files: test/mjsunit/code-coverage-utils.js
|
|
|
|
%DebugToggleBlockCoverage(true);
|
|
|
|
TestCoverage(
|
|
"class with no fields",
|
|
`
|
|
class X { // 000
|
|
}; // 050
|
|
`,
|
|
[{"start":0,"end":99,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"class that's not created",
|
|
`
|
|
class X { // 000
|
|
x = function() { } // 050
|
|
}; // 100
|
|
`,
|
|
[{"start":0,"end":149,"count":1},
|
|
{"start":52,"end":70,"count":0}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"class with field thats not called",
|
|
`
|
|
class X { // 000
|
|
x = function() { } // 050
|
|
}; // 100
|
|
let x = new X(); // 150
|
|
`,
|
|
[{"start":0,"end":199,"count":1},
|
|
{"start":52,"end":70,"count":1},
|
|
{"start":56,"end":70,"count":0}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"class field",
|
|
`
|
|
class X { // 000
|
|
x = function() { } // 050
|
|
}; // 100
|
|
let x = new X(); // 150
|
|
x.x(); // 200
|
|
`,
|
|
[{"start":0,"end":249,"count":1},
|
|
{"start":52,"end":70,"count":1},
|
|
{"start":56,"end":70,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"non contiguous class field",
|
|
`
|
|
class X { // 000
|
|
x = function() { } // 050
|
|
foo() { } // 100
|
|
y = function() {} // 150
|
|
}; // 200
|
|
let x = new X(); // 250
|
|
x.x(); // 300
|
|
x.y(); // 350
|
|
`,
|
|
[{"start":0,"end":399,"count":1},
|
|
{"start":52,"end":169,"count":1},
|
|
{"start":56,"end":70,"count":1},
|
|
{"start":102,"end":111,"count":0},
|
|
{"start":156,"end":169,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"non contiguous class field thats called",
|
|
`
|
|
class X { // 000
|
|
x = function() { } // 050
|
|
foo() { } // 100
|
|
y = function() {} // 150
|
|
}; // 200
|
|
let x = new X(); // 250
|
|
x.x(); // 300
|
|
x.y(); // 350
|
|
x.foo(); // 400
|
|
`,
|
|
[{"start":0,"end":449,"count":1},
|
|
{"start":52,"end":169,"count":1},
|
|
{"start":56,"end":70,"count":1},
|
|
{"start":102,"end":111,"count":1},
|
|
{"start":156,"end":169,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"class with initializer iife",
|
|
`
|
|
class X { // 000
|
|
x = (function() { })() // 050
|
|
}; // 100
|
|
let x = new X(); // 150
|
|
`,
|
|
[{"start":0,"end":199,"count":1},
|
|
{"start":52,"end":74,"count":1},
|
|
{"start":57,"end":71,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"class with computed field",
|
|
`
|
|
function f() {}; // 000
|
|
class X { // 050
|
|
[f()] = (function() { })() // 100
|
|
}; // 150
|
|
let x = new X(); // 200
|
|
`,
|
|
[{"start":0,"end":249,"count":1},
|
|
{"start":0,"end":15,"count":1},
|
|
{"start":102,"end":128,"count":1},
|
|
{"start":111,"end":125,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"static class field that's not called",
|
|
`
|
|
class X { // 000
|
|
static x = function() { } // 050
|
|
}; // 100
|
|
`,
|
|
[{"start":0,"end":149,"count":1},
|
|
{"start":52,"end":77,"count":1},
|
|
{"start":63,"end":77,"count":0}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"static class field",
|
|
`
|
|
class X { // 000
|
|
static x = function() { } // 050
|
|
}; // 100
|
|
X.x(); // 150
|
|
`,
|
|
[{"start":0,"end":199,"count":1},
|
|
{"start":52,"end":77,"count":1},
|
|
{"start":63,"end":77,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"static class field with iife",
|
|
`
|
|
class X { // 000
|
|
static x = (function() { })() // 050
|
|
}; // 100
|
|
`,
|
|
[{"start":0,"end":149,"count":1},
|
|
{"start":52,"end":81,"count":1},
|
|
{"start":64,"end":78,"count":1}]
|
|
);
|
|
|
|
TestCoverage(
|
|
"computed static class field",
|
|
`
|
|
function f() {} // 000
|
|
class X { // 050
|
|
static [f()] = (function() { })() // 100
|
|
}; // 150
|
|
`,
|
|
[{"start":0,"end":199,"count":1},
|
|
{"start":0,"end":15,"count":1},
|
|
{"start":102,"end":135,"count":1},
|
|
{"start":118,"end":132,"count":1}]
|
|
);
|