5f5a3282d4
Reason for revert: [Sheriff] Speculative revert. Suspect for gc stress crashes, like: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5119 Original issue's description: > Rehash and clear deleted entries in weak collections during GC > > Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity. > > BUG=v8:4909 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d > Cr-Commit-Position: refs/heads/master@{#35514} TBR=hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4909 Review URL: https://codereview.chromium.org/1891863003 Cr-Commit-Position: refs/heads/master@{#35519}
268 lines
9.7 KiB
C++
268 lines
9.7 KiB
C++
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include <utility>
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/global-handles.h"
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/heap/utils-inl.h"
|
|
|
|
using namespace v8::internal;
|
|
|
|
static Isolate* GetIsolateFrom(LocalContext* context) {
|
|
return reinterpret_cast<Isolate*>((*context)->GetIsolate());
|
|
}
|
|
|
|
|
|
static Handle<JSWeakMap> AllocateJSWeakMap(Isolate* isolate) {
|
|
Handle<JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
|
|
// Do not leak handles for the hash table, it would make entries strong.
|
|
{
|
|
HandleScope scope(isolate);
|
|
Handle<ObjectHashTable> table = ObjectHashTable::New(isolate, 1);
|
|
weakmap->set_table(*table);
|
|
}
|
|
return weakmap;
|
|
}
|
|
|
|
static int NumberOfWeakCalls = 0;
|
|
static void WeakPointerCallback(
|
|
const v8::WeakCallbackData<v8::Value, void>& data) {
|
|
std::pair<v8::Persistent<v8::Value>*, int>* p =
|
|
reinterpret_cast<std::pair<v8::Persistent<v8::Value>*, int>*>(
|
|
data.GetParameter());
|
|
CHECK_EQ(1234, p->second);
|
|
NumberOfWeakCalls++;
|
|
p->first->Reset();
|
|
}
|
|
|
|
|
|
TEST(Weakness) {
|
|
FLAG_incremental_marking = false;
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSWeakMap> weakmap = AllocateJSWeakMap(isolate);
|
|
GlobalHandles* global_handles = isolate->global_handles();
|
|
|
|
// Keep global reference to the key.
|
|
Handle<Object> key;
|
|
{
|
|
HandleScope scope(isolate);
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
key = global_handles->Create(*object);
|
|
}
|
|
CHECK(!global_handles->IsWeak(key.location()));
|
|
|
|
// Put two chained entries into weak map.
|
|
{
|
|
HandleScope scope(isolate);
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
Handle<Smi> smi(Smi::FromInt(23), isolate);
|
|
int32_t hash = Object::GetOrCreateHash(isolate, key)->value();
|
|
JSWeakCollection::Set(weakmap, key, object, hash);
|
|
int32_t object_hash = Object::GetOrCreateHash(isolate, object)->value();
|
|
JSWeakCollection::Set(weakmap, object, smi, object_hash);
|
|
}
|
|
CHECK_EQ(2, ObjectHashTable::cast(weakmap->table())->NumberOfElements());
|
|
|
|
// Force a full GC.
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(0, NumberOfWeakCalls);
|
|
CHECK_EQ(2, ObjectHashTable::cast(weakmap->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
0, ObjectHashTable::cast(weakmap->table())->NumberOfDeletedElements());
|
|
|
|
// Make the global reference to the key weak.
|
|
{
|
|
HandleScope scope(isolate);
|
|
std::pair<Handle<Object>*, int> handle_and_id(&key, 1234);
|
|
GlobalHandles::MakeWeak(key.location(),
|
|
reinterpret_cast<void*>(&handle_and_id),
|
|
&WeakPointerCallback);
|
|
}
|
|
CHECK(global_handles->IsWeak(key.location()));
|
|
|
|
// Force a full GC.
|
|
// Perform two consecutive GCs because the first one will only clear
|
|
// weak references whereas the second one will also clear weak maps.
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(1, NumberOfWeakCalls);
|
|
CHECK_EQ(2, ObjectHashTable::cast(weakmap->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
0, ObjectHashTable::cast(weakmap->table())->NumberOfDeletedElements());
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(1, NumberOfWeakCalls);
|
|
CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())->NumberOfElements());
|
|
CHECK_EQ(2,
|
|
ObjectHashTable::cast(weakmap->table())->NumberOfDeletedElements());
|
|
}
|
|
|
|
|
|
TEST(Shrinking) {
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSWeakMap> weakmap = AllocateJSWeakMap(isolate);
|
|
|
|
// Check initial capacity.
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())->Capacity());
|
|
|
|
// Fill up weak map to trigger capacity change.
|
|
{
|
|
HandleScope scope(isolate);
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
for (int i = 0; i < 32; i++) {
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
Handle<Smi> smi(Smi::FromInt(i), isolate);
|
|
int32_t object_hash = Object::GetOrCreateHash(isolate, object)->value();
|
|
JSWeakCollection::Set(weakmap, object, smi, object_hash);
|
|
}
|
|
}
|
|
|
|
// Check increased capacity.
|
|
CHECK_EQ(128, ObjectHashTable::cast(weakmap->table())->Capacity());
|
|
|
|
// Force a full GC.
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
0, ObjectHashTable::cast(weakmap->table())->NumberOfDeletedElements());
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(0, ObjectHashTable::cast(weakmap->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
32, ObjectHashTable::cast(weakmap->table())->NumberOfDeletedElements());
|
|
|
|
// Check shrunk capacity.
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakmap->table())->Capacity());
|
|
}
|
|
|
|
|
|
// Test that weak map values on an evacuation candidate which are not reachable
|
|
// by other paths are correctly recorded in the slots buffer.
|
|
TEST(Regress2060a) {
|
|
if (i::FLAG_never_compact) return;
|
|
FLAG_always_compact = true;
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSFunction> function = factory->NewFunction(
|
|
factory->function_string());
|
|
Handle<JSObject> key = factory->NewJSObject(function);
|
|
Handle<JSWeakMap> weakmap = AllocateJSWeakMap(isolate);
|
|
|
|
// Start second old-space page so that values land on evacuation candidate.
|
|
Page* first_page = heap->old_space()->anchor()->next_page();
|
|
SimulateFullSpace(heap->old_space());
|
|
|
|
// Fill up weak map with values on an evacuation candidate.
|
|
{
|
|
HandleScope scope(isolate);
|
|
for (int i = 0; i < 32; i++) {
|
|
Handle<JSObject> object = factory->NewJSObject(function, TENURED);
|
|
CHECK(!heap->InNewSpace(*object));
|
|
CHECK(!first_page->Contains(object->address()));
|
|
int32_t hash = Object::GetOrCreateHash(isolate, key)->value();
|
|
JSWeakCollection::Set(weakmap, key, object, hash);
|
|
}
|
|
}
|
|
|
|
// Force compacting garbage collection.
|
|
CHECK(FLAG_always_compact);
|
|
heap->CollectAllGarbage();
|
|
}
|
|
|
|
|
|
// Test that weak map keys on an evacuation candidate which are reachable by
|
|
// other strong paths are correctly recorded in the slots buffer.
|
|
TEST(Regress2060b) {
|
|
if (i::FLAG_never_compact) return;
|
|
FLAG_always_compact = true;
|
|
#ifdef VERIFY_HEAP
|
|
FLAG_verify_heap = true;
|
|
#endif
|
|
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSFunction> function = factory->NewFunction(
|
|
factory->function_string());
|
|
|
|
// Start second old-space page so that keys land on evacuation candidate.
|
|
Page* first_page = heap->old_space()->anchor()->next_page();
|
|
SimulateFullSpace(heap->old_space());
|
|
|
|
// Fill up weak map with keys on an evacuation candidate.
|
|
Handle<JSObject> keys[32];
|
|
for (int i = 0; i < 32; i++) {
|
|
keys[i] = factory->NewJSObject(function, TENURED);
|
|
CHECK(!heap->InNewSpace(*keys[i]));
|
|
CHECK(!first_page->Contains(keys[i]->address()));
|
|
}
|
|
Handle<JSWeakMap> weakmap = AllocateJSWeakMap(isolate);
|
|
for (int i = 0; i < 32; i++) {
|
|
Handle<Smi> smi(Smi::FromInt(i), isolate);
|
|
int32_t hash = Object::GetOrCreateHash(isolate, keys[i])->value();
|
|
JSWeakCollection::Set(weakmap, keys[i], smi, hash);
|
|
}
|
|
|
|
// Force compacting garbage collection. The subsequent collections are used
|
|
// to verify that key references were actually updated.
|
|
CHECK(FLAG_always_compact);
|
|
heap->CollectAllGarbage();
|
|
heap->CollectAllGarbage();
|
|
heap->CollectAllGarbage();
|
|
}
|
|
|
|
|
|
TEST(Regress399527) {
|
|
CcTest::InitializeVM();
|
|
v8::HandleScope scope(CcTest::isolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Heap* heap = isolate->heap();
|
|
{
|
|
HandleScope scope(isolate);
|
|
AllocateJSWeakMap(isolate);
|
|
SimulateIncrementalMarking(heap);
|
|
}
|
|
// The weak map is marked black here but leaving the handle scope will make
|
|
// the object unreachable. Aborting incremental marking will clear all the
|
|
// marking bits which makes the weak map garbage.
|
|
heap->CollectAllGarbage();
|
|
}
|