Go to file
yurys@chromium.org 69c2f54d32 Skip samples where top function's stack frame is not setup properly
Stack iterator takes return address based on the frame pointer (ebp) and detects JS frames based on value at fp + StandardFrameConstants::kMarkerOffset. So in order the iterator to work correctly this values should be already setup for the current function. Stack frame is constructed at the very beginning of JS function code and destroyed before return. If sample is taken before before the frame construction is completed or after it was destroyed the stack iterator will wrongly think that FP points at the current functions frame base and will skip callers frame. To avoid this we mark code ranges where  stack frame doesn't exist and completely ignore such samples.

This fixes cctest/test-cpu-profiler/CollectCpuProfile flakiness.

BUG=v8:2628
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14253015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14670 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-14 22:51:33 +00:00
benchmarks More fixes for V8 benchmark version 7. 2012-03-15 17:13:50 +00:00
build Fix ugly typo in r14391. 2013-04-23 10:52:40 +00:00
include Don't use anonymous types declared in an anonymous union. 2013-05-14 12:04:04 +00:00
preparser Remove SCons related files 2013-04-18 11:01:14 +00:00
samples fix nosnapshot test failure in 14793004, do not deprecate function 2013-05-08 07:45:16 +00:00
src Skip samples where top function's stack frame is not setup properly 2013-05-14 22:51:33 +00:00
test Skip samples where top function's stack frame is not setup properly 2013-05-14 22:51:33 +00:00
tools Prevent grokdump from crying about invalid input. 2013-05-07 13:24:04 +00:00
.gitignore Refactor HCheckMaps to have a private constructor, removing duplicated code and simplifying calls in clients. 2013-04-19 16:46:13 +00:00
AUTHORS Add methods to allow resuming execution after calling TerminateExecution(). 2013-04-22 15:01:45 +00:00
ChangeLog Prepare push to trunk. Now working on version 3.19.2. 2013-05-14 08:13:25 +00:00
DEPS Pull more recent gyp. 2012-09-26 09:12:45 +00:00
LICENSE Update LICENSE file 2012-01-03 16:38:42 +00:00
LICENSE.strongtalk Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.v8 Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.valgrind Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
Makefile Enable Native Client build of V8. 2013-04-17 08:27:40 +00:00
Makefile.android MIPS: Add android build support for mips in gyp. 2013-02-25 16:39:03 +00:00
Makefile.nacl A new Makefile for the Native Client V8 builds. 2013-04-09 08:25:41 +00:00
OWNERS Added Hannes and Dmitry to OWNERS 2013-03-21 12:09:53 +00:00
PRESUBMIT.py Run style checks also when uploading. 2013-04-11 12:41:31 +00:00