AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
69fda08a80
v8/test/cctest/interpreter
History
Tobias Tebbi 4671cb5644 Revert "Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]()" 
This reverts commit 91e3243d60.

Reason for revert: This deopts to the wrong point.

Original change's description:
> Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]()
> 
> Current GetIterator bytecode loads and calls @@iterator property on a
> given object. This change extends the bytecode functionality to check
> whether the value returned after calling @@iterator property is a valid
> JSReceiver. The bytecode throws SymbolIteratorInvalid exception if the
> returned value is not a valid JSReceiver. This change absorbs the
> functionality of additional two bytecodes - JumpIfJSReceiver and
> CallRuntime, that are part of the iterator protocol in the GetIterator
> bytecode.
> 
> Bug: v8:9489
> Change-Id: I9e84cfe85eeb9a1b8a97ca0595375ac26ba1bbfd
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792905
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com>
> Cr-Commit-Position: refs/heads/master@{#63704}

TBR=rmcilroy@chromium.org,leszeks@chromium.org,tebbi@chromium.org,swapnilgaikwad@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:9489
Change-Id: I9324b5b01ead29912ad793a1e7b4d009643d7901
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960288
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65541}
2019-12-20 14:56:02 +00:00
..
bytecode_expectations Revert "Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]()" 2019-12-20 14:56:02 +00:00
bytecode-expectations-printer.cc [torque] Use generated instance types, part 1 2019-10-28 18:30:31 +00:00
bytecode-expectations-printer.h [cleanup] Eliminate non-const reference parameters 2019-09-10 09:31:07 +00:00
generate-bytecode-expectations.cc [top-level-await] Add support for parsing top level await 2019-09-24 14:01:32 +00:00
interpreter-tester.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
interpreter-tester.h Move remaining files in src/ 2019-05-24 18:24:36 +00:00
source-position-matcher.cc Move more relevant files to src/objects 2019-05-23 08:52:30 +00:00
source-position-matcher.h Move remaining files in src/ 2019-05-24 18:24:36 +00:00
test-bytecode-generator.cc [class] implement inspector support for private instance methods 2019-12-04 20:13:34 +00:00
test-interpreter-intrinsics.cc Move remaining files in src/ 2019-05-24 18:24:36 +00:00
test-interpreter.cc [cleanup] Refactor Smi::kZero to Smi::zero() 2019-11-15 11:26:48 +00:00
test-source-positions.cc Move remaining files in src/ 2019-05-24 18:24:36 +00:00