1a511b0e38
Reason for revert: All build problems had other causes. Original issue's description: > Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #3 id:40001 of https://codereview.chromium.org/1171943002/) > > Reason for revert: > might break stuff > > Original issue's description: > > [test] Refactoring - Use subject/observer pattern for progress indicators. > > > > This should prevent bugs caused by missing super calls in > > overridden methods. The assumption is that methods of > > different indicators are independent. > > > > Committed: https://crrev.com/fbe973ff1722a6158a5b2babce9c1a32d26a1d3b > > Cr-Commit-Position: refs/heads/master@{#28866} > > TBR=jkummerow@chromium.org,tandrii@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/2a3962d9d2a7415378811f4d56522531332d5a3e > Cr-Commit-Position: refs/heads/master@{#28869} TBR=jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1176863002 Cr-Commit-Position: refs/heads/master@{#28901}
382 lines
12 KiB
Python
382 lines
12 KiB
Python
# Copyright 2012 the V8 project authors. All rights reserved.
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above
|
|
# copyright notice, this list of conditions and the following
|
|
# disclaimer in the documentation and/or other materials provided
|
|
# with the distribution.
|
|
# * Neither the name of Google Inc. nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
from functools import wraps
|
|
import json
|
|
import os
|
|
import sys
|
|
import time
|
|
|
|
from . import junit_output
|
|
|
|
|
|
ABS_PATH_PREFIX = os.getcwd() + os.sep
|
|
|
|
|
|
def EscapeCommand(command):
|
|
parts = []
|
|
for part in command:
|
|
if ' ' in part:
|
|
# Escape spaces. We may need to escape more characters for this
|
|
# to work properly.
|
|
parts.append('"%s"' % part)
|
|
else:
|
|
parts.append(part)
|
|
return " ".join(parts)
|
|
|
|
|
|
class ProgressIndicator(object):
|
|
|
|
def __init__(self):
|
|
self.runner = None
|
|
|
|
def SetRunner(self, runner):
|
|
self.runner = runner
|
|
|
|
def Starting(self):
|
|
pass
|
|
|
|
def Done(self):
|
|
pass
|
|
|
|
def AboutToRun(self, test):
|
|
pass
|
|
|
|
def HasRun(self, test, has_unexpected_output):
|
|
pass
|
|
|
|
def Heartbeat(self):
|
|
pass
|
|
|
|
def PrintFailureHeader(self, test):
|
|
if test.suite.IsNegativeTest(test):
|
|
negative_marker = '[negative] '
|
|
else:
|
|
negative_marker = ''
|
|
print "=== %(label)s %(negative)s===" % {
|
|
'label': test.GetLabel(),
|
|
'negative': negative_marker
|
|
}
|
|
|
|
|
|
class IndicatorNotifier(object):
|
|
"""Holds a list of progress indicators and notifies them all on events."""
|
|
def __init__(self):
|
|
self.indicators = []
|
|
|
|
def Register(self, indicator):
|
|
self.indicators.append(indicator)
|
|
|
|
|
|
# Forge all generic event-dispatching methods in IndicatorNotifier, which are
|
|
# part of the ProgressIndicator interface.
|
|
for func_name in ProgressIndicator.__dict__:
|
|
func = getattr(ProgressIndicator, func_name)
|
|
if callable(func) and not func.__name__.startswith('_'):
|
|
def wrap_functor(f):
|
|
@wraps(f)
|
|
def functor(self, *args, **kwargs):
|
|
"""Generic event dispatcher."""
|
|
for indicator in self.indicators:
|
|
getattr(indicator, f.__name__)(*args, **kwargs)
|
|
return functor
|
|
setattr(IndicatorNotifier, func_name, wrap_functor(func))
|
|
|
|
|
|
class SimpleProgressIndicator(ProgressIndicator):
|
|
"""Abstract base class for {Verbose,Dots}ProgressIndicator"""
|
|
|
|
def Starting(self):
|
|
print 'Running %i tests' % self.runner.total
|
|
|
|
def Done(self):
|
|
print
|
|
for failed in self.runner.failed:
|
|
self.PrintFailureHeader(failed)
|
|
if failed.output.stderr:
|
|
print "--- stderr ---"
|
|
print failed.output.stderr.strip()
|
|
if failed.output.stdout:
|
|
print "--- stdout ---"
|
|
print failed.output.stdout.strip()
|
|
print "Command: %s" % EscapeCommand(self.runner.GetCommand(failed))
|
|
if failed.output.HasCrashed():
|
|
print "exit code: %d" % failed.output.exit_code
|
|
print "--- CRASHED ---"
|
|
if failed.output.HasTimedOut():
|
|
print "--- TIMEOUT ---"
|
|
if len(self.runner.failed) == 0:
|
|
print "==="
|
|
print "=== All tests succeeded"
|
|
print "==="
|
|
else:
|
|
print
|
|
print "==="
|
|
print "=== %i tests failed" % len(self.runner.failed)
|
|
if self.runner.crashed > 0:
|
|
print "=== %i tests CRASHED" % self.runner.crashed
|
|
print "==="
|
|
|
|
|
|
class VerboseProgressIndicator(SimpleProgressIndicator):
|
|
|
|
def AboutToRun(self, test):
|
|
print 'Starting %s...' % test.GetLabel()
|
|
sys.stdout.flush()
|
|
|
|
def HasRun(self, test, has_unexpected_output):
|
|
if has_unexpected_output:
|
|
if test.output.HasCrashed():
|
|
outcome = 'CRASH'
|
|
else:
|
|
outcome = 'FAIL'
|
|
else:
|
|
outcome = 'pass'
|
|
print 'Done running %s: %s' % (test.GetLabel(), outcome)
|
|
sys.stdout.flush()
|
|
|
|
def Heartbeat(self):
|
|
print 'Still working...'
|
|
sys.stdout.flush()
|
|
|
|
|
|
class DotsProgressIndicator(SimpleProgressIndicator):
|
|
|
|
def HasRun(self, test, has_unexpected_output):
|
|
total = self.runner.succeeded + len(self.runner.failed)
|
|
if (total > 1) and (total % 50 == 1):
|
|
sys.stdout.write('\n')
|
|
if has_unexpected_output:
|
|
if test.output.HasCrashed():
|
|
sys.stdout.write('C')
|
|
sys.stdout.flush()
|
|
elif test.output.HasTimedOut():
|
|
sys.stdout.write('T')
|
|
sys.stdout.flush()
|
|
else:
|
|
sys.stdout.write('F')
|
|
sys.stdout.flush()
|
|
else:
|
|
sys.stdout.write('.')
|
|
sys.stdout.flush()
|
|
|
|
|
|
class CompactProgressIndicator(ProgressIndicator):
|
|
"""Abstract base class for {Color,Monochrome}ProgressIndicator"""
|
|
|
|
def __init__(self, templates):
|
|
super(CompactProgressIndicator, self).__init__()
|
|
self.templates = templates
|
|
self.last_status_length = 0
|
|
self.start_time = time.time()
|
|
|
|
def Done(self):
|
|
self.PrintProgress('Done')
|
|
print "" # Line break.
|
|
|
|
def AboutToRun(self, test):
|
|
self.PrintProgress(test.GetLabel())
|
|
|
|
def HasRun(self, test, has_unexpected_output):
|
|
if has_unexpected_output:
|
|
self.ClearLine(self.last_status_length)
|
|
self.PrintFailureHeader(test)
|
|
stdout = test.output.stdout.strip()
|
|
if len(stdout):
|
|
print self.templates['stdout'] % stdout
|
|
stderr = test.output.stderr.strip()
|
|
if len(stderr):
|
|
print self.templates['stderr'] % stderr
|
|
print "Command: %s" % EscapeCommand(self.runner.GetCommand(test))
|
|
if test.output.HasCrashed():
|
|
print "exit code: %d" % test.output.exit_code
|
|
print "--- CRASHED ---"
|
|
if test.output.HasTimedOut():
|
|
print "--- TIMEOUT ---"
|
|
|
|
def Truncate(self, string, length):
|
|
if length and (len(string) > (length - 3)):
|
|
return string[:(length - 3)] + "..."
|
|
else:
|
|
return string
|
|
|
|
def PrintProgress(self, name):
|
|
self.ClearLine(self.last_status_length)
|
|
elapsed = time.time() - self.start_time
|
|
progress = 0 if not self.runner.total else (
|
|
((self.runner.total - self.runner.remaining) * 100) //
|
|
self.runner.total)
|
|
status = self.templates['status_line'] % {
|
|
'passed': self.runner.succeeded,
|
|
'progress': progress,
|
|
'failed': len(self.runner.failed),
|
|
'test': name,
|
|
'mins': int(elapsed) / 60,
|
|
'secs': int(elapsed) % 60
|
|
}
|
|
status = self.Truncate(status, 78)
|
|
self.last_status_length = len(status)
|
|
print status,
|
|
sys.stdout.flush()
|
|
|
|
|
|
class ColorProgressIndicator(CompactProgressIndicator):
|
|
|
|
def __init__(self):
|
|
templates = {
|
|
'status_line': ("[%(mins)02i:%(secs)02i|"
|
|
"\033[34m%%%(progress) 4d\033[0m|"
|
|
"\033[32m+%(passed) 4d\033[0m|"
|
|
"\033[31m-%(failed) 4d\033[0m]: %(test)s"),
|
|
'stdout': "\033[1m%s\033[0m",
|
|
'stderr': "\033[31m%s\033[0m",
|
|
}
|
|
super(ColorProgressIndicator, self).__init__(templates)
|
|
|
|
def ClearLine(self, last_line_length):
|
|
print "\033[1K\r",
|
|
|
|
|
|
class MonochromeProgressIndicator(CompactProgressIndicator):
|
|
|
|
def __init__(self):
|
|
templates = {
|
|
'status_line': ("[%(mins)02i:%(secs)02i|%%%(progress) 4d|"
|
|
"+%(passed) 4d|-%(failed) 4d]: %(test)s"),
|
|
'stdout': '%s',
|
|
'stderr': '%s',
|
|
}
|
|
super(MonochromeProgressIndicator, self).__init__(templates)
|
|
|
|
def ClearLine(self, last_line_length):
|
|
print ("\r" + (" " * last_line_length) + "\r"),
|
|
|
|
|
|
class JUnitTestProgressIndicator(ProgressIndicator):
|
|
|
|
def __init__(self, junitout, junittestsuite):
|
|
self.outputter = junit_output.JUnitTestOutput(junittestsuite)
|
|
if junitout:
|
|
self.outfile = open(junitout, "w")
|
|
else:
|
|
self.outfile = sys.stdout
|
|
|
|
def Done(self):
|
|
self.outputter.FinishAndWrite(self.outfile)
|
|
if self.outfile != sys.stdout:
|
|
self.outfile.close()
|
|
|
|
def HasRun(self, test, has_unexpected_output):
|
|
fail_text = ""
|
|
if has_unexpected_output:
|
|
stdout = test.output.stdout.strip()
|
|
if len(stdout):
|
|
fail_text += "stdout:\n%s\n" % stdout
|
|
stderr = test.output.stderr.strip()
|
|
if len(stderr):
|
|
fail_text += "stderr:\n%s\n" % stderr
|
|
fail_text += "Command: %s" % EscapeCommand(self.runner.GetCommand(test))
|
|
if test.output.HasCrashed():
|
|
fail_text += "exit code: %d\n--- CRASHED ---" % test.output.exit_code
|
|
if test.output.HasTimedOut():
|
|
fail_text += "--- TIMEOUT ---"
|
|
self.outputter.HasRunTest(
|
|
[test.GetLabel()] + self.runner.context.mode_flags + test.flags,
|
|
test.duration,
|
|
fail_text)
|
|
|
|
|
|
class JsonTestProgressIndicator(ProgressIndicator):
|
|
|
|
def __init__(self, json_test_results, arch, mode):
|
|
self.json_test_results = json_test_results
|
|
self.arch = arch
|
|
self.mode = mode
|
|
self.results = []
|
|
self.tests = []
|
|
|
|
def Done(self):
|
|
complete_results = []
|
|
if os.path.exists(self.json_test_results):
|
|
with open(self.json_test_results, "r") as f:
|
|
# Buildbot might start out with an empty file.
|
|
complete_results = json.loads(f.read() or "[]")
|
|
|
|
# Sort tests by duration.
|
|
timed_tests = [t for t in self.tests if t.duration is not None]
|
|
timed_tests.sort(lambda a, b: cmp(b.duration, a.duration))
|
|
slowest_tests = [
|
|
{
|
|
"name": test.GetLabel(),
|
|
"flags": test.flags,
|
|
"command": EscapeCommand(self.runner.GetCommand(test)).replace(
|
|
ABS_PATH_PREFIX, ""),
|
|
"duration": test.duration,
|
|
} for test in timed_tests[:20]
|
|
]
|
|
|
|
complete_results.append({
|
|
"arch": self.arch,
|
|
"mode": self.mode,
|
|
"results": self.results,
|
|
"slowest_tests": slowest_tests,
|
|
})
|
|
|
|
with open(self.json_test_results, "w") as f:
|
|
f.write(json.dumps(complete_results))
|
|
|
|
def HasRun(self, test, has_unexpected_output):
|
|
# Buffer all tests for sorting the durations in the end.
|
|
self.tests.append(test)
|
|
if not has_unexpected_output:
|
|
# Omit tests that run as expected. Passing tests of reruns after failures
|
|
# will have unexpected_output to be reported here has well.
|
|
return
|
|
|
|
self.results.append({
|
|
"name": test.GetLabel(),
|
|
"flags": test.flags,
|
|
"command": EscapeCommand(self.runner.GetCommand(test)).replace(
|
|
ABS_PATH_PREFIX, ""),
|
|
"run": test.run,
|
|
"stdout": test.output.stdout,
|
|
"stderr": test.output.stderr,
|
|
"exit_code": test.output.exit_code,
|
|
"result": test.suite.GetOutcome(test),
|
|
"expected": list(test.outcomes or ["PASS"]),
|
|
"duration": test.duration,
|
|
})
|
|
|
|
|
|
PROGRESS_INDICATORS = {
|
|
'verbose': VerboseProgressIndicator,
|
|
'dots': DotsProgressIndicator,
|
|
'color': ColorProgressIndicator,
|
|
'mono': MonochromeProgressIndicator
|
|
}
|