6a1a3a101e
This CL adds tracing scopes for the various cppgc classes. Scopes use TRACE_EVENT_BEGIN and TRACE_EVENT_END macros to report trace events. To do so they need to include trace-event.h. For unified heap builds, trace-event.h forwards to v8's src/tracing/trace-event.h. For other builds, trace-event.h provides a subset of src/tracing/trace-event.h that covers just the parts used by cppgc. This CL covers what we need for traces and blink gc metrics (up to renaming events from BlinkGC.* to CppGC.*). UMA and UKM are not yet handled. Bug: chromium:1056170 Change-Id: Id92e84b27259ff0aadae7692f3d79d30896fb8e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540548 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71284}
96 lines
3.9 KiB
C++
96 lines
3.9 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/heap/cppgc/incremental-marking-schedule.h"
|
|
|
|
#include "src/base/platform/time.h"
|
|
#include "src/heap/cppgc/globals.h"
|
|
#include "src/heap/cppgc/stats-collector.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace cppgc {
|
|
namespace internal {
|
|
|
|
namespace {
|
|
|
|
class IncrementalMarkingScheduleTest : public ::testing::Test {
|
|
public:
|
|
static const size_t kObjectSize;
|
|
};
|
|
|
|
const size_t IncrementalMarkingScheduleTest::kObjectSize =
|
|
100 * IncrementalMarkingSchedule::kMinimumMarkedBytesPerIncrementalStep;
|
|
|
|
} // namespace
|
|
|
|
TEST_F(IncrementalMarkingScheduleTest, FirstStepReturnsDefaultDuration) {
|
|
IncrementalMarkingSchedule schedule;
|
|
schedule.NotifyIncrementalMarkingStart();
|
|
schedule.SetElapsedTimeForTesting(0);
|
|
EXPECT_EQ(IncrementalMarkingSchedule::kMinimumMarkedBytesPerIncrementalStep,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
}
|
|
|
|
// If marking is not behind schedule and very small time passed between steps
|
|
// the oracle should return the minimum step duration.
|
|
TEST_F(IncrementalMarkingScheduleTest, NoTimePassedReturnsMinimumDuration) {
|
|
IncrementalMarkingSchedule schedule;
|
|
schedule.NotifyIncrementalMarkingStart();
|
|
// Add incrementally marked bytes to tell oracle this is not the first step.
|
|
schedule.UpdateIncrementalMarkedBytes(
|
|
IncrementalMarkingSchedule::kMinimumMarkedBytesPerIncrementalStep);
|
|
schedule.SetElapsedTimeForTesting(0);
|
|
EXPECT_EQ(IncrementalMarkingSchedule::kMinimumMarkedBytesPerIncrementalStep,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
}
|
|
|
|
TEST_F(IncrementalMarkingScheduleTest, OracleDoesntExccedMaximumStepDuration) {
|
|
IncrementalMarkingSchedule schedule;
|
|
schedule.NotifyIncrementalMarkingStart();
|
|
// Add incrementally marked bytes to tell oracle this is not the first step.
|
|
static constexpr size_t kMarkedBytes = 1;
|
|
schedule.UpdateIncrementalMarkedBytes(kMarkedBytes);
|
|
schedule.SetElapsedTimeForTesting(
|
|
IncrementalMarkingSchedule::kEstimatedMarkingTimeMs);
|
|
EXPECT_EQ(kObjectSize - kMarkedBytes,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
}
|
|
|
|
TEST_F(IncrementalMarkingScheduleTest, AheadOfScheduleReturnsMinimumDuration) {
|
|
IncrementalMarkingSchedule schedule;
|
|
schedule.NotifyIncrementalMarkingStart();
|
|
// Add incrementally marked bytes to tell oracle this is not the first step.
|
|
schedule.UpdateIncrementalMarkedBytes(
|
|
IncrementalMarkingSchedule::kMinimumMarkedBytesPerIncrementalStep);
|
|
schedule.AddConcurrentlyMarkedBytes(0.6 * kObjectSize);
|
|
schedule.SetElapsedTimeForTesting(
|
|
0.5 * IncrementalMarkingSchedule::kEstimatedMarkingTimeMs);
|
|
EXPECT_EQ(IncrementalMarkingSchedule::kMinimumMarkedBytesPerIncrementalStep,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
}
|
|
|
|
TEST_F(IncrementalMarkingScheduleTest, BehindScheduleReturnsCorrectDuration) {
|
|
IncrementalMarkingSchedule schedule;
|
|
schedule.NotifyIncrementalMarkingStart();
|
|
schedule.UpdateIncrementalMarkedBytes(0.1 * kObjectSize);
|
|
schedule.AddConcurrentlyMarkedBytes(0.25 * kObjectSize);
|
|
schedule.SetElapsedTimeForTesting(
|
|
0.5 * IncrementalMarkingSchedule::kEstimatedMarkingTimeMs);
|
|
EXPECT_EQ(0.15 * kObjectSize,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
schedule.AddConcurrentlyMarkedBytes(0.05 * kObjectSize);
|
|
schedule.SetElapsedTimeForTesting(
|
|
0.5 * IncrementalMarkingSchedule::kEstimatedMarkingTimeMs);
|
|
EXPECT_EQ(0.1 * kObjectSize,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
schedule.AddConcurrentlyMarkedBytes(0.05 * kObjectSize);
|
|
schedule.SetElapsedTimeForTesting(
|
|
0.5 * IncrementalMarkingSchedule::kEstimatedMarkingTimeMs);
|
|
EXPECT_EQ(0.05 * kObjectSize,
|
|
schedule.GetNextIncrementalStepDuration(kObjectSize));
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace cppgc
|