2da7a9b110
There remained a few of regressions and we didn't see any significant improvement in the real world with this turned on. This CL reverts all the StringConcat bytecode work which landed. BUG=v8:6243 Change-Id: I832eb72e880ad41411dbec8fe29f71ef0f2025c8 Reviewed-on: https://chromium-review.googlesource.com/575130 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46769}
38 lines
853 B
JavaScript
38 lines
853 B
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
var foo = 'foo';
|
|
var bar = 'bar';
|
|
|
|
var a;
|
|
var b;
|
|
var c;
|
|
var d;
|
|
|
|
function baz() { return 'baz'; }
|
|
|
|
function test(arg) {
|
|
// All add operations are constant folded by native context
|
|
// specialization / inlining.
|
|
a = '"' + foo + '-' + bar + '"';
|
|
b = '"' + foo + '-' + baz() + '"';
|
|
|
|
// Reduce down to a JSAdd of folded constant + arg.
|
|
c = foo + bar + arg;
|
|
|
|
// Reduces to two JSAdds with other arguments constant folded.
|
|
d = '"' + foo + arg + bar + '"';
|
|
}
|
|
|
|
test('boo');
|
|
%OptimizeFunctionOnNextCall(test);
|
|
test('baa');
|
|
|
|
assertEquals('"foo-bar"', a);
|
|
assertEquals('"foo-baz"', b);
|
|
assertEquals('foobarbaa', c);
|
|
assertEquals('"foobaabar"', d);
|