e0b18b9022
This is a reland of a0728e869b
Original change's description:
> [d8] Remove maximum workers limitation
>
> This CL refactors the lifetime management of the v8::Worker C++ object
> and in the process lifts the 100 maximum worker limitation. To do this,
> it uses a Managed<v8::Worker> heap object and attaches the managed to
> the API worker object.
>
> R=mstarzinger@chromium.org
> BUG=v8:9524
>
> Change-Id: I279b7aeb6645a87f9108ee6f572105739721cef4
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1715453
> Commit-Queue: Ben Titzer <titzer@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#62932}
Bug: v8:9524
Change-Id: I7d903fb12ddb00909a9429455f46c55db2fd02de
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1722562
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62974}
64 lines
1.4 KiB
C++
64 lines
1.4 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-platform.h"
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/libplatform/task-queue.h"
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
|
|
using testing::InSequence;
|
|
using testing::IsNull;
|
|
using testing::StrictMock;
|
|
|
|
namespace v8 {
|
|
namespace platform {
|
|
namespace task_queue_unittest {
|
|
|
|
namespace {
|
|
|
|
struct MockTask : public Task {
|
|
MOCK_METHOD0(Run, void());
|
|
};
|
|
|
|
|
|
class TaskQueueThread final : public base::Thread {
|
|
public:
|
|
explicit TaskQueueThread(TaskQueue* queue)
|
|
: Thread(Options("libplatform TaskQueueThread")), queue_(queue) {}
|
|
|
|
void Run() override { EXPECT_THAT(queue_->GetNext(), IsNull()); }
|
|
|
|
private:
|
|
TaskQueue* queue_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
|
|
TEST(TaskQueueTest, Basic) {
|
|
TaskQueue queue;
|
|
std::unique_ptr<Task> task(new MockTask());
|
|
Task* ptr = task.get();
|
|
queue.Append(std::move(task));
|
|
EXPECT_EQ(ptr, queue.GetNext().get());
|
|
queue.Terminate();
|
|
EXPECT_THAT(queue.GetNext(), IsNull());
|
|
}
|
|
|
|
|
|
TEST(TaskQueueTest, TerminateMultipleReaders) {
|
|
TaskQueue queue;
|
|
TaskQueueThread thread1(&queue);
|
|
TaskQueueThread thread2(&queue);
|
|
CHECK(thread1.Start());
|
|
CHECK(thread2.Start());
|
|
queue.Terminate();
|
|
thread1.Join();
|
|
thread2.Join();
|
|
}
|
|
|
|
} // namespace task_queue_unittest
|
|
} // namespace platform
|
|
} // namespace v8
|