343eeb15aa
With "Value::parseBinary" now being revamped by https://crrev.com/c/2020518 and making use of "cbor::ParseCBOR", the extra endianness check is not needed anymore as "ParseCBOR" already switches the byte order in this line: crdtp/cbor.cc void ParseUTF16String(CBORTokenizer* tokenizer, ParserHandler* out) { .... for (size_t ii = 0; ii < rep.size(); ii += 2) value.push_back((rep[ii + 1] << 8) | rep[ii]); ... "String16EndianTest" does not go through the newly added pipeline and "ParseUTF16String" is never used which makes the test redundant. Change-Id: I6ad59fef7036c70d475b492407fd394977ca98f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2038716 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#66160}
66 lines
2.2 KiB
C++
66 lines
2.2 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <memory>
|
|
|
|
#include "test/cctest/cctest.h"
|
|
|
|
#include "include/v8-inspector.h"
|
|
#include "include/v8.h"
|
|
#include "src/inspector/protocol/Runtime.h"
|
|
|
|
using v8_inspector::StringBuffer;
|
|
using v8_inspector::StringView;
|
|
using v8_inspector::V8ContextInfo;
|
|
using v8_inspector::V8Inspector;
|
|
using v8_inspector::V8InspectorSession;
|
|
|
|
namespace {
|
|
|
|
class NoopChannel : public V8Inspector::Channel {
|
|
public:
|
|
~NoopChannel() override = default;
|
|
void sendResponse(int callId,
|
|
std::unique_ptr<StringBuffer> message) override {}
|
|
void sendNotification(std::unique_ptr<StringBuffer> message) override {}
|
|
void flushProtocolNotifications() override {}
|
|
};
|
|
|
|
void WrapOnInterrupt(v8::Isolate* isolate, void* data) {
|
|
const char* object_group = "";
|
|
StringView object_group_view(reinterpret_cast<const uint8_t*>(object_group),
|
|
strlen(object_group));
|
|
reinterpret_cast<V8InspectorSession*>(data)->wrapObject(
|
|
isolate->GetCurrentContext(), v8::Null(isolate), object_group_view,
|
|
false);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST(WrapInsideWrapOnInterrupt) {
|
|
LocalContext env;
|
|
v8::Isolate* isolate = env->GetIsolate();
|
|
v8::HandleScope handle_scope(isolate);
|
|
|
|
v8_inspector::V8InspectorClient default_client;
|
|
std::unique_ptr<V8Inspector> inspector =
|
|
V8Inspector::create(isolate, &default_client);
|
|
const char* name = "";
|
|
StringView name_view(reinterpret_cast<const uint8_t*>(name), strlen(name));
|
|
V8ContextInfo context_info(env.local(), 1, name_view);
|
|
inspector->contextCreated(context_info);
|
|
|
|
NoopChannel channel;
|
|
const char* state = "{}";
|
|
StringView state_view(reinterpret_cast<const uint8_t*>(state), strlen(state));
|
|
std::unique_ptr<V8InspectorSession> session =
|
|
inspector->connect(1, &channel, state_view);
|
|
|
|
const char* object_group = "";
|
|
StringView object_group_view(reinterpret_cast<const uint8_t*>(object_group),
|
|
strlen(object_group));
|
|
isolate->RequestInterrupt(&WrapOnInterrupt, session.get());
|
|
session->wrapObject(env.local(), v8::Null(isolate), object_group_view, false);
|
|
}
|