255bf2d65a
Do this by deleting code after calls to V8_Fatal() (either through UNREACHABLE() or FATAL()). Comments suggest that the returns there were needed to make a compiler happy, but all compilers seem to be happy with this change too. My guess is that either https://codereview.chromium.org/1393023003 which marked V8_Fatal() as noreturn, or https://chromium-review.googlesource.com/#/c/544845/ which switched to the C++11 spelling of noreturn, fixed the warnings that the explicit code after V8_Fatal() was supposed to silence. There's one more warning in src/compiler/machine-graph-verifier.cc, but fixing that changes behavior. I asked about that one in https://codereview.chromium.org/2573573004/#msg27 instead. Bug: chromium:346399 Change-Id: Ie9519d5432bdeaaf382e8390d8254d3b79e622e4 Reviewed-on: https://chromium-review.googlesource.com/669803 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48092}
82 lines
2.0 KiB
C++
82 lines
2.0 KiB
C++
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <cmath>
|
|
|
|
#include "src/base/logging.h"
|
|
#include "src/utils.h"
|
|
|
|
#include "src/dtoa.h"
|
|
|
|
#include "src/bignum-dtoa.h"
|
|
#include "src/double.h"
|
|
#include "src/fast-dtoa.h"
|
|
#include "src/fixed-dtoa.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
static BignumDtoaMode DtoaToBignumDtoaMode(DtoaMode dtoa_mode) {
|
|
switch (dtoa_mode) {
|
|
case DTOA_SHORTEST: return BIGNUM_DTOA_SHORTEST;
|
|
case DTOA_FIXED: return BIGNUM_DTOA_FIXED;
|
|
case DTOA_PRECISION: return BIGNUM_DTOA_PRECISION;
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
|
|
void DoubleToAscii(double v, DtoaMode mode, int requested_digits,
|
|
Vector<char> buffer, int* sign, int* length, int* point) {
|
|
DCHECK(!Double(v).IsSpecial());
|
|
DCHECK(mode == DTOA_SHORTEST || requested_digits >= 0);
|
|
|
|
if (Double(v).Sign() < 0) {
|
|
*sign = 1;
|
|
v = -v;
|
|
} else {
|
|
*sign = 0;
|
|
}
|
|
|
|
if (v == 0) {
|
|
buffer[0] = '0';
|
|
buffer[1] = '\0';
|
|
*length = 1;
|
|
*point = 1;
|
|
return;
|
|
}
|
|
|
|
if (mode == DTOA_PRECISION && requested_digits == 0) {
|
|
buffer[0] = '\0';
|
|
*length = 0;
|
|
return;
|
|
}
|
|
|
|
bool fast_worked;
|
|
switch (mode) {
|
|
case DTOA_SHORTEST:
|
|
fast_worked = FastDtoa(v, FAST_DTOA_SHORTEST, 0, buffer, length, point);
|
|
break;
|
|
case DTOA_FIXED:
|
|
fast_worked = FastFixedDtoa(v, requested_digits, buffer, length, point);
|
|
break;
|
|
case DTOA_PRECISION:
|
|
fast_worked = FastDtoa(v, FAST_DTOA_PRECISION, requested_digits,
|
|
buffer, length, point);
|
|
break;
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
if (fast_worked) return;
|
|
|
|
// If the fast dtoa didn't succeed use the slower bignum version.
|
|
BignumDtoaMode bignum_mode = DtoaToBignumDtoaMode(mode);
|
|
BignumDtoa(v, bignum_mode, requested_digits, buffer, length, point);
|
|
buffer[*length] = '\0';
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|