Go to file
vogelheim@chromium.org 6b1f74260a Prevent calls to ReturnValue::Set with pointer-valued types.
Currently, this code will compile:
  SomePointer* p = ...;
  ReturnValue r = ...;
  r.Set(p);

What happens is that ReturnValue::Set has no pointer-ish overloads, but
a bool one, and hence C++ will convert the pointer to a bool and use
the Set(bool) overload. In other words, the example above is equivalent
to: r.Set(p ? true : false); Which probably isn't what the author had
in mind. This change adds a Set(void*) overload whose body forces a
compile error, to prevent this from happening inadvertently. The only
use of this indeed turned out to be an error.

(Wait for issue 364025 before submitting.)

BUG=
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/240013004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21217 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-09 12:07:38 +00:00
benchmarks Fix bug in nextWeaker function of deltablue benchmark. 2013-10-25 13:21:46 +00:00
build Always include debugger support. 2014-04-25 11:00:37 +00:00
include Prevent calls to ReturnValue::Set with pointer-valued types. 2014-05-09 12:07:38 +00:00
samples Unbreak samples and tools. 2014-05-08 06:52:35 +00:00
src Eliminate further write barriers for old space allocations. 2014-05-09 12:06:48 +00:00
test Clean up Debugger::NotifyMessageHandler. 2014-05-09 09:24:32 +00:00
tools Add test case generator for runtime functions 2014-05-08 13:11:59 +00:00
.clang-format Change clang-format config to allow for two empty lines between functions 2013-12-03 10:39:21 +00:00
.DEPS.git Introduce .DEPS.git file to support full git checkouts 2014-04-23 12:28:43 +00:00
.gitignore Update .gitignore wrt promise test files. 2014-04-24 14:15:06 +00:00
AUTHORS Add ARM contributors to AUTHORS. 2014-02-12 11:54:34 +00:00
BUILD.gn Merge counters and v8-counters 2014-05-07 07:15:24 +00:00
ChangeLog Sync change log and version file with trunk. 2014-05-09 11:17:45 +00:00
codereview.settings Add settings for try server. 2013-12-17 12:24:25 +00:00
DEPS Introduce .DEPS.git file to support full git checkouts 2014-04-23 12:28:43 +00:00
LICENSE Update LICENSE date. 2014-02-18 10:50:22 +00:00
LICENSE.strongtalk Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.v8 Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.valgrind Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
Makefile Always include debugger support. 2014-04-25 11:00:37 +00:00
Makefile.android [Android]: Update Makefile.android to use platform-14 as minimum. 2014-05-06 09:08:32 +00:00
Makefile.nacl This should make the NaCl build jobs green again. 2014-04-17 14:22:20 +00:00
OWNERS Add rmcilroy@chromium.org to src/OWNERS. 2014-04-11 08:55:18 +00:00
PRESUBMIT.py Update tryserver configuration with new linux and arm bots. 2014-04-01 13:43:32 +00:00
WATCHLISTS Add myself to a watchlist for the public API. 2013-10-10 11:37:48 +00:00