AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
6b2c271cfb
v8/tools/testrunner
History
Jakob Linke de5df9aebc Reland "[maglev] Prevent lazy deopts during maglev's JumpLoop (=OSR)" 
This is a reland of commit 5d95bd39ca

Original change's description:
> [maglev] Prevent lazy deopts during maglev's JumpLoop (=OSR)
>
> The problem was that synchronous Maglev OSR potentially caused
> code deoptimization during compilation dependency finalization; this
> led to a lazy deopt when returning from the call to
> Runtime_CompileOptimizedOSRFromMaglev. However, a lazy deopt is
> disallowed at this point, since a) Maglev doesn't support marking an opcode as both lazy- and eager deopt, and b) the JumpLoop opcode
> is already marked as eager deopt since that's how OSR is implemented
> under the hood. See also the comment in runtime-compiler.cc.
>
> We fix this by changing synchronous Maglev-to-Turbofan OSR
> behavior s.t. actual OSR compilation is triggered from Ignition
> (and not from Maglev). In other words, when synchronous OSR is
> requested:
>
>  1. trigger an eager deopt from Maglev to Ignition by returning a
>     non-null code object from Runtime_CompileOptimizedOSRFromMaglev.
>  2. Ignition handles the pending OSR compile request (through
>     osr_urgency).
>
> This CL also reverts previous partial fixes:
>
> This reverts commit 21969e8e24.
> This reverts commit 6bcbcfed5c.
>
> Bug: chromium:1394279,v8:13585,v8:7700
> Change-Id: I3d64aa39575ad806ba2623102092176ca160ef0b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4110740
> Commit-Queue: Jakob Linke <jgruber@chromium.org>
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#84922}

Bug: chromium:1394279,v8:13585,v8:7700
Change-Id: Id9d1a1ab2dc36e481287a1a25863b45bf281920c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4110746
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Auto-Submit: Jakob Linke <jgruber@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84928}
2022-12-19 10:44:14 +00:00
..
local Reland "[maglev] Prevent lazy deopts during maglev's JumpLoop (=OSR)" 2022-12-19 10:44:14 +00:00
objects [resultdb] Make suffixes more distinguishable 2022-12-08 15:38:51 +00:00
outproc [test] testrunner: Print diff if stdout does not match 2022-07-26 13:05:27 +00:00
testdata [test] Add ClusterFuzz wheel to V8 and analyze crashes 2022-12-12 16:12:31 +00:00
testproc [heap] Enable fuzzing for --shared-space 2022-12-13 11:43:31 +00:00
utils [test] Add ClusterFuzz wheel to V8 and analyze crashes 2022-12-12 16:12:31 +00:00
__init__.py
base_runner.py [heap] Make stack thread-local and introduce stack markers 2022-10-21 13:02:07 +00:00
build_config.py Include write barrier in JS shared heap buildrunner config 2022-12-06 12:45:34 +00:00
num_fuzzer.py [resultdb] Add framework_name tag to ResultDB 2022-12-05 19:29:27 +00:00
OWNERS Use relative paths to OWNERS files 2019-08-12 13:52:52 +00:00
PRESUBMIT.py Allow V8 to run all unittests presubmit 2022-03-29 11:14:09 +00:00
standard_runner_test.py [resultdb] Make suffixes more distinguishable 2022-12-08 15:38:51 +00:00
standard_runner.py [resultdb] Add framework_name tag to ResultDB 2022-12-05 19:29:27 +00:00
test_config.py [test] Cleanup 2022-06-01 09:09:18 +00:00
trycatch_loader.js [d8][mjsunit][tools] Improve d8 file API 2021-06-01 13:37:57 +00:00