9691c5cf15
Function prototypes can be lazily allocated. This means they go into the temporary objects set that debug-eval uses to figure out if a write will be side-effect free. We were incorrectly classifying writes to function prototypes as side-effect free because the prototype happened to be lazily allocated when we first accessed it during debug-eval, but was actually reachable from the function (not allocated temporarily). To do this we introduced a way to temporarily turn off the temporary object tracking, and we use it when lazily allocating function prototypes. This could mean that we incorrectly report side-effects when writing to function prototypes for functions which were themselves created during debug-eval side-effect free mode. However, it's unclear if this is a problem, because function declarations set global variables which would already throw due to side-effects. Bug: chromium:1154193 Change-Id: I444a673662095f6deabaafdce3cdf3d86b71446d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581968 Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#71692}
101 lines
2.4 KiB
Plaintext
101 lines
2.4 KiB
Plaintext
Tests that Runtime.evaluate can run without side effects.
|
|
Test throwOnSideEffect: false
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
description : 2
|
|
type : number
|
|
value : 2
|
|
}
|
|
}
|
|
}
|
|
Test prototype extension expression with side-effect, with throwOnSideEffect: true
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
exceptionDetails : {
|
|
columnNumber : -1
|
|
exception : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
exceptionId : <exceptionId>
|
|
lineNumber : -1
|
|
scriptId : <scriptId>
|
|
text : Uncaught
|
|
}
|
|
result : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
}
|
|
}
|
|
Test expression with side-effect, with throwOnSideEffect: true
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
exceptionDetails : {
|
|
columnNumber : -1
|
|
exception : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
exceptionId : <exceptionId>
|
|
lineNumber : -1
|
|
scriptId : <scriptId>
|
|
text : Uncaught
|
|
}
|
|
result : {
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
}
|
|
}
|
|
Test expression without side-effect, with throwOnSideEffect: true
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
description : 4
|
|
type : number
|
|
value : 4
|
|
}
|
|
}
|
|
}
|
|
Test that debug break triggers without throwOnSideEffect
|
|
paused
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
description : 2
|
|
type : number
|
|
value : 2
|
|
}
|
|
}
|
|
}
|
|
Test that debug break does not trigger with throwOnSideEffect
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
description : 2
|
|
type : number
|
|
value : 2
|
|
}
|
|
}
|
|
}
|