5459468dd6
clang assumes 16-byte stack alignment, but incoming stack alignment isn't always guaranteed to be that way. It looks like v8 was lucky to not hit this so far. See https://crbug.com/418554 -- this makes v8's standalone config match Chromium. See also https://llvm.org/bugs/show_bug.cgi?id=21414 Maybe it's possible to change the caller of OnEntryHook() to guarantee the right alignment, but matching Chromium's build flags here seems like a good idea in general. BUG=v8:4928 LOG=n Committed: https://crrev.com/3afb3324941625559635380ef98a2ee73e370a0a Cr-Commit-Position: refs/heads/master@{#35597} Review URL: https://codereview.chromium.org/1899783002 Cr-Commit-Position: refs/heads/master@{#35662} |
||
|---|---|---|
| .. | ||
| config/win | ||
| mac | ||
| all.gyp | ||
| coverage_wrapper.py | ||
| detect_v8_host_arch.py | ||
| download_gold_plugin.py | ||
| features.gypi | ||
| get_landmines.py | ||
| gyp_environment.py | ||
| gyp_v8 | ||
| gyp_v8.py | ||
| has_valgrind.py | ||
| isolate.gypi | ||
| landmine_utils.py | ||
| landmines.py | ||
| OWNERS | ||
| README.txt | ||
| set_clang_warning_flags.gypi | ||
| shim_headers.gypi | ||
| standalone.gypi | ||
| toolchain.gypi | ||
| vs_toolchain.py | ||
For build instructions, please refer to: https://code.google.com/p/v8/wiki/BuildingWithGYP TL;DR version on *nix: $ make dependencies # Only needed once. $ make ia32.release -j8 $ make ia32.release.check # Optionally: run tests.