fe3d51e1b2
Currently, debugger pauses on async call schedule and then waits for Debugger.pauseOnAsyncCall with parentStackTraceId to actually schedule the pause. This CL combines these two steps: - For local async tasks, it just stores m_taskWithScheduledBreak at the time of schedule, to be able to pause once this task is run. - For external async tasks, it plumbs "should_pause" boolean in V8StackTraceId from the point of schedule to the point of execution, and schedules a pause once externalAsyncTaskStarted is called with "should_pause" set to true. This approach greatly simplifies the implementation, and reduced frontend to a single "breakOnAsyncCall: true" parameter in Debugger.stepInto. Drive-by: introduce hasScheduledBreakOnNextFunctionCall() to make SetBreakOnNextFunctionCall management more robust. Note: artificial pauses at async call schedule time are gone from test expectations - we now only pause when user actually wants to pause, which makes protocol much simpler. See also design doc linked in the bug. BUG=chromium:1000475 Change-Id: I2d16f79c599fe196b2aaeca8223c63437a2954a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783724 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63737}
217 lines
3.3 KiB
Plaintext
217 lines
3.3 KiB
Plaintext
Checks Debugger.scheduleStepIntoAsync.
|
|
|
|
Running test: testScheduleErrors
|
|
paused at:
|
|
function testNoScheduledTask() {
|
|
#debugger;
|
|
return 42;
|
|
|
|
paused at:
|
|
debugger;
|
|
#return 42;
|
|
}
|
|
|
|
paused at:
|
|
debugger;
|
|
return 42;#
|
|
}
|
|
|
|
|
|
Running test: testSimple
|
|
paused at:
|
|
function testSimple() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
}
|
|
|
|
paused at:
|
|
debugger;
|
|
Promise.resolve().then(v => v #* 2);
|
|
}
|
|
|
|
|
|
Running test: testNotResolvedPromise
|
|
paused at:
|
|
var p = new Promise(resolve => resolveCallback = resolve);
|
|
#debugger;
|
|
p.then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
p.#then(v => v * 2);
|
|
resolveCallback();
|
|
|
|
paused at:
|
|
debugger;
|
|
p.then(v => v #* 2);
|
|
resolveCallback();
|
|
|
|
|
|
Running test: testTwoAsyncTasks
|
|
paused at:
|
|
function testTwoAsyncTasks() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
paused at:
|
|
debugger;
|
|
Promise.resolve().then(v => v #* 2);
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
|
|
Running test: testTwoTasksAndGoToSecond
|
|
paused at:
|
|
function testTwoAsyncTasks() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
paused at:
|
|
Promise.resolve().then(v => v * 2);
|
|
#Promise.resolve().then(v => v * 4);
|
|
}
|
|
|
|
paused at:
|
|
Promise.resolve().then(v => v * 2);
|
|
Promise.resolve().then(v => v #* 4);
|
|
}
|
|
|
|
|
|
Running test: testTwoAsyncTasksWithBreak
|
|
paused at:
|
|
function testTwoAsyncTasksWithBreak() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
debugger;
|
|
|
|
paused at:
|
|
Promise.resolve().then(v => v * 2);
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 4);
|
|
}
|
|
|
|
paused at:
|
|
debugger;
|
|
Promise.resolve().then(v => v #* 4);
|
|
}
|
|
|
|
|
|
Running test: testPromiseAll
|
|
paused at:
|
|
function testPromiseAll() {
|
|
#debugger;
|
|
Promise.all([ Promise.resolve(), Promise.resolve() ]).then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.all([ Promise.resolve(), Promise.resolve() ]).then(v => v * 2);
|
|
}
|
|
|
|
paused at:
|
|
debugger;
|
|
Promise.all([ Promise.resolve(), Promise.resolve() ]).then(v => v #* 2);
|
|
}
|
|
|
|
|
|
Running test: testWithBlackboxedCode
|
|
paused at:
|
|
function testBlackboxedCreatePromise() {
|
|
#debugger;
|
|
createPromise().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#createPromise().then(v => v * 2);
|
|
}
|
|
|
|
paused at:
|
|
debugger;
|
|
createPromise().then(v => v #* 2);
|
|
}
|
|
|
|
|
|
Running test: testWithBlackboxedCode
|
|
paused at:
|
|
function testBlackboxedCreatePromise() {
|
|
#debugger;
|
|
createPromise().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#createPromise().then(v => v * 2);
|
|
}
|
|
|
|
paused at:
|
|
debugger;
|
|
createPromise().then(v => v #* 2);
|
|
}
|
|
|
|
|
|
Running test: testAsyncFunction
|
|
paused at:
|
|
async function testAsyncFunction() {
|
|
#debugger;
|
|
foo();
|
|
|
|
paused at:
|
|
debugger;
|
|
#foo();
|
|
await foo();
|
|
|
|
paused at:
|
|
async function foo() {
|
|
#return 42;
|
|
}
|
|
|
|
paused at:
|
|
foo();
|
|
await #foo();
|
|
foo().then(boo);
|
|
|
|
paused at:
|
|
async function foo() {
|
|
#return 42;
|
|
}
|
|
|
|
paused at:
|
|
await foo();
|
|
#foo().then(boo);
|
|
|
|
|
|
paused at:
|
|
async function foo() {
|
|
#return 42;
|
|
}
|
|
|
|
paused at:
|
|
await foo();
|
|
foo().#then(boo);
|
|
|
|
|
|
paused at:
|
|
function boo() {
|
|
#}
|
|
}
|
|
|