6fac39b333
Reason for revert:
Speculative revert. Seems to block the roll:
https://codereview.chromium.org/2822983004/
Might require changing a browser test first?
Original issue's description:
> [inspector] avoid cloning of async call chains
>
> - separated V8StackTraceImpl and AsyncStackTrace,
> - V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is reached (first created - first cleaned),
> - V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger have weak reference to other async stack traces.
> - async tasks are cleared with related async stacks.
>
> BUG=v8:6189
> R=dgozman@chromium.org
>
> Review-Url: https://codereview.chromium.org/2816043006
> Cr-Commit-Position: refs/heads/master@{#44670}
> Committed: 1bca73bc83
TBR=dgozman@chromium.org,kozyatinskiy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6189
Review-Url: https://codereview.chromium.org/2825713002
Cr-Commit-Position: refs/heads/master@{#44678}
165 lines
4.9 KiB
JavaScript
165 lines
4.9 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
InspectorTest.log('Checks that async stacks works good with different limits');
|
|
|
|
InspectorTest.addScript(`
|
|
var resolveTest;
|
|
|
|
function foo1() {
|
|
debugger;
|
|
}
|
|
|
|
function foo2() {
|
|
debugger;
|
|
if (resolveTest) resolveTest();
|
|
}
|
|
|
|
function promise() {
|
|
var resolve1;
|
|
var p1 = new Promise(resolve => resolve1 = resolve);
|
|
var p2 = p1.then(foo1);
|
|
resolve1();
|
|
return p2;
|
|
}
|
|
|
|
function twoPromises() {
|
|
var resolve1;
|
|
var resolve2;
|
|
var p1 = new Promise(resolve => resolve1 = resolve);
|
|
var p2 = new Promise(resolve => resolve2 = resolve);
|
|
var p3 = p1.then(foo1);
|
|
var p4 = p2.then(foo2);
|
|
resolve1();
|
|
resolve2();
|
|
return Promise.all([p3, p4]);
|
|
}
|
|
|
|
function twoSetTimeout() {
|
|
setTimeout(foo1, 0);
|
|
setTimeout(foo2, 0);
|
|
return new Promise(resolve => resolveTest = resolve);
|
|
}
|
|
|
|
function twentySetTimeout() {
|
|
var resolve1;
|
|
var p1 = new Promise(resolve => resolve1 = resolve);
|
|
for (var i = 1; i <= 19; ++i)
|
|
setTimeout('(function foo' + i + '(){debugger;})()',0);
|
|
setTimeout(resolve1, 0);
|
|
return p1;
|
|
}
|
|
|
|
//# sourceURL=test.js`, 7, 26);
|
|
|
|
InspectorTest.setupScriptMap();
|
|
Protocol.Debugger.onPaused(message => {
|
|
InspectorTest.logCallFrames(message.params.callFrames);
|
|
var asyncStackTrace = message.params.asyncStackTrace;
|
|
while (asyncStackTrace) {
|
|
InspectorTest.log(`-- ${asyncStackTrace.description} --`);
|
|
InspectorTest.logCallFrames(asyncStackTrace.callFrames);
|
|
asyncStackTrace = asyncStackTrace.parent;
|
|
}
|
|
InspectorTest.log('');
|
|
Protocol.Debugger.resume();
|
|
});
|
|
|
|
Protocol.Debugger.enable();
|
|
Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 128 });
|
|
InspectorTest.runTestSuite([
|
|
function testZeroLimit(next) {
|
|
Protocol.Runtime.evaluate({
|
|
expression: 'setMaxAsyncTaskStacks(0)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'promise()//# sourceURL=expr.js', awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testTwoLimit(next) {
|
|
// we need one stack for parent task and one for next task.
|
|
Protocol.Runtime
|
|
.evaluate({expression: 'setMaxAsyncTaskStacks(2)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'promise()//# sourceURL=expr.js',
|
|
awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testOneLimitTwoPromises(next) {
|
|
// Should be no async stacks because when first microtask is finished
|
|
// it will resolve and schedule p3 - will remove async stack for scheduled
|
|
// p2.
|
|
Protocol.Runtime.evaluate({
|
|
expression: 'setMaxAsyncTaskStacks(1)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'twoPromises()//# sourceURL=expr.js', awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testFourLimitTwoPromises(next) {
|
|
Protocol.Runtime
|
|
.evaluate({expression: 'setMaxAsyncTaskStacks(4)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'twoPromises()//# sourceURL=expr.js',
|
|
awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testSixLimitTwoPromises(next) {
|
|
Protocol.Runtime
|
|
.evaluate({expression: 'setMaxAsyncTaskStacks(6)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'twoPromises()//# sourceURL=expr.js',
|
|
awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testTwoLimitTwoSetTimeouts(next) {
|
|
Protocol.Runtime.evaluate({
|
|
expression: 'setMaxAsyncTaskStacks(2)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'twoSetTimeout()//# sourceURL=expr.js', awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testThreeLimitTwoSetTimeouts(next) {
|
|
Protocol.Runtime.evaluate({
|
|
expression: 'setMaxAsyncTaskStacks(3)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'twoSetTimeout()//# sourceURL=expr.js', awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testTenLimitTwentySetTimeouts(next) {
|
|
Protocol.Runtime.evaluate({
|
|
expression: 'setMaxAsyncTaskStacks(10)//# sourceURL=expr.js'})
|
|
.then(() => Protocol.Runtime.evaluate({
|
|
expression: 'twentySetTimeout()//# sourceURL=expr.js',
|
|
awaitPromise: true
|
|
}))
|
|
.then(() => cancelAllAsyncTasks())
|
|
.then(next);
|
|
}
|
|
]);
|
|
|
|
function cancelAllAsyncTasks() {
|
|
return Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 0 })
|
|
.then(() => Protocol.Debugger.setAsyncCallStackDepth({ maxDepth: 128 }));
|
|
}
|