627b6b2f06
This is a reland of e28dadc207
The original failure was due to a stale Win32 bot. The reland failure
was due to idempotent task deduplication returning the exact same
failure. See crbug/1196064
Original change's description:
> [ptr-cage] Rename IsolateRoot to PtrComprCageBase
>
> Currently, IsolateRoot is both the address of the Isolate root and the
> base address of the pointer compression reservation. This CL teases the
> two uses apart by renaming IsolateRoot to PtrComprCageBase.
>
> - In addition to V8_COMPRESS_POINTERS, add a
> V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE (vs SHARED_CAGE).
>
> - Rename GetIsolate* helpers to GetPtrComprCageBase. When
> V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE is true, the helpers remain as
> aliases to GetPtrComprCageBase.
>
> - Rename kPtrComprIsolateRootAlignment to kPtrComprCageBaseAlignment.
>
> Bug: v8:11460
> Change-Id: I1d715f678ce9a0b5731895612ca14f56579b1c48
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783672
> Commit-Queue: Shu-yu Guo <syg@chromium.org>
> Auto-Submit: Shu-yu Guo <syg@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#73790}
Bug: v8:11460
No-Try: true
Tbr: ishell@chromium.org
Tbr: rmcilroy@chromium.org
Change-Id: Id69311cf3267ebe1297fff159de0be48b15b65a3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2806546
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73795}
66 lines
1.9 KiB
C++
66 lines
1.9 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "debug-helper-internal.h"
|
|
#include "src/common/ptr-compr-inl.h"
|
|
#include "torque-generated/class-debug-readers.h"
|
|
|
|
namespace i = v8::internal;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
|
|
bool IsPointerCompressed(uintptr_t address) {
|
|
#if COMPRESS_POINTERS_BOOL
|
|
return address < i::kPtrComprCageReservationSize;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
uintptr_t EnsureDecompressed(uintptr_t address,
|
|
uintptr_t any_uncompressed_ptr) {
|
|
if (!COMPRESS_POINTERS_BOOL || !IsPointerCompressed(address)) return address;
|
|
return i::DecompressTaggedAny(any_uncompressed_ptr,
|
|
static_cast<i::Tagged_t>(address));
|
|
}
|
|
|
|
d::PropertyKind GetArrayKind(d::MemoryAccessResult mem_result) {
|
|
d::PropertyKind indexed_field_kind{};
|
|
switch (mem_result) {
|
|
case d::MemoryAccessResult::kOk:
|
|
indexed_field_kind = d::PropertyKind::kArrayOfKnownSize;
|
|
break;
|
|
case d::MemoryAccessResult::kAddressNotValid:
|
|
indexed_field_kind =
|
|
d::PropertyKind::kArrayOfUnknownSizeDueToInvalidMemory;
|
|
break;
|
|
default:
|
|
indexed_field_kind =
|
|
d::PropertyKind::kArrayOfUnknownSizeDueToValidButInaccessibleMemory;
|
|
break;
|
|
}
|
|
return indexed_field_kind;
|
|
}
|
|
|
|
std::vector<std::unique_ptr<ObjectProperty>> TqObject::GetProperties(
|
|
d::MemoryAccessor accessor) const {
|
|
return std::vector<std::unique_ptr<ObjectProperty>>();
|
|
}
|
|
|
|
const char* TqObject::GetName() const { return "v8::internal::Object"; }
|
|
|
|
void TqObject::Visit(TqObjectVisitor* visitor) const {
|
|
visitor->VisitObject(this);
|
|
}
|
|
|
|
bool TqObject::IsSuperclassOf(const TqObject* other) const {
|
|
return GetName() != other->GetName();
|
|
}
|
|
|
|
} // namespace debug_helper_internal
|
|
} // namespace internal
|
|
} // namespace v8
|