Go to file
Milad Fa 7255e1f8a9 [base] check if path leads to a valid file name
Passing directories to fopen is not a defined behaviour in C/C++.
A new test case added by https://crrev.com/c/3098189 is trying to
import directories which is expected to fail.

Test however is not passing on some platforms including on S390 Linux
as `fopen` is successful, size gets set to 0 and a (non-existent)
empty file gets returned.

This CL uses `stat` to make sure the path is valid and is
not a directory.

Change-Id: Ibcc762b21145d2198cba07953387a31f39f59300
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3102346
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#76389}
2021-08-19 12:34:27 +00:00
.github [github] Close PRs created on the V8 GitHub mirror automatically 2021-01-12 08:39:59 +00:00
bazel [bazel] Initial support to mjsunit tests 2021-08-09 14:12:02 +00:00
build_overrides [build] Remove obsolete gn flag 2021-01-11 15:50:59 +00:00
custom_deps Use relative paths to OWNERS files 2019-08-12 13:52:52 +00:00
docs Add OWNERS for docs/ 2019-05-15 12:06:15 +00:00
gni [LOONG64] Add LoongArch64 backend 2021-08-16 13:05:19 +00:00
include [api] Make JSStackComparableAddress private 2021-08-18 09:42:39 +00:00
infra [infra] Change loong-v comment to Loongson 2021-08-19 09:11:19 +00:00
samples Reland "[api] Add v8::Isolate::ThrowError helper" 2021-04-16 11:48:05 +00:00
src [base] check if path leads to a valid file name 2021-08-19 12:34:27 +00:00
test [js-perf-test] Fewer number-to-string conversions in Array benchmarks 2021-08-19 11:27:35 +00:00
testing [macros] Upstream Google3 changes 2021-06-24 16:36:14 +00:00
third_party Roll inspector-protocol to 32cf5f2bf4dc20c73ead291e68d2e2f6b638cd57 2021-07-09 13:01:24 +00:00
tools Revert "cppgc: Enable checks for assignments in prefinalizers" 2021-08-19 08:57:24 +00:00
.bazelrc [bazel] Support build mode compilation 2021-07-13 10:14:16 +00:00
.clang-format [clang-format] Don't derive pointer alignment 2017-01-17 09:28:19 +00:00
.clang-tidy [tool] Remove unfixed clang-tidy warnings to ease use. 2018-10-26 07:40:32 +00:00
.editorconfig Add .editorconfig 2017-07-28 13:39:24 +00:00
.flake8 Add .flake8 to allow for python style checking. 2019-07-19 21:44:03 +00:00
.git-blame-ignore-revs [infra] Update .git-blame-ignore-revs 2020-03-03 12:59:13 +00:00
.gitattributes .gitattributes: Mark minified emscripten js files as -diff 2018-09-19 16:27:10 +00:00
.gitignore [log] Include tickprocessor log files in git 2021-06-21 15:26:29 +00:00
.gn Revert "[build] Separate out inspector as a shared library" 2021-07-02 16:15:20 +00:00
.mailmap Restore consistency between .mailmap and AUTHORS 2021-06-24 08:58:04 +00:00
.vpython [tools] Implement confidence-based number of runs 2019-05-09 09:42:28 +00:00
.ycm_extra_conf.py [ycm] Fix python script 2021-07-29 09:48:32 +00:00
AUTHORS [date] Fix Date#getMinutes() test failures 2021-08-18 14:54:40 +00:00
BUILD.bazel [bazel] Adds src/heap/progress-bar.h 2021-08-19 11:30:48 +00:00
BUILD.gn heap: Fix TSAN race when setting a flag after page initialization 2021-08-19 10:28:57 +00:00
CODE_OF_CONDUCT.md
codereview.settings Make Gerrit the default code review for V8 2017-06-30 17:37:37 +00:00
COMMON_OWNERS Remove ulan@ from OWNERS 2021-06-08 13:10:21 +00:00
DEPS Update google_benchmark 2021-08-19 10:04:15 +00:00
DIR_METADATA Add DIR_METADATA files to v8. 2020-10-20 22:12:28 +00:00
ENG_REVIEW_OWNERS Update ENG_REVIEW_OWNERS 2021-02-25 14:28:32 +00:00
INFRA_OWNERS Add team members as owners 2020-08-18 08:29:04 +00:00
INTL_OWNERS add ftang as owner 2020-04-24 19:19:36 +00:00
LICENSE [wasm] Draft version of C/C++ Wasm API 2019-04-17 16:00:26 +00:00
LICENSE.fdlibm Add LICENSE.fdlibm for all the fdlibm imported sources. 2016-06-09 07:17:03 +00:00
LICENSE.strongtalk
LICENSE.v8
LOONG_OWNERS [LOONG64] Add LoongArch64 backend 2021-08-16 13:05:19 +00:00
MIPS_OWNERS [mips] Request to be an owner of MIPS files 2020-11-23 09:43:49 +00:00
OWNERS [LOONG64] Add LoongArch64 backend 2021-08-16 13:05:19 +00:00
PPC_OWNERS Adding myself to relevant OWNERS files. 2020-11-02 16:37:28 +00:00
PRESUBMIT.py [bigint] Move multiplication to src/bigint/ 2021-04-19 15:40:43 +00:00
README.md [docs] Change links from old wiki to v8.dev 2019-03-07 12:13:30 +00:00
RISCV_OWNERS [riscv64] Change one of the owners for RISCV. 2021-04-20 14:39:26 +00:00
S390_OWNERS Adding myself to relevant OWNERS files. 2020-11-02 16:37:28 +00:00
WATCHLISTS Reland "[watchlist] Add cbruni@ to api watchlist" 2021-08-10 13:51:49 +00:00
WORKSPACE [bazel] Adds ICU 2021-06-30 12:54:15 +00:00

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://v8.dev/docs

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned at v8.dev/docs/contribute.