Go to file
Nikolaos Papaspyrou 73a1c635fe heap: Fix the tracing of GC cycles
Conceptually, a full GC cycle completes when the sweeping phase is
finished. As sweeping is performed concurrently, this happens after
Heap::CollectGarbage has returned and, at the latest, before the next
full GC cycle begins. However, an arbitrary number of young GC cycles
may happen in the meantime. Tracing information for the sweeping phase
must be added to the corresponding full GC cycle event. Until now, this
was not done correctly: this information was added to the GCTracer's
current event and could thus be attributed to a subsequent young or full
GC cycle.

This CL introduces methods GCTracer::(Start|Stop)Cycle to delimit a
cycle (still allowing for full GC cycles to be interrupted by young GC
cycles). These methods are different from (Start|Stop)ObservablePause,
which delimit the observable pause of each GC. The events of "pending"
full GC cycles are kept until they are properly amended and reported,
when the sweeping phase is finished.

This is a reland of 4ad20bff97
which was reviewed here: https://crrev.com/3404733

Bug: v8:12503
Bug: chromium:1154636
Change-Id: Icc315b53cff1f3b19b8efe49db34340a5608bcd2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432211
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78911}
2022-02-02 20:46:01 +00:00
.github [github] Close PRs created on the V8 GitHub mirror automatically 2021-01-12 08:39:59 +00:00
bazel [bazel] Adds v8_enable_shared_ro_heap to v8_build_config 2022-01-28 10:00:56 +00:00
build_overrides [build] Remove obsolete gn flag 2021-01-11 15:50:59 +00:00
custom_deps Use relative paths to OWNERS files 2019-08-12 13:52:52 +00:00
docs Add OWNERS for docs/ 2019-05-15 12:06:15 +00:00
gni cppgc: young-gen: Prepare infra for young generation 2022-02-02 10:29:55 +00:00
include cppgc: young-gen: Prepare infra for young generation 2022-02-02 10:29:55 +00:00
infra [infra] Add python3 trybot 2022-01-28 18:18:38 +00:00
samples cppgc: Fix hello world 2022-01-25 16:34:14 +00:00
src heap: Fix the tracing of GC cycles 2022-02-02 20:46:01 +00:00
test heap: Fix the tracing of GC cycles 2022-02-02 20:46:01 +00:00
testing [test][cleanup] Fix -Wshadow warnings in unittests 2021-09-27 08:59:01 +00:00
third_party Update V8 DEPS. 2022-01-26 12:51:01 +00:00
tools [Intl] Part 1 of NumberFormat v3 2022-02-01 02:19:48 +00:00
.bazelrc [bazel] Use v8_enable_handle_zapping only in debug builds. 2022-01-11 11:32:39 +00:00
.clang-format [clang-format] Don't derive pointer alignment 2017-01-17 09:28:19 +00:00
.clang-tidy [tool] Remove unfixed clang-tidy warnings to ease use. 2018-10-26 07:40:32 +00:00
.editorconfig Add .editorconfig 2017-07-28 13:39:24 +00:00
.flake8 remove swarming_client 2021-08-24 10:39:33 +00:00
.git-blame-ignore-revs [infra] Update .git-blame-ignore-revs 2020-03-03 12:59:13 +00:00
.gitattributes .gitattributes: Mark minified emscripten js files as -diff 2018-09-19 16:27:10 +00:00
.gitignore remove swarming_client 2021-08-24 10:39:33 +00:00
.gn Revert "[build] Separate out inspector as a shared library" 2021-07-02 16:15:20 +00:00
.mailmap Restore consistency between .mailmap and AUTHORS 2021-06-24 08:58:04 +00:00
.vpython Verify mac-arm64 wheels for v8/.vpython spec. 2021-09-15 21:11:50 +00:00
.vpython3 Add vpython3 to DEPS 2021-11-05 18:08:29 +00:00
.ycm_extra_conf.py [ycm] Fix python script 2021-07-29 09:48:32 +00:00
AUTHORS [snapshot] The length of the snapshot version string is 64 bytes 2022-01-10 14:46:58 +00:00
BUILD.bazel Use aligned reads/writes in SandboxedPointer accessors when possible 2022-02-01 13:09:20 +00:00
BUILD.gn cppgc: young-gen: Prepare infra for young generation 2022-02-02 10:29:55 +00:00
CODE_OF_CONDUCT.md Explicitly state that the Chromium Code of Conduct also applies to V8 2016-03-02 09:51:24 +00:00
codereview.settings Make Gerrit the default code review for V8 2017-06-30 17:37:37 +00:00
COMMON_OWNERS [owners] Add nikolaos@ to common owners 2022-01-12 09:37:27 +00:00
DEPS Update V8 DEPS. 2022-02-02 03:50:35 +00:00
DIR_METADATA Add DIR_METADATA files to v8. 2020-10-20 22:12:28 +00:00
ENG_REVIEW_OWNERS Add verwaest@ to ENG_REVIEW_OWNERS. 2021-09-16 15:00:57 +00:00
INFRA_OWNERS Add team members as owners 2020-08-18 08:29:04 +00:00
INTL_OWNERS add ftang as owner 2020-04-24 19:19:36 +00:00
LICENSE [wasm] Draft version of C/C++ Wasm API 2019-04-17 16:00:26 +00:00
LICENSE.fdlibm Add LICENSE.fdlibm for all the fdlibm imported sources. 2016-06-09 07:17:03 +00:00
LICENSE.strongtalk Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.v8 Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LOONG_OWNERS [LOONG64] Add LoongArch64 backend 2021-08-16 13:05:19 +00:00
MIPS_OWNERS [mips] Add LiuYu to MIPS_OWNERS 2021-09-08 01:38:52 +00:00
OWNERS Let infra owners own all dot files 2021-11-05 18:57:18 +00:00
PPC_OWNERS Adding myself to relevant OWNERS files. 2020-11-02 16:37:28 +00:00
PRESUBMIT.py [bigint] Move multiplication to src/bigint/ 2021-04-19 15:40:43 +00:00
README.md [docs] Change links from old wiki to v8.dev 2019-03-07 12:13:30 +00:00
RISCV_OWNERS Add Lu Yahan to RISC-V owners list 2021-09-13 16:35:00 +00:00
S390_OWNERS Adding myself to relevant OWNERS files. 2020-11-02 16:37:28 +00:00
WATCHLISTS Add myself to heap/ watchlist 2021-11-08 16:58:14 +00:00
WORKSPACE [bazel] Cleanup style with Buildifier. 2022-01-11 10:00:36 +00:00

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://v8.dev/docs

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned at v8.dev/docs/contribute.