e268f3abac
This reverts commit 337d53e654.
Reason for revert: <REASONING>
Original change's description:
> Fix map-constructor-entry-side-effect2 test
>
> Bytecode flushing interferes with IsOptimized expectations.
>
> Bug: v8:7790,v8:11939
> Change-Id: I4aaf827cb198d0a93f18e106a95d72b143c79dfc
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999092
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
> Auto-Submit: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#75508}
Bug: v8:7790,v8:11939
Change-Id: Ie85acc3ec98a823186ecfb982f1d5310bce81d7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3000923
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75510}
57 lines
1.7 KiB
JavaScript
57 lines
1.7 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt
|
|
|
|
function TestMapConstructorEntrySideEffect(ctor) {
|
|
const originalPrototypeSet = ctor.prototype.set;
|
|
const k1 = {};
|
|
const k2 = {};
|
|
let callCount = 0;
|
|
const input = [
|
|
Object.defineProperty([, 1], "0", {
|
|
get() {
|
|
// Verify continuation retains original set function
|
|
ctor.prototype.set = () => {
|
|
callCount++;
|
|
};
|
|
return k1;
|
|
}
|
|
}),
|
|
[k2, 2]
|
|
];
|
|
const col = new ctor(input);
|
|
|
|
assertEquals(0, callCount);
|
|
if ('size' in col) assertEquals(2, col.size);
|
|
assertTrue(col.has(k1));
|
|
assertTrue(col.has(k2));
|
|
|
|
const col2 = new ctor(input);
|
|
|
|
assertEquals(2, callCount);
|
|
if ('size' in col) assertEquals(0, col2.size);
|
|
assertFalse(col2.has(k1));
|
|
assertFalse(col2.has(k2));
|
|
|
|
ctor.prototype.set = originalPrototypeSet;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(TestMapConstructorEntrySideEffect);
|
|
TestMapConstructorEntrySideEffect(Map);
|
|
TestMapConstructorEntrySideEffect(Map);
|
|
TestMapConstructorEntrySideEffect(Map);
|
|
%OptimizeFunctionOnNextCall(TestMapConstructorEntrySideEffect);
|
|
TestMapConstructorEntrySideEffect(Map);
|
|
assertOptimized(TestMapConstructorEntrySideEffect);
|
|
|
|
// This call would deopt
|
|
TestMapConstructorEntrySideEffect(WeakMap);
|
|
%PrepareFunctionForOptimization(TestMapConstructorEntrySideEffect);
|
|
TestMapConstructorEntrySideEffect(WeakMap);
|
|
TestMapConstructorEntrySideEffect(WeakMap);
|
|
%OptimizeFunctionOnNextCall(TestMapConstructorEntrySideEffect);
|
|
TestMapConstructorEntrySideEffect(WeakMap);
|
|
assertOptimized(TestMapConstructorEntrySideEffect);
|