ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
103 lines
3.3 KiB
C++
103 lines
3.3 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <limits.h>
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
|
|
#include <cctype>
|
|
#include <list>
|
|
|
|
#include "include/v8-context.h"
|
|
#include "include/v8-exception.h"
|
|
#include "include/v8-isolate.h"
|
|
#include "include/v8-local-handle.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "src/objects/objects.h"
|
|
#include "src/parsing/parse-info.h"
|
|
#include "src/parsing/parsing.h"
|
|
#include "src/parsing/preparser.h"
|
|
#include "test/fuzzer/fuzzer-support.h"
|
|
|
|
bool IsValidInput(const uint8_t* data, size_t size) {
|
|
// Ignore too long inputs as they tend to find OOM or timeouts, not real bugs.
|
|
if (size > 2048) return false;
|
|
|
|
std::vector<char> parentheses;
|
|
const char* ptr = reinterpret_cast<const char*>(data);
|
|
|
|
for (size_t i = 0; i != size; ++i) {
|
|
// Check that all characters in the data are valid.
|
|
if (!std::isspace(ptr[i]) && !std::isprint(ptr[i])) return false;
|
|
|
|
// Check balance of parentheses in the data.
|
|
switch (ptr[i]) {
|
|
case '(':
|
|
case '[':
|
|
case '{':
|
|
parentheses.push_back(ptr[i]);
|
|
break;
|
|
case ')':
|
|
if (parentheses.empty() || parentheses.back() != '(') return false;
|
|
parentheses.pop_back();
|
|
break;
|
|
case ']':
|
|
if (parentheses.empty() || parentheses.back() != '[') return false;
|
|
parentheses.pop_back();
|
|
break;
|
|
case '}':
|
|
if (parentheses.empty() || parentheses.back() != '{') return false;
|
|
parentheses.pop_back();
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
return parentheses.empty();
|
|
}
|
|
|
|
extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
|
|
if (!IsValidInput(data, size)) {
|
|
return 0;
|
|
}
|
|
|
|
v8_fuzzer::FuzzerSupport* support = v8_fuzzer::FuzzerSupport::Get();
|
|
v8::Isolate* isolate = support->GetIsolate();
|
|
|
|
v8::Isolate::Scope isolate_scope(isolate);
|
|
v8::HandleScope handle_scope(isolate);
|
|
v8::Context::Scope context_scope(support->GetContext());
|
|
v8::TryCatch try_catch(isolate);
|
|
|
|
v8::internal::Isolate* i_isolate =
|
|
reinterpret_cast<v8::internal::Isolate*>(isolate);
|
|
v8::internal::Factory* factory = i_isolate->factory();
|
|
|
|
if (size > INT_MAX) return 0;
|
|
v8::internal::MaybeHandle<v8::internal::String> source =
|
|
factory->NewStringFromOneByte(
|
|
v8::base::Vector<const uint8_t>(data, static_cast<int>(size)));
|
|
if (source.is_null()) return 0;
|
|
|
|
v8::internal::Handle<v8::internal::Script> script =
|
|
factory->NewScript(source.ToHandleChecked());
|
|
v8::internal::UnoptimizedCompileState state(i_isolate);
|
|
v8::internal::UnoptimizedCompileFlags flags =
|
|
v8::internal::UnoptimizedCompileFlags::ForScriptCompile(i_isolate,
|
|
*script);
|
|
v8::internal::ParseInfo info(i_isolate, flags, &state);
|
|
if (!v8::internal::parsing::ParseProgram(
|
|
&info, script, i_isolate, i::parsing::ReportStatisticsMode::kYes)) {
|
|
info.pending_error_handler()->PrepareErrors(i_isolate,
|
|
info.ast_value_factory());
|
|
info.pending_error_handler()->ReportErrors(i_isolate, script);
|
|
|
|
i_isolate->OptionalRescheduleException(true);
|
|
}
|
|
isolate->RequestGarbageCollectionForTesting(
|
|
v8::Isolate::kFullGarbageCollection);
|
|
return 0;
|
|
}
|